linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: Possible PCI Regression Linux 5.3-rc1
Date: Thu, 25 Jul 2019 13:21:23 +0000	[thread overview]
Message-ID: <SL2P216MB01873051649F3472F67172A080C10@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <c016b0b3-6e76-625d-e603-65ddb1286cf6@deltatee.com>

On Wed, Jul 24, 2019 at 09:48:19AM -0600, Logan Gunthorpe wrote:
> 
> 
> On 2019-07-24 7:38 a.m., Bjorn Helgaas wrote:
> > On Wed, Jul 24, 2019 at 12:54:00PM +0000, Nicholas Johnson wrote:
> >> Hi all,
> >>
> >> I was just rebasing my patches for linux 5.3-rc1 and noticed a possible 
> >> regression that shows on both of my machines. It is also reproducible 
> >> with the unmodified Ubuntu mainline kernel, downloadable at [1].
> >>
> >> Running the lspci command takes 1-3 seconds with 5.3-rc1 (rather than an 
> >> imperceivable amount of time). Booting with pci.dyndbg does not reveal 
> >> why.
> >>
> >> $ uname -r
> >> 5.3.0-050300rc1-generic
> >> $ time lspci -vt 1>/dev/null
> >>
> >> real	0m2.321s
> >> user	0m0.026s
> >> sys	0m0.000s
> >>
> >> If none of you are aware of this or what is causing it, I will submit a 
> >> bug report to Bugzilla.
> > 
> > I wasn't aware of this; thanks for reporting it!  I wasn't able to
> > reproduce this in qemu.  Can you play with "strace -r lspci -vt" and
> > the like?  Maybe try "lspci -n" to see if it's related to looking up
> > the names?
> I also just tested 5.3-rc1 on my machine and lspci behaves normally.
> 
> Logan

I have looked deeper into this and it seems that removing the 
Thunderbolt controller from the root port with sysfs resolves the issue. 
If the system you tried this on does not have Thunderbolt, then you will 
not have been able to reproduce the bug. Please see the message to Bjorn 
which you are carbon copied into for more elaboration.

Thanks for looking at this.

Regards,
Nicholas

  reply	other threads:[~2019-07-25 13:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24 12:54 Possible PCI Regression Linux 5.3-rc1 Nicholas Johnson
2019-07-24 13:38 ` Bjorn Helgaas
2019-07-24 15:48   ` Logan Gunthorpe
2019-07-25 13:21     ` Nicholas Johnson [this message]
2019-07-25 13:18   ` Nicholas Johnson
2019-07-25 15:50     ` Logan Gunthorpe
2019-08-04  8:47       ` Nicholas Johnson
2019-08-05  8:59         ` Nicholas Johnson
2019-08-05 12:34         ` Mika Westerberg
2019-08-05 14:09           ` Nicholas Johnson
2019-08-05 14:25           ` Nicholas Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SL2P216MB01873051649F3472F67172A080C10@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM \
    --to=nicholas.johnson-opensource@outlook.com.au \
    --cc=benh@kernel.crashing.org \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).