Linux-PCI Archive on lore.kernel.org
 help / color / Atom feed
From: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"mika.westerberg@linux.intel.com"
	<mika.westerberg@linux.intel.com>,
	"corbet@lwn.net" <corbet@lwn.net>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Logan Gunthorpe <logang@deltatee.com>
Subject: Re: [PATCH v6 0/4] PCI: Patch series to support Thunderbolt without any BIOS support
Date: Mon, 1 Jul 2019 14:33:34 +0000
Message-ID: <SL2P216MB0187E8F8592C37936D074B0F80F90@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20190615195604.GW13533@google.com>

On Sun, Jun 16, 2019 at 03:56:19AM +0800, Bjorn Helgaas wrote:
> [+cc Ben, Logan]
> 
> Ben, Logan, since you're looking at the resource code, maybe you'd be
> interested in this as well?
> 
> On Wed, May 22, 2019 at 02:30:30PM +0000, Nicholas Johnson wrote:
> > Rebase patches to apply cleanly to 5.2-rc1 source. Remove patch for 
> > comment style cleanup as this has already been applied.
> 
> Thanks for rebasing these.
> 
> They do apply cleanly, but they seem to be base64-encoded MIME
> attachments, and I don't know how to make mutt extract them easily.  I
> had to save each patch attachment individually, apply it, insert the
> commit log manually, etc.
> 
> Is there any chance you could send the next series as plain-text
> patches?  That would be a lot easier for me.
> 
> > Anybody interested in testing, you can do so with:
> > 
> > a) Intel system with Thunderbolt 3 and native enumeration. The Gigabyte 
> > Z390 Designare is one of the most perfect for this that I have never had 
> > the opportunity to use - it does not even have the option for BIOS 
> > assisted enumeration present in the BIOS.
> > 
> > b) Any system with PCIe and the Gigabyte GC-TITAN RIDGE add-in card, 
> > jump the header as described and use kernel parameters like:
> > 
> > pci=assign-busses,hpbussize=0x33,realloc,hpmemsize=128M,hpmemprefsize=1G,nocrs 
> > pcie_ports=native
> > 
> > [optional] pci.dyndbg
> > 
> >     ___
> >  __/   \__
> > |o o o o o| When looking into the receptacle on back of PCIe card.
> > |_________| Jump pins 3 and 5.
> > 
> >  1 2 3 4 5
> > 
> > The Intel system is nice in that it should just work. The add-in card 
> > setup is nice in that you can go nuts and assign copious amounts of 
> > MMIO_PREF - can anybody show a Xeon Phi coprocessor with 16G BAR working 
> > in an eGPU enclosure with these patches?
> > 
> > However, if you specify the above kernel parameters on the Intel system, 
> > you should be able to override it to allocate more space.
> > 
> > Nicholas Johnson (4):
> >   PCI: Consider alignment of hot-added bridges when distributing
> >     available resources
> >   PCI: Modify extend_bridge_window() to set resource size directly
> >   PCI: Fix bug resulting in double hpmemsize being assigned to MMIO
> >     window
> >   PCI: Add pci=hpmemprefsize parameter to set MMIO_PREF size
> >     independently
> > 
> >  .../admin-guide/kernel-parameters.txt         |   7 +-
> >  drivers/pci/pci.c                             |  18 +-
> >  drivers/pci/setup-bus.c                       | 265 ++++++++++--------
> >  include/linux/pci.h                           |   3 +-
> >  4 files changed, 167 insertions(+), 126 deletions(-)
> > 
> > -- 
> > 2.20.1
> > 
I posted PATCH v7, finally. I needed a place to announce that the 
patches 1-2/8 which were made by Bjorn would not send with him as the 
"from" which seems to attribute the author.

Credits go to Bjorn for PATCH v7 1-2/8 (the first two patches) but to
send them I had to put myself in that field.

When applying them, I guess you will have to modify that field, Bjorn. 
My apologies if there was a way around it.

Thanks for all the comments and feedback from everybody.

      parent reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 14:30 Nicholas Johnson
2019-06-15 19:56 ` Bjorn Helgaas
2019-06-17 16:55   ` Logan Gunthorpe
2019-07-01 14:33   ` Nicholas Johnson [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SL2P216MB0187E8F8592C37936D074B0F80F90@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM \
    --to=nicholas.johnson-opensource@outlook.com.au \
    --cc=benh@kernel.crashing.org \
    --cc=corbet@lwn.net \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PCI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \
		linux-pci@vger.kernel.org linux-pci@archiver.kernel.org
	public-inbox-index linux-pci


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox