From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: "marek.vasut@gmail.com" <marek.vasut@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Cc: Marek Vasut <marek.vasut+renesas@gmail.com>,
Andrew Murray <andrew.murray@arm.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Wolfram Sang <wsa@the-dreams.de>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH V4 1/2] PCI: rcar: Move the inbound index check
Date: Mon, 28 Oct 2019 08:24:07 +0000 [thread overview]
Message-ID: <TYAPR01MB4544C7DA109A5F449D1377B9D8660@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20191026182659.2390-1-marek.vasut@gmail.com>
Hi Marek-san,
> From: Marek Vasut, Sent: Sunday, October 27, 2019 3:27 AM
>
> Since the $idx variable value is stored across multiple calls to
> rcar_pcie_inbound_ranges() function, and the $idx value is used to
> index registers which are written, subsequent calls might cause
> the $idx value to be high enough to trigger writes into nonexistent
> registers.
>
> Fix this by moving the $idx value check to the beginning of the loop.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Reviewed-by: Andrew Murray <andrew.murray@arm.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Cc: linux-renesas-soc@vger.kernel.org
> To: linux-pci@vger.kernel.org
> ---
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2019-10-28 8:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 18:26 [PATCH V4 1/2] PCI: rcar: Move the inbound index check marek.vasut
2019-10-26 18:26 ` [PATCH V4 2/2] PCI: rcar: Recalculate inbound range alignment for each controller entry marek.vasut
2019-10-28 8:35 ` Yoshihiro Shimoda
2019-10-28 10:20 ` Lorenzo Pieralisi
2019-10-29 1:18 ` Yoshihiro Shimoda
2019-10-29 10:34 ` Lorenzo Pieralisi
2019-10-29 11:12 ` Yoshihiro Shimoda
2019-10-28 8:24 ` Yoshihiro Shimoda [this message]
2019-10-29 11:37 ` [PATCH V4 1/2] PCI: rcar: Move the inbound index check Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB4544C7DA109A5F449D1377B9D8660@TYAPR01MB4544.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=andrew.murray@arm.com \
--cc=geert+renesas@glider.be \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).