* [PATCH] phy: freescale: imx8m-pcie: Add one missing error return
@ 2022-12-19 7:12 Richard Zhu
2022-12-19 7:36 ` Marek Vasut
2023-01-13 17:55 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Richard Zhu @ 2022-12-19 7:12 UTC (permalink / raw)
To: vkoul, marex, alexander.stein, lorenzo.pieralisi
Cc: linux-phy, linux-pci, linux-arm-kernel, linux-kernel, kernel,
linux-imx, Richard Zhu
There should be one error return when fail to fetch the perst reset.
Add the missing error return.
Fixes: dce9edff16ee ("phy: freescale: imx8m-pcie: Add i.MX8MP PCIe PHY support")
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
index 7585e8080b77..afc63552ecaf 100644
--- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
+++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
@@ -255,7 +255,7 @@ static int imx8_pcie_phy_probe(struct platform_device *pdev)
imx8_phy->perst =
devm_reset_control_get_exclusive(dev, "perst");
if (IS_ERR(imx8_phy->perst))
- dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
+ return dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
"Failed to get PCIE PHY PERST control\n");
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: freescale: imx8m-pcie: Add one missing error return
2022-12-19 7:12 [PATCH] phy: freescale: imx8m-pcie: Add one missing error return Richard Zhu
@ 2022-12-19 7:36 ` Marek Vasut
2023-01-13 17:55 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2022-12-19 7:36 UTC (permalink / raw)
To: Richard Zhu, vkoul, alexander.stein, lorenzo.pieralisi
Cc: linux-phy, linux-pci, linux-arm-kernel, linux-kernel, kernel, linux-imx
On 12/19/22 08:12, Richard Zhu wrote:
> There should be one error return when fail to fetch the perst reset.
> Add the missing error return.
>
> Fixes: dce9edff16ee ("phy: freescale: imx8m-pcie: Add i.MX8MP PCIe PHY support")
>
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
Reviewed-by: Marek Vasut <marex@denx.de>
> ---
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> index 7585e8080b77..afc63552ecaf 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> @@ -255,7 +255,7 @@ static int imx8_pcie_phy_probe(struct platform_device *pdev)
> imx8_phy->perst =
> devm_reset_control_get_exclusive(dev, "perst");
> if (IS_ERR(imx8_phy->perst))
> - dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
> + return dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
> "Failed to get PCIE PHY PERST control\n");
> }
Thanks !
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: freescale: imx8m-pcie: Add one missing error return
2022-12-19 7:12 [PATCH] phy: freescale: imx8m-pcie: Add one missing error return Richard Zhu
2022-12-19 7:36 ` Marek Vasut
@ 2023-01-13 17:55 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-01-13 17:55 UTC (permalink / raw)
To: Richard Zhu
Cc: marex, alexander.stein, lorenzo.pieralisi, linux-phy, linux-pci,
linux-arm-kernel, linux-kernel, kernel, linux-imx
On 19-12-22, 15:12, Richard Zhu wrote:
> There should be one error return when fail to fetch the perst reset.
> Add the missing error return.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-13 18:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-19 7:12 [PATCH] phy: freescale: imx8m-pcie: Add one missing error return Richard Zhu
2022-12-19 7:36 ` Marek Vasut
2023-01-13 17:55 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).