From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rob Herring <robh@kernel.org>
Cc: Michael Walle <michael@walle.cc>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
PCI <linux-pci@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Minghuan Lian <minghuan.Lian@nxp.com>,
Mingkai Hu <mingkai.hu@nxp.com>, Roy Zang <roy.zang@nxp.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Saravana Kannan <saravanak@google.com>
Subject: Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()
Date: Wed, 20 Jan 2021 16:50:17 +0100 [thread overview]
Message-ID: <YAhROU8A8ZHduptZ@kroah.com> (raw)
In-Reply-To: <CAL_JsqLSJCLtgPyAdKSqsy=JoHSLYef_0s-stTbiJ+VCq2qaSA@mail.gmail.com>
On Wed, Jan 20, 2021 at 08:23:59AM -0600, Rob Herring wrote:
> On Wed, Jan 20, 2021 at 4:53 AM Michael Walle <michael@walle.cc> wrote:
> >
> > fw_devlink will defer the probe until all suppliers are ready. We can't
> > use builtin_platform_driver_probe() because it doesn't retry after probe
> > deferral. Convert it to builtin_platform_driver().
>
> If builtin_platform_driver_probe() doesn't work with fw_devlink, then
> shouldn't it be fixed or removed? Then we're not fixing drivers later
> when folks start caring about deferred probe and devlink.
>
> I'd really prefer if we convert this to a module instead. (And all the
> other PCI host drivers.)
>
> > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")
>
> This happened!?
It's in linux-next in my tree, but is looking like it might be reverted
soon. But finding these issues is good.
thanks,
greg k-h
next prev parent reply other threads:[~2021-01-20 15:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 10:52 [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver() Michael Walle
2021-01-20 14:23 ` Rob Herring
2021-01-20 14:34 ` Michael Walle
2021-01-20 15:50 ` Greg Kroah-Hartman [this message]
2021-01-20 19:02 ` Saravana Kannan
2021-01-20 19:25 ` Michael Walle
2021-01-20 19:28 ` Michael Walle
2021-01-20 19:47 ` Saravana Kannan
2021-01-20 19:47 ` Saravana Kannan
2021-01-20 23:53 ` Michael Walle
2021-01-20 23:58 ` Saravana Kannan
2021-01-21 11:01 ` Geert Uytterhoeven
2021-01-25 19:49 ` Michael Walle
2021-01-25 22:41 ` Saravana Kannan
2021-01-26 8:50 ` Geert Uytterhoeven
2021-01-27 0:44 ` Saravana Kannan
2021-01-27 7:43 ` Geert Uytterhoeven
2021-01-27 16:41 ` Saravana Kannan
2021-01-27 16:56 ` Geert Uytterhoeven
2021-01-27 17:10 ` Saravana Kannan
2021-01-28 9:25 ` Geert Uytterhoeven
2021-01-28 10:35 ` Tony Lindgren
2021-01-28 10:00 ` Tony Lindgren
2021-01-25 16:50 ` Lorenzo Pieralisi
2021-01-25 18:58 ` Saravana Kannan
2021-01-25 19:44 ` Michael Walle
2021-01-26 10:02 ` Lorenzo Pieralisi
2021-01-26 10:39 ` Michael Walle
2021-01-26 10:56 ` Geert Uytterhoeven
2021-01-26 10:55 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAhROU8A8ZHduptZ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=michael@walle.cc \
--cc=minghuan.Lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=robh@kernel.org \
--cc=roy.zang@nxp.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).