linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Saravana Kannan <saravanak@google.com>,
	Roy Zang <roy.zang@nxp.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	PCI <linux-pci@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Minghuan Lian <minghuan.Lian@nxp.com>,
	Michael Walle <michael@walle.cc>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Mingkai Hu <mingkai.hu@nxp.com>
Subject: Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()
Date: Thu, 28 Jan 2021 12:35:21 +0200	[thread overview]
Message-ID: <YBKTadhZZsySC9ak@atomide.com> (raw)
In-Reply-To: <CAMuHMdVHouzMFiGcUz=0M0_RFL-OBvkRvQiF5h56XKDMZuC7Kg@mail.gmail.com>

* Geert Uytterhoeven <geert@linux-m68k.org> [210128 09:32]:
> It wasn't.  The regression is that the driver no longer probes at first
> try, because its dependencies are now probed later.  The question is:
> why are the dependencies now probed later?  How to fix that?

I'm afraid that may be unfixable.. It depends on things like the bus
driver probe that might get also deferred.

As suggested, I agree it's best to get rid of builtin_platform_driver_probe
where possible at the cost of dropping the __init as needed.

To me it seems we can't even add a warning to __platform_driver_probe()
if there's drv->driver.of_match_table for example. That warning would
show up on all the devices with driver in question built in even if
the device has no such hardware.

Regards,

Tony

  reply	other threads:[~2021-01-28 10:36 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 10:52 [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver() Michael Walle
2021-01-20 14:23 ` Rob Herring
2021-01-20 14:34   ` Michael Walle
2021-01-20 15:50   ` Greg Kroah-Hartman
2021-01-20 19:02   ` Saravana Kannan
2021-01-20 19:25     ` Michael Walle
2021-01-20 19:28     ` Michael Walle
2021-01-20 19:47       ` Saravana Kannan
2021-01-20 19:47         ` Saravana Kannan
2021-01-20 23:53         ` Michael Walle
2021-01-20 23:58           ` Saravana Kannan
2021-01-21 11:01             ` Geert Uytterhoeven
2021-01-25 19:49               ` Michael Walle
2021-01-25 22:41                 ` Saravana Kannan
2021-01-26  8:50                   ` Geert Uytterhoeven
2021-01-27  0:44                     ` Saravana Kannan
2021-01-27  7:43                       ` Geert Uytterhoeven
2021-01-27 16:41                         ` Saravana Kannan
2021-01-27 16:56                           ` Geert Uytterhoeven
2021-01-27 17:10                             ` Saravana Kannan
2021-01-28  9:25                               ` Geert Uytterhoeven
2021-01-28 10:35                                 ` Tony Lindgren [this message]
2021-01-28 10:00                 ` Tony Lindgren
2021-01-25 16:50       ` Lorenzo Pieralisi
2021-01-25 18:58         ` Saravana Kannan
2021-01-25 19:44           ` Michael Walle
2021-01-26 10:02 ` Lorenzo Pieralisi
2021-01-26 10:39   ` Michael Walle
2021-01-26 10:56     ` Geert Uytterhoeven
2021-01-26 10:55 ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBKTadhZZsySC9ak@atomide.com \
    --to=tony@atomide.com \
    --cc=bhelgaas@google.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=michael@walle.cc \
    --cc=minghuan.Lian@nxp.com \
    --cc=mingkai.hu@nxp.com \
    --cc=roy.zang@nxp.com \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).