* [PATCH] PCI: hotplug: Remove unused function pointer typedef acpiphp_callback
@ 2021-02-16 2:38 Chen Lin
2021-02-16 3:00 ` Krzysztof Wilczyński
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chen Lin @ 2021-02-16 2:38 UTC (permalink / raw)
To: rjw; +Cc: lenb, bhelgaas, linux-acpi, linux-pci, linux-kernel, Chen Lin
From: Chen Lin <chen.lin5@zte.com.cn>
Remove the 'acpiphp_callback' typedef as it is not used.
Signed-off-by: Chen Lin <chen.lin5@zte.com.cn>
---
drivers/pci/hotplug/acpiphp.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
index a2094c0..a74b274 100644
--- a/drivers/pci/hotplug/acpiphp.h
+++ b/drivers/pci/hotplug/acpiphp.h
@@ -176,9 +176,6 @@ struct acpiphp_attention_info
int acpiphp_register_hotplug_slot(struct acpiphp_slot *slot, unsigned int sun);
void acpiphp_unregister_hotplug_slot(struct acpiphp_slot *slot);
-/* acpiphp_glue.c */
-typedef int (*acpiphp_callback)(struct acpiphp_slot *slot, void *data);
-
int acpiphp_enable_slot(struct acpiphp_slot *slot);
int acpiphp_disable_slot(struct acpiphp_slot *slot);
u8 acpiphp_get_power_status(struct acpiphp_slot *slot);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: hotplug: Remove unused function pointer typedef acpiphp_callback
2021-02-16 2:38 [PATCH] PCI: hotplug: Remove unused function pointer typedef acpiphp_callback Chen Lin
@ 2021-02-16 3:00 ` Krzysztof Wilczyński
2021-02-16 14:36 ` Rafael J. Wysocki
2021-02-18 23:33 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Wilczyński @ 2021-02-16 3:00 UTC (permalink / raw)
To: Chen Lin
Cc: rjw, lenb, helgaas, linux-acpi, linux-pci, linux-kernel, Chen Lin
Hi Chen,
> Remove the 'acpiphp_callback' typedef as it is not used.
[...]
Good catch!
This typedef was initially added in 2005, and then it stopped being used
around the Kernel version 3.7 release, which is also when the sole user
of this typedef called acpiphp_for_each_slot() has also been retired.
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: hotplug: Remove unused function pointer typedef acpiphp_callback
2021-02-16 2:38 [PATCH] PCI: hotplug: Remove unused function pointer typedef acpiphp_callback Chen Lin
2021-02-16 3:00 ` Krzysztof Wilczyński
@ 2021-02-16 14:36 ` Rafael J. Wysocki
2021-02-18 23:33 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2021-02-16 14:36 UTC (permalink / raw)
To: Chen Lin
Cc: Rafael J. Wysocki, Len Brown, Bjorn Helgaas,
ACPI Devel Maling List, Linux PCI, Linux Kernel Mailing List,
Chen Lin
On Tue, Feb 16, 2021 at 3:40 AM Chen Lin <chen45464546@163.com> wrote:
>
> From: Chen Lin <chen.lin5@zte.com.cn>
>
> Remove the 'acpiphp_callback' typedef as it is not used.
>
> Signed-off-by: Chen Lin <chen.lin5@zte.com.cn>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/pci/hotplug/acpiphp.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
> index a2094c0..a74b274 100644
> --- a/drivers/pci/hotplug/acpiphp.h
> +++ b/drivers/pci/hotplug/acpiphp.h
> @@ -176,9 +176,6 @@ struct acpiphp_attention_info
> int acpiphp_register_hotplug_slot(struct acpiphp_slot *slot, unsigned int sun);
> void acpiphp_unregister_hotplug_slot(struct acpiphp_slot *slot);
>
> -/* acpiphp_glue.c */
> -typedef int (*acpiphp_callback)(struct acpiphp_slot *slot, void *data);
> -
> int acpiphp_enable_slot(struct acpiphp_slot *slot);
> int acpiphp_disable_slot(struct acpiphp_slot *slot);
> u8 acpiphp_get_power_status(struct acpiphp_slot *slot);
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: hotplug: Remove unused function pointer typedef acpiphp_callback
2021-02-16 2:38 [PATCH] PCI: hotplug: Remove unused function pointer typedef acpiphp_callback Chen Lin
2021-02-16 3:00 ` Krzysztof Wilczyński
2021-02-16 14:36 ` Rafael J. Wysocki
@ 2021-02-18 23:33 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2021-02-18 23:33 UTC (permalink / raw)
To: Chen Lin
Cc: rjw, lenb, bhelgaas, linux-acpi, linux-pci, linux-kernel, Chen Lin
On Tue, Feb 16, 2021 at 10:38:40AM +0800, Chen Lin wrote:
> From: Chen Lin <chen.lin5@zte.com.cn>
>
> Remove the 'acpiphp_callback' typedef as it is not used.
>
> Signed-off-by: Chen Lin <chen.lin5@zte.com.cn>
Applied to pci/hotplug for v5.12, thanks!
> ---
> drivers/pci/hotplug/acpiphp.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
> index a2094c0..a74b274 100644
> --- a/drivers/pci/hotplug/acpiphp.h
> +++ b/drivers/pci/hotplug/acpiphp.h
> @@ -176,9 +176,6 @@ struct acpiphp_attention_info
> int acpiphp_register_hotplug_slot(struct acpiphp_slot *slot, unsigned int sun);
> void acpiphp_unregister_hotplug_slot(struct acpiphp_slot *slot);
>
> -/* acpiphp_glue.c */
> -typedef int (*acpiphp_callback)(struct acpiphp_slot *slot, void *data);
> -
> int acpiphp_enable_slot(struct acpiphp_slot *slot);
> int acpiphp_disable_slot(struct acpiphp_slot *slot);
> u8 acpiphp_get_power_status(struct acpiphp_slot *slot);
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-18 23:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-16 2:38 [PATCH] PCI: hotplug: Remove unused function pointer typedef acpiphp_callback Chen Lin
2021-02-16 3:00 ` Krzysztof Wilczyński
2021-02-16 14:36 ` Rafael J. Wysocki
2021-02-18 23:33 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).