From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Vidya Sagar <vidyas@nvidia.com>,
bhelgaas@google.com, lorenzo.pieralisi@arm.com,
rjw@rjwysocki.net, lenb@kernel.org, andrew.murray@arm.com,
treding@nvidia.com, jonathanh@nvidia.com,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH V3 2/2] PCI: Add MCFG quirks for Tegra194 host controllers
Date: Sat, 6 Mar 2021 00:04:49 +0100 [thread overview]
Message-ID: <YEK5EW1ZBDOKZE5E@rocinante> (raw)
In-Reply-To: <20210305215749.GA1117765@bjorn-Precision-5520>
Hi Bjorn and Vidya,
[...]
> > +}
> > +
> > +struct pci_ecam_ops tegra194_pcie_ops = {
> > + .bus_shift = 20,
>
> I think e7708f5b10e2 ("PCI: Unify ECAM constants in native PCI Express
> drivers") means you don't need this .bus_shift.
[...]
Correct. If this platform implements ECAM as per the specification,
then the .bus_shift initializer is no longer needed.
Krzysztof
next prev parent reply other threads:[~2021-03-05 23:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 17:49 [PATCH] PCI: Add MCFG quirks for Tegra194 host controllers Vidya Sagar
2020-01-03 18:04 ` Bjorn Helgaas
2020-01-04 3:44 ` Vidya Sagar
2020-01-17 12:17 ` Lorenzo Pieralisi
2020-01-20 11:10 ` Thierry Reding
2020-01-20 15:18 ` Lorenzo Pieralisi
2020-01-21 13:44 ` Thierry Reding
2020-01-23 10:49 ` Lorenzo Pieralisi
2020-02-06 16:46 ` Thierry Reding
2020-02-07 14:50 ` Bjorn Helgaas
2020-02-07 16:51 ` Thierry Reding
2020-02-07 18:34 ` Bjorn Helgaas
2020-01-04 21:53 ` kbuild test robot
2020-01-06 8:27 ` [PATCH V2] " Vidya Sagar
2020-01-10 19:14 ` [PATCH V3 0/2] " Vidya Sagar
2020-01-10 19:14 ` [PATCH V3 1/2] arm64: tegra: Re-order PCIe aperture mappings to support ACPI boot Vidya Sagar
2020-06-29 13:31 ` Jon Hunter
2020-06-30 10:52 ` Vidya Sagar
2020-01-10 19:15 ` [PATCH V3 2/2] PCI: Add MCFG quirks for Tegra194 host controllers Vidya Sagar
2020-01-17 11:42 ` Thierry Reding
2021-03-05 21:57 ` Bjorn Helgaas
2021-03-05 23:04 ` Krzysztof Wilczyński [this message]
2021-04-16 13:45 ` Vidya Sagar
2021-04-16 13:45 ` [PATCH V4] " Vidya Sagar
2021-04-16 19:06 ` Bjorn Helgaas
2021-05-13 9:40 ` [PATCH V3 2/2] " Qu Wenruo
2021-05-13 13:05 ` Vidya Sagar
2020-01-16 17:18 ` [PATCH V3 0/2] " Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEK5EW1ZBDOKZE5E@rocinante \
--to=kw@linux.com \
--cc=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=sagar.tv@gmail.com \
--cc=treding@nvidia.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).