linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [pci:pci/misc 7/7] include/linux/pci.h:1725:54: error: parameter name omitted
@ 2021-08-21  2:44 kernel test robot
  2021-08-23  7:35 ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2021-08-21  2:44 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: kbuild-all, linux-pci, Bjorn Helgaas

[-- Attachment #1: Type: text/plain, Size: 3717 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/misc
head:   81e2ce35df9102989cefe180f41d78dd7fb8c9b9
commit: 81e2ce35df9102989cefe180f41d78dd7fb8c9b9 [7/7] PCI: Sync __pci_register_driver() stub for CONFIG_PCI=n
config: i386-tinyconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?id=81e2ce35df9102989cefe180f41d78dd7fb8c9b9
        git remote add pci https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
        git fetch --no-tags pci pci/misc
        git checkout 81e2ce35df9102989cefe180f41d78dd7fb8c9b9
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kernel/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/x86/kernel/setup.c:18:
   include/linux/pci.h: In function '__pci_register_driver':
>> include/linux/pci.h:1725:54: error: parameter name omitted
    1725 | static inline int __must_check __pci_register_driver(struct pci_driver *,
         |                                                      ^~~~~~~~~~~~~~~~~~~
   include/linux/pci.h:1726:12: error: parameter name omitted
    1726 |            struct module *,
         |            ^~~~~~~~~~~~~~~
--
   In file included from arch/x86/kernel/cpu/cacheinfo.c:17:
   include/linux/pci.h: In function '__pci_register_driver':
>> include/linux/pci.h:1725:54: error: parameter name omitted
    1725 | static inline int __must_check __pci_register_driver(struct pci_driver *,
         |                                                      ^~~~~~~~~~~~~~~~~~~
   include/linux/pci.h:1726:12: error: parameter name omitted
    1726 |            struct module *,
         |            ^~~~~~~~~~~~~~~
   arch/x86/kernel/cpu/cacheinfo.c: In function 'init_intel_cacheinfo':
   arch/x86/kernel/cpu/cacheinfo.c:727:26: warning: variable 'l3_id' set but not used [-Wunused-but-set-variable]
     727 |  unsigned int l2_id = 0, l3_id = 0, num_threads_sharing, index_msb;
         |                          ^~~~~
   arch/x86/kernel/cpu/cacheinfo.c:727:15: warning: variable 'l2_id' set but not used [-Wunused-but-set-variable]
     727 |  unsigned int l2_id = 0, l3_id = 0, num_threads_sharing, index_msb;
         |               ^~~~~


vim +1725 include/linux/pci.h

  1718	
  1719	static inline void pci_set_master(struct pci_dev *dev) { }
  1720	static inline int pci_enable_device(struct pci_dev *dev) { return -EIO; }
  1721	static inline void pci_disable_device(struct pci_dev *dev) { }
  1722	static inline int pcim_enable_device(struct pci_dev *pdev) { return -EIO; }
  1723	static inline int pci_assign_resource(struct pci_dev *dev, int i)
  1724	{ return -EBUSY; }
> 1725	static inline int __must_check __pci_register_driver(struct pci_driver *,
  1726							     struct module *,
  1727							     const char *mod_name)
  1728	{ return 0; }
  1729	static inline int pci_register_driver(struct pci_driver *drv)
  1730	{ return 0; }
  1731	static inline void pci_unregister_driver(struct pci_driver *drv) { }
  1732	static inline u8 pci_find_capability(struct pci_dev *dev, int cap)
  1733	{ return 0; }
  1734	static inline int pci_find_next_capability(struct pci_dev *dev, u8 post,
  1735						   int cap)
  1736	{ return 0; }
  1737	static inline int pci_find_ext_capability(struct pci_dev *dev, int cap)
  1738	{ return 0; }
  1739	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 7442 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pci:pci/misc 7/7] include/linux/pci.h:1725:54: error: parameter name omitted
  2021-08-21  2:44 [pci:pci/misc 7/7] include/linux/pci.h:1725:54: error: parameter name omitted kernel test robot
@ 2021-08-23  7:35 ` Andy Shevchenko
  2021-08-23  7:47   ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2021-08-23  7:35 UTC (permalink / raw)
  To: kernel test robot; +Cc: kbuild-all, linux-pci, Bjorn Helgaas

On Sat, Aug 21, 2021 at 10:44:06AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/misc
> head:   81e2ce35df9102989cefe180f41d78dd7fb8c9b9
> commit: 81e2ce35df9102989cefe180f41d78dd7fb8c9b9 [7/7] PCI: Sync __pci_register_driver() stub for CONFIG_PCI=n
> config: i386-tinyconfig (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
>         # https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?id=81e2ce35df9102989cefe180f41d78dd7fb8c9b9
>         git remote add pci https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
>         git fetch --no-tags pci pci/misc
>         git checkout 81e2ce35df9102989cefe180f41d78dd7fb8c9b9
>         # save the attached .config to linux build tree
>         mkdir build_dir
>         make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kernel/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>

For the record, I copied a prototype from the other one.
If we need to fix, we need to fix them both.

I'll cook the patch.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pci:pci/misc 7/7] include/linux/pci.h:1725:54: error: parameter name omitted
  2021-08-23  7:35 ` Andy Shevchenko
@ 2021-08-23  7:47   ` Andy Shevchenko
  0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-08-23  7:47 UTC (permalink / raw)
  To: kernel test robot; +Cc: kbuild-all, linux-pci, Bjorn Helgaas

On Mon, Aug 23, 2021 at 10:35:16AM +0300, Andy Shevchenko wrote:
> On Sat, Aug 21, 2021 at 10:44:06AM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/misc
> > head:   81e2ce35df9102989cefe180f41d78dd7fb8c9b9
> > commit: 81e2ce35df9102989cefe180f41d78dd7fb8c9b9 [7/7] PCI: Sync __pci_register_driver() stub for CONFIG_PCI=n
> > config: i386-tinyconfig (attached as .config)
> > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> > reproduce (this is a W=1 build):
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?id=81e2ce35df9102989cefe180f41d78dd7fb8c9b9
> >         git remote add pci https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
> >         git fetch --no-tags pci pci/misc
> >         git checkout 81e2ce35df9102989cefe180f41d78dd7fb8c9b9
> >         # save the attached .config to linux build tree
> >         mkdir build_dir
> >         make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kernel/
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> 
> For the record, I copied a prototype from the other one.
> If we need to fix, we need to fix them both.
> 
> I'll cook the patch.

Seem Bjorn fixed this inline, thanks!

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-23  7:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-21  2:44 [pci:pci/misc 7/7] include/linux/pci.h:1725:54: error: parameter name omitted kernel test robot
2021-08-23  7:35 ` Andy Shevchenko
2021-08-23  7:47   ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).