* [PATCH] dt-bindings: PCI: mediatek-gen3: Add support for MT8195
@ 2021-08-20 2:35 Jianjun Wang
2021-08-24 14:39 ` Rob Herring
2021-08-24 14:40 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Jianjun Wang @ 2021-08-20 2:35 UTC (permalink / raw)
To: Rob Herring, Bjorn Helgaas, Matthias Brugger, Ryder Lee
Cc: linux-pci, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Jianjun Wang, Rex-BC.Chen, TingHan.Shen
MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192.
Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
---
Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
index 742206dbd965..dcebb1036207 100644
--- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
+++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
@@ -48,7 +48,9 @@ allOf:
properties:
compatible:
- const: mediatek,mt8192-pcie
+ oneOf:
+ - const: mediatek,mt8192-pcie
+ - const: mediatek,mt8195-pcie
reg:
maxItems: 1
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: PCI: mediatek-gen3: Add support for MT8195
2021-08-20 2:35 [PATCH] dt-bindings: PCI: mediatek-gen3: Add support for MT8195 Jianjun Wang
@ 2021-08-24 14:39 ` Rob Herring
2021-08-24 14:40 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-08-24 14:39 UTC (permalink / raw)
To: Jianjun Wang
Cc: Bjorn Helgaas, Matthias Brugger, Ryder Lee, linux-pci,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Rex-BC.Chen, TingHan.Shen
On Fri, Aug 20, 2021 at 10:35:21AM +0800, Jianjun Wang wrote:
> MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192.
>
> Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> ---
> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index 742206dbd965..dcebb1036207 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -48,7 +48,9 @@ allOf:
>
> properties:
> compatible:
> - const: mediatek,mt8192-pcie
> + oneOf:
> + - const: mediatek,mt8192-pcie
> + - const: mediatek,mt8195-pcie
Use 'enum' instead of oneOf+const.
>
> reg:
> maxItems: 1
> --
> 2.18.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: PCI: mediatek-gen3: Add support for MT8195
2021-08-20 2:35 [PATCH] dt-bindings: PCI: mediatek-gen3: Add support for MT8195 Jianjun Wang
2021-08-24 14:39 ` Rob Herring
@ 2021-08-24 14:40 ` Rob Herring
2021-08-25 5:23 ` Jianjun Wang (王建军)
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2021-08-24 14:40 UTC (permalink / raw)
To: Jianjun Wang
Cc: Bjorn Helgaas, Matthias Brugger, Ryder Lee, linux-pci,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Rex-BC.Chen, TingHan.Shen
On Fri, Aug 20, 2021 at 10:35:21AM +0800, Jianjun Wang wrote:
> MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192.
If it is the same, then 8192 should be a fallback compatible. 'The same'
means the current driver for 8192 will work unchanged.
>
> Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> ---
> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index 742206dbd965..dcebb1036207 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -48,7 +48,9 @@ allOf:
>
> properties:
> compatible:
> - const: mediatek,mt8192-pcie
> + oneOf:
> + - const: mediatek,mt8192-pcie
> + - const: mediatek,mt8195-pcie
>
> reg:
> maxItems: 1
> --
> 2.18.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: PCI: mediatek-gen3: Add support for MT8195
2021-08-24 14:40 ` Rob Herring
@ 2021-08-25 5:23 ` Jianjun Wang (王建军)
0 siblings, 0 replies; 4+ messages in thread
From: Jianjun Wang (王建军) @ 2021-08-25 5:23 UTC (permalink / raw)
To: robh
Cc: linux-mediatek, linux-kernel, devicetree, linux-arm-kernel,
matthias.bgg, linux-pci, bhelgaas,
Ryder Lee (李庚諺),
TingHan Shen (沈廷翰),
Rex-BC Chen (陳柏辰)
On Tue, 2021-08-24 at 09:40 -0500, Rob Herring wrote:
> On Fri, Aug 20, 2021 at 10:35:21AM +0800, Jianjun Wang wrote:
> > MT8195 is an ARM platform SoC which has the same PCIe IP with
> > MT8192.
>
> If it is the same, then 8192 should be a fallback compatible. 'The
> same'
> means the current driver for 8192 will work unchanged.
Hi Rob,
Thanks for your review.
Yes, the controller driver works fine in the MT8195 platform without
any change, and we would like to use the compatible string in device
tree as follows:
"mediatek,mt8195-pcie", "mediatek,mt8192-pcie"
Thanks.
>
> >
> > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4
> > +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml
> > index 742206dbd965..dcebb1036207 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > @@ -48,7 +48,9 @@ allOf:
> >
> > properties:
> > compatible:
> > - const: mediatek,mt8192-pcie
> > + oneOf:
> > + - const: mediatek,mt8192-pcie
> > + - const: mediatek,mt8195-pcie
> >
> > reg:
> > maxItems: 1
> > --
> > 2.18.0
> >
> >
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-25 5:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20 2:35 [PATCH] dt-bindings: PCI: mediatek-gen3: Add support for MT8195 Jianjun Wang
2021-08-24 14:39 ` Rob Herring
2021-08-24 14:40 ` Rob Herring
2021-08-25 5:23 ` Jianjun Wang (王建军)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).