linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] PCI: dwc: Use devm_ioremap_resource instead of devm_ioremap_resource
@ 2018-05-14 15:16 Gustavo Pimentel
  2018-05-14 15:16 ` [PATCH 1/2] PCI: dwc: artpec6: " Gustavo Pimentel
  2018-05-14 15:16 ` [PATCH 2/2] PCI: dwc: dra7xx: " Gustavo Pimentel
  0 siblings, 2 replies; 4+ messages in thread
From: Gustavo Pimentel @ 2018-05-14 15:16 UTC (permalink / raw)
  To: bhelgaas, lorenzo.pieralisi, kishon, jesper.nilsson
  Cc: linux-pci, Gustavo Pimentel

This fix aims to replace the use of devm_ioremap() by
devm_ioremap_resource() already discussed on [1].

[1] -> https://lkml.kernel.org/r/20180120001645.GA21343@lenoch

Gustavo Pimentel (2):
  PCI: dwc: artpec6: Use devm_ioremap_resource instead of
    devm_ioremap_resource
  PCI: dwc: dra7xx: Use devm_ioremap_resource instead of
    devm_ioremap_resource

 drivers/pci/dwc/pci-dra7xx.c   | 18 +++++++++---------
 drivers/pci/dwc/pcie-artpec6.c |  6 +++---
 2 files changed, 12 insertions(+), 12 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] PCI: dwc: artpec6: Use devm_ioremap_resource instead of devm_ioremap_resource
  2018-05-14 15:16 [PATCH 0/2] PCI: dwc: Use devm_ioremap_resource instead of devm_ioremap_resource Gustavo Pimentel
@ 2018-05-14 15:16 ` Gustavo Pimentel
  2018-05-14 15:16 ` [PATCH 2/2] PCI: dwc: dra7xx: " Gustavo Pimentel
  1 sibling, 0 replies; 4+ messages in thread
From: Gustavo Pimentel @ 2018-05-14 15:16 UTC (permalink / raw)
  To: bhelgaas, lorenzo.pieralisi, kishon, jesper.nilsson
  Cc: linux-pci, Gustavo Pimentel

This fix aims to replace the use of devm_ioremap() by
devm_ioremap_resource() already discussed on [1].

[1] -> https://lkml.kernel.org/r/20180120001645.GA21343@lenoch

Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
 drivers/pci/dwc/pcie-artpec6.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c
index e66cede..321b56c 100644
--- a/drivers/pci/dwc/pcie-artpec6.c
+++ b/drivers/pci/dwc/pcie-artpec6.c
@@ -463,9 +463,9 @@ static int artpec6_add_pcie_ep(struct artpec6_pcie *artpec6_pcie,
 	ep->ops = &pcie_ep_ops;
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi2");
-	pci->dbi_base2 = devm_ioremap(dev, res->start, resource_size(res));
-	if (!pci->dbi_base2)
-		return -ENOMEM;
+	pci->dbi_base2 = devm_ioremap_resource(dev, res);
+	if (IS_ERR(pci->dbi_base2))
+		return PTR_ERR(pci->dbi_base2);
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space");
 	if (!res)
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] PCI: dwc: dra7xx: Use devm_ioremap_resource instead of devm_ioremap_resource
  2018-05-14 15:16 [PATCH 0/2] PCI: dwc: Use devm_ioremap_resource instead of devm_ioremap_resource Gustavo Pimentel
  2018-05-14 15:16 ` [PATCH 1/2] PCI: dwc: artpec6: " Gustavo Pimentel
@ 2018-05-14 15:16 ` Gustavo Pimentel
  2018-05-14 17:19   ` Fabio Estevam
  1 sibling, 1 reply; 4+ messages in thread
From: Gustavo Pimentel @ 2018-05-14 15:16 UTC (permalink / raw)
  To: bhelgaas, lorenzo.pieralisi, kishon, jesper.nilsson
  Cc: linux-pci, Gustavo Pimentel

This fix aims to replace the use of devm_ioremap() by
devm_ioremap_resource() already discussed on [1].

[1] -> https://lkml.kernel.org/r/20180120001645.GA21343@lenoch

Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/pci/dwc/pci-dra7xx.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
index ed8558d..b410bb4 100644
--- a/drivers/pci/dwc/pci-dra7xx.c
+++ b/drivers/pci/dwc/pci-dra7xx.c
@@ -406,14 +406,14 @@ static int __init dra7xx_add_pcie_ep(struct dra7xx_pcie *dra7xx,
 	ep->ops = &pcie_ep_ops;
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ep_dbics");
-	pci->dbi_base = devm_ioremap(dev, res->start, resource_size(res));
-	if (!pci->dbi_base)
-		return -ENOMEM;
+	pci->dbi_base = devm_ioremap_resource(dev, res);
+	if (IS_ERR(pci->dbi_base))
+		return PTR_ERR(pci->dbi_base);
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ep_dbics2");
-	pci->dbi_base2 = devm_ioremap(dev, res->start, resource_size(res));
-	if (!pci->dbi_base2)
-		return -ENOMEM;
+	pci->dbi_base2 = devm_ioremap_resource(dev, res);
+	if (IS_ERR(pci->dbi_base2))
+		return PTR_ERR(pci->dbi_base2);
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space");
 	if (!res)
@@ -459,9 +459,9 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
 		return ret;
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rc_dbics");
-	pci->dbi_base = devm_ioremap(dev, res->start, resource_size(res));
-	if (!pci->dbi_base)
-		return -ENOMEM;
+	pci->dbi_base = devm_ioremap_resource(dev, res);
+	if (IS_ERR(pci->dbi_base))
+		return PTR_ERR(pci->dbi_base);
 
 	pp->ops = &dra7xx_pcie_host_ops;
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] PCI: dwc: dra7xx: Use devm_ioremap_resource instead of devm_ioremap_resource
  2018-05-14 15:16 ` [PATCH 2/2] PCI: dwc: dra7xx: " Gustavo Pimentel
@ 2018-05-14 17:19   ` Fabio Estevam
  0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2018-05-14 17:19 UTC (permalink / raw)
  To: Gustavo Pimentel
  Cc: Bjorn Helgaas, Lorenzo Pieralisi, Kishon Vijay Abraham I,
	Jesper Nilsson, linux-pci

Hi Gustavo,

On Mon, May 14, 2018 at 12:16 PM, Gustavo Pimentel
<gustavo.pimentel@synopsys.com> wrote:
> This fix aims to replace the use of devm_ioremap() by
> devm_ioremap_resource() already discussed on [1].

There is a typo in the Subject and it should be:

PCI: dwc: dra7xx: Use devm_ioremap_resource instead of devm_ioremap

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-05-14 17:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-14 15:16 [PATCH 0/2] PCI: dwc: Use devm_ioremap_resource instead of devm_ioremap_resource Gustavo Pimentel
2018-05-14 15:16 ` [PATCH 1/2] PCI: dwc: artpec6: " Gustavo Pimentel
2018-05-14 15:16 ` [PATCH 2/2] PCI: dwc: dra7xx: " Gustavo Pimentel
2018-05-14 17:19   ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).