From: Thomas Gleixner <tglx@linutronix.de>
To: Dou Liyang <douliyangs@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
kashyap.desai@broadcom.com,
shivasharan.srikanteshwara@broadcom.com,
sumit.saxena@broadcom.com, ming.lei@redhat.com, hch@lst.de,
bhelgaas@google.com, douliyang1@huawei.com
Subject: Re: [PATCH 2/3] irq/affinity: Add is_managed into struct irq_affinity_desc
Date: Tue, 18 Dec 2018 16:26:01 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1812181545340.14031@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20181204155122.6327-3-douliyangs@gmail.com>
On Tue, 4 Dec 2018, Dou Liyang wrote:
> diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c
> index 1562a36e7c0f..d122575ba1b4 100644
> --- a/kernel/irq/affinity.c
> +++ b/kernel/irq/affinity.c
> @@ -289,6 +289,13 @@ irq_create_affinity_masks(int nvecs, const struct irq_affinity *affd)
> for (; curvec < nvecs; curvec++)
> cpumask_copy(&masks[curvec].mask, irq_default_affinity);
>
> + /* Setup complementary information */
> + for (i = 0; i < nvecs; i++) {
> + if (i >= affd->pre_vectors && i < nvecs - affd->post_vectors)
> + masks[i].is_managed = 1;
> + else
> + masks[i].is_managed = 0;
Why want you clear the bit? The masks are allocated with kcalloc() so it's
clear already.
+ /* Mark the managed interrupts */
+ for (i = affd->pre_vectors; i < nvecs - affd->post_vectors; i++)
+ masks[i].is_managed = 1;
+
Is what I made it instead.
Thanks,
tglx
next prev parent reply other threads:[~2018-12-18 15:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 15:51 [PATCH 0/3] irq/core: Fix and expand the irq affinity descriptor Dou Liyang
2018-12-04 15:51 ` [PATCH 1/3] genirq/core: Add a new interrupt " Dou Liyang
2018-12-04 15:51 ` [PATCH 2/3] irq/affinity: Add is_managed into struct irq_affinity_desc Dou Liyang
2018-12-18 15:26 ` Thomas Gleixner [this message]
2018-12-04 15:51 ` [PATCH 3/3] irq/affinity: Fix a possible breakage Dou Liyang
2018-12-05 8:28 ` Thomas Gleixner
2018-12-11 16:27 ` Dou Liyang
2018-12-19 10:53 ` [PATCH 0/3] irq/core: Fix and expand the irq affinity descriptor Thomas Gleixner
2018-12-19 12:55 ` Sumit Saxena
2018-12-28 9:54 ` Sumit Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1812181545340.14031@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=bhelgaas@google.com \
--cc=douliyang1@huawei.com \
--cc=douliyangs@gmail.com \
--cc=hch@lst.de \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).