* Re: [PATCH v3 1/2] PCI: vmd: Assign VMD IRQ domain before enumeration
[not found] <20220405171005.45586-1-nirmal.patel@linux.intel.com>
@ 2022-04-28 2:21 ` Patel, Nirmal
2022-04-28 8:40 ` Lorenzo Pieralisi
0 siblings, 1 reply; 2+ messages in thread
From: Patel, Nirmal @ 2022-04-28 2:21 UTC (permalink / raw)
To: Lorenzo Pieralisi; +Cc: Dan Williams, linux-pci
On 4/5/2022 10:10 AM, Nirmal Patel wrote:
> VMD creates and assigns a separate IRQ domain only when MSI remapping is
> enabled. For example VMD-MSI. But VMD doesn't assign IRQ domain when
> MSI remapping is disabled resulting child devices getting default
> PCI-MSI IRQ domain. Now when interrupt remapping is enabled by
> intel-iommu all the PCI devices are assigned INTEL-IR-MSI domain
> including VMD endpoints. But devices behind VMD get PCI-MSI IRQ domain
> when VMD create a root bus and configures child devices.
>
> As a result DMAR errors were observed when interrupt remapping was
> enabled on Intel Icelake CPUs. For instance:
>
> DMAR: DRHD: handling fault status reg 2
> DMAR: [INTR-REMAP] Request device [0xe2:0x00.0] fault index 0xa00 [fault reason 0x25] Blocked a compatibility format interrupt request
>
> Acked-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Nirmal Patel <nirmal.patel@linux.intel.com>
> ---
> v2->v3: Update commit log.
> v1->v2: Split patch into two separate patches. One applies the fix and
> other reverts the commit 2565e5b69c44 which was added as a
> workaround.
> ---
> drivers/pci/controller/vmd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
> index cc166c683638..3a6570e5b765 100644
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -853,6 +853,8 @@ static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features)
> vmd_attach_resources(vmd);
> if (vmd->irq_domain)
> dev_set_msi_domain(&vmd->bus->dev, vmd->irq_domain);
> + else
> + dev_set_msi_domain(&vmd->bus->dev, dev_get_msi_domain(&vmd->dev->dev));
>
> vmd_acpi_begin();
>
Gentle reminder.
Thanks
nirmal
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3 1/2] PCI: vmd: Assign VMD IRQ domain before enumeration
2022-04-28 2:21 ` [PATCH v3 1/2] PCI: vmd: Assign VMD IRQ domain before enumeration Patel, Nirmal
@ 2022-04-28 8:40 ` Lorenzo Pieralisi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2022-04-28 8:40 UTC (permalink / raw)
To: Patel, Nirmal; +Cc: Dan Williams, linux-pci
On Wed, Apr 27, 2022 at 07:21:08PM -0700, Patel, Nirmal wrote:
> On 4/5/2022 10:10 AM, Nirmal Patel wrote:
> > VMD creates and assigns a separate IRQ domain only when MSI remapping is
> > enabled. For example VMD-MSI. But VMD doesn't assign IRQ domain when
> > MSI remapping is disabled resulting child devices getting default
> > PCI-MSI IRQ domain. Now when interrupt remapping is enabled by
> > intel-iommu all the PCI devices are assigned INTEL-IR-MSI domain
> > including VMD endpoints. But devices behind VMD get PCI-MSI IRQ domain
> > when VMD create a root bus and configures child devices.
> >
> > As a result DMAR errors were observed when interrupt remapping was
> > enabled on Intel Icelake CPUs. For instance:
> >
> > DMAR: DRHD: handling fault status reg 2
> > DMAR: [INTR-REMAP] Request device [0xe2:0x00.0] fault index 0xa00 [fault reason 0x25] Blocked a compatibility format interrupt request
> >
> > Acked-by: Dan Williams <dan.j.williams@intel.com>
> > Signed-off-by: Nirmal Patel <nirmal.patel@linux.intel.com>
> > ---
> > v2->v3: Update commit log.
> > v1->v2: Split patch into two separate patches. One applies the fix and
> > other reverts the commit 2565e5b69c44 which was added as a
> > workaround.
> > ---
> > drivers/pci/controller/vmd.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
> > index cc166c683638..3a6570e5b765 100644
> > --- a/drivers/pci/controller/vmd.c
> > +++ b/drivers/pci/controller/vmd.c
> > @@ -853,6 +853,8 @@ static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features)
> > vmd_attach_resources(vmd);
> > if (vmd->irq_domain)
> > dev_set_msi_domain(&vmd->bus->dev, vmd->irq_domain);
> > + else
> > + dev_set_msi_domain(&vmd->bus->dev, dev_get_msi_domain(&vmd->dev->dev));
> >
> > vmd_acpi_begin();
> >
>
> Gentle reminder.
Instead of sending these reminders, could you please, as Bjorn
requested, fix your patch posting flow to make sure your patches are
logged in lore and patchwork/linux-pci, where I look for patches to
review please ?
There is no point in sending reminders for something I don't see,
I have no idea you are waiting for me to review this series if it
does not show up in patchwork/linux-pci, if it is not there for
me it does not exist.
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-28 8:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220405171005.45586-1-nirmal.patel@linux.intel.com>
2022-04-28 2:21 ` [PATCH v3 1/2] PCI: vmd: Assign VMD IRQ domain before enumeration Patel, Nirmal
2022-04-28 8:40 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).