From: Kishon Vijay Abraham I <kishon@ti.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: linux-kernel@vger.kernel.org, "Tom Joseph" <tjoseph@cadence.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: cadence: respond to received PTM Requests
Date: Fri, 18 Feb 2022 16:26:48 +0530 [thread overview]
Message-ID: <bac4cc7e-f81e-82e6-9b60-e5e3199637d7@ti.com> (raw)
In-Reply-To: <20220131220518.GA515079@bhelgaas>
Hi Bjorn,
On 01/02/22 3:35 am, Bjorn Helgaas wrote:
> Update subject line to match previous conventions ("git log --oneline
> drivers/pci/controller/cadence/pcie-cadence-host.c" to see).
>
> On Mon, Jan 31, 2022 at 01:08:27PM +0100, Christian Gmeiner wrote:
>> This enables the Controller [RP] to automatically respond
>> with Response/ResponseD messages.
>
> Update to imperative mood, e.g., "Enable Controller to ...":
>
> https://chris.beams.io/posts/git-commit/
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-tip.rst?id=v5.16#n134
>
>> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
>> ---
>> drivers/pci/controller/cadence/pcie-cadence-host.c | 10 ++++++++++
>> drivers/pci/controller/cadence/pcie-cadence.h | 4 ++++
>> 2 files changed, 14 insertions(+)
>>
>> diff --git a/drivers/pci/controller/cadence/pcie-cadence-host.c b/drivers/pci/controller/cadence/pcie-cadence-host.c
>> index fb96d37a135c..940c7dd701d6 100644
>> --- a/drivers/pci/controller/cadence/pcie-cadence-host.c
>> +++ b/drivers/pci/controller/cadence/pcie-cadence-host.c
>> @@ -123,6 +123,14 @@ static int cdns_pcie_retrain(struct cdns_pcie *pcie)
>> return ret;
>> }
>>
>> +static void cdns_pcie_host_enable_ptm_response(struct cdns_pcie *pcie)
>> +{
>> + u32 val;
>> +
>> + val = cdns_pcie_readl(pcie, CDNS_PCIE_LM_PTM_CTRL);
>> + cdns_pcie_writel(pcie, CDNS_PCIE_LM_PTM_CTRL, val | CDNS_PCIE_LM_TPM_CTRL_PTMRSEN);
>
> I assume this is some device-specific enable bit that is effectively
> ANDed with PCI_PTM_CTRL_ENABLE in the Precision Time Measurement
> Capability?
That's correct. This bit enables Controller [RP] to respond to the received PTM
Requests.
Thanks,
Kishon
>
>> +}
>> +
>> static int cdns_pcie_host_start_link(struct cdns_pcie_rc *rc)
>> {
>> struct cdns_pcie *pcie = &rc->pcie;
>> @@ -501,6 +509,8 @@ int cdns_pcie_host_setup(struct cdns_pcie_rc *rc)
>> if (rc->quirk_detect_quiet_flag)
>> cdns_pcie_detect_quiet_min_delay_set(&rc->pcie);
>>
>> + cdns_pcie_host_enable_ptm_response(pcie);
>> +
>> ret = cdns_pcie_start_link(pcie);
>> if (ret) {
>> dev_err(dev, "Failed to start link\n");
>> diff --git a/drivers/pci/controller/cadence/pcie-cadence.h b/drivers/pci/controller/cadence/pcie-cadence.h
>> index c8a27b6290ce..9510ea513b8a 100644
>> --- a/drivers/pci/controller/cadence/pcie-cadence.h
>> +++ b/drivers/pci/controller/cadence/pcie-cadence.h
>> @@ -116,6 +116,10 @@
>> #define LM_RC_BAR_CFG_APERTURE(bar, aperture) \
>> (((aperture) - 2) << ((bar) * 8))
>>
>> +/* PTM Control Register */
>> +#define CDNS_PCIE_LM_PTM_CTRL (CDNS_PCIE_LM_BASE + 0x0DA8)
>> +#define CDNS_PCIE_LM_TPM_CTRL_PTMRSEN BIT(17)
>> +
>> /*
>> * Endpoint Function Registers (PCI configuration space for endpoint functions)
>> */
>> --
>> 2.34.1
>>
next prev parent reply other threads:[~2022-02-18 10:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 12:08 [PATCH] PCI: cadence: respond to received PTM Requests Christian Gmeiner
2022-01-31 22:05 ` Bjorn Helgaas
2022-02-04 14:45 ` Christian Gmeiner
2022-02-18 10:56 ` Kishon Vijay Abraham I [this message]
2022-02-18 13:13 ` Christian Gmeiner
2022-02-18 13:20 ` Bjorn Helgaas
2022-02-18 13:42 ` Christian Gmeiner
2022-02-22 14:10 ` Kishon Vijay Abraham I
2022-04-29 10:56 ` Lorenzo Pieralisi
2022-04-29 19:28 ` Bjorn Helgaas
2022-05-05 14:43 ` Dominic Rath
2022-05-05 14:48 ` Christian Gmeiner
2022-05-11 12:37 ` Lorenzo Pieralisi
2022-05-12 6:00 ` Christian Gmeiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bac4cc7e-f81e-82e6-9b60-e5e3199637d7@ti.com \
--to=kishon@ti.com \
--cc=bhelgaas@google.com \
--cc=christian.gmeiner@gmail.com \
--cc=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=tjoseph@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).