* Re: linux-next: Tree for Nov 30 (drivers/pci/controller/dwc/pcie-designware-host.c)
[not found] <20201130193626.1c408e47@canb.auug.org.au>
@ 2020-12-01 4:44 ` Randy Dunlap
2020-12-01 11:34 ` Lorenzo Pieralisi
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2020-12-01 4:44 UTC (permalink / raw)
To: Stephen Rothwell, Linux Next Mailing List
Cc: Linux Kernel Mailing List, Jaehoon Chung, linux-pci,
Bjorn Helgaas, Marek Szyprowski, Lorenzo Pieralisi
On 11/30/20 12:36 AM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20201127:
>
on x86_64:
WARNING: unmet direct dependencies detected for PCIE_DW_HOST
Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
Selected by [y]:
- PCI_EXYNOS [=y] && PCI [=y] && (ARCH_EXYNOS || COMPILE_TEST [=y])
../drivers/pci/controller/dwc/pcie-designware-host.c:49:15: error: variable ‘dw_pcie_msi_domain_info’ has initializer but incomplete type
static struct msi_domain_info dw_pcie_msi_domain_info = {
^~~~~~~~~~~~~~~
../drivers/pci/controller/dwc/pcie-designware-host.c:50:3: error: ‘struct msi_domain_info’ has no member named ‘flags’
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
^~~~~
../drivers/pci/controller/dwc/pcie-designware-host.c:50:12: error: ‘MSI_FLAG_USE_DEF_DOM_OPS’ undeclared here (not in a function); did you mean ‘SIMPLE_DEV_PM_OPS’?
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
^~~~~~~~~~~~~~~~~~~~~~~~
../drivers/pci/controller/dwc/pcie-designware-host.c:50:39: error: ‘MSI_FLAG_USE_DEF_CHIP_OPS’ undeclared here (not in a function); did you mean ‘MSI_FLAG_USE_DEF_DOM_OPS’?
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
^~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/pci/controller/dwc/pcie-designware-host.c:51:6: error: ‘MSI_FLAG_PCI_MSIX’ undeclared here (not in a function); did you mean ‘SS_FLAG_BITS’?
MSI_FLAG_PCI_MSIX | MSI_FLAG_MULTI_PCI_MSI),
^~~~~~~~~~~~~~~~~
../drivers/pci/controller/dwc/pcie-designware-host.c:51:26: error: ‘MSI_FLAG_MULTI_PCI_MSI’ undeclared here (not in a function); did you mean ‘MSI_FLAG_PCI_MSIX’?
MSI_FLAG_PCI_MSIX | MSI_FLAG_MULTI_PCI_MSI),
^~~~~~~~~~~~~~~~~~~~~~
../drivers/pci/controller/dwc/pcie-designware-host.c:50:11: warning: excess elements in struct initializer
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
^
../drivers/pci/controller/dwc/pcie-designware-host.c:52:3: error: ‘struct msi_domain_info’ has no member named ‘chip’
.chip = &dw_pcie_msi_irq_chip,
^~~~
../drivers/pci/controller/dwc/pcie-designware-host.c:52:10: warning: excess elements in struct initializer
.chip = &dw_pcie_msi_irq_chip,
^
../drivers/pci/controller/dwc/pcie-designware-host.c: In function ‘dw_pcie_allocate_domains’:
../drivers/pci/controller/dwc/pcie-designware-host.c:247:19: error: implicit declaration of function ‘pci_msi_create_irq_domain’; did you mean ‘pci_msi_get_device_domain’? [-Werror=implicit-function-declaration]
pp->msi_domain = pci_msi_create_irq_domain(fwnode,
^~~~~~~~~~~~~~~~~~~~~~~~~
pci_msi_get_device_domain
../drivers/pci/controller/dwc/pcie-designware-host.c:247:17: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
pp->msi_domain = pci_msi_create_irq_domain(fwnode,
^
../drivers/pci/controller/dwc/pcie-designware-host.c: At top level:
../drivers/pci/controller/dwc/pcie-designware-host.c:49:31: error: storage size of ‘dw_pcie_msi_domain_info’ isn’t known
static struct msi_domain_info dw_pcie_msi_domain_info = {
caused by:
commit f0a6743028f938cdd34e0c3249d3f0e6bfa04073
Author: Jaehoon Chung <jh80.chung@samsung.com>
Date: Fri Nov 13 18:01:39 2020 +0100
PCI: dwc: exynos: Rework the driver to support Exynos5433 varian
which removed "depends on PCI_MSI_IRQ_DOMAIN from config PCI_EXYNOS.
--
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for Nov 30 (drivers/pci/controller/dwc/pcie-designware-host.c)
2020-12-01 4:44 ` linux-next: Tree for Nov 30 (drivers/pci/controller/dwc/pcie-designware-host.c) Randy Dunlap
@ 2020-12-01 11:34 ` Lorenzo Pieralisi
2020-12-01 13:27 ` Marek Szyprowski
0 siblings, 1 reply; 3+ messages in thread
From: Lorenzo Pieralisi @ 2020-12-01 11:34 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, Jaehoon Chung, linux-pci,
Bjorn Helgaas, Marek Szyprowski
On Mon, Nov 30, 2020 at 08:44:55PM -0800, Randy Dunlap wrote:
> On 11/30/20 12:36 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20201127:
> >
>
> on x86_64:
>
> WARNING: unmet direct dependencies detected for PCIE_DW_HOST
> Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
> Selected by [y]:
> - PCI_EXYNOS [=y] && PCI [=y] && (ARCH_EXYNOS || COMPILE_TEST [=y])
[...]
> caused by:
> commit f0a6743028f938cdd34e0c3249d3f0e6bfa04073
> Author: Jaehoon Chung <jh80.chung@samsung.com>
> Date: Fri Nov 13 18:01:39 2020 +0100
>
> PCI: dwc: exynos: Rework the driver to support Exynos5433 varian
>
>
> which removed "depends on PCI_MSI_IRQ_DOMAIN from config PCI_EXYNOS.
Fixed up and squashed in the original commit - we should probably rework
the DWC driver dependencies on PCI_MSI_IRQ_DOMAIN to really fix it, for
the time being this should do.
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for Nov 30 (drivers/pci/controller/dwc/pcie-designware-host.c)
2020-12-01 11:34 ` Lorenzo Pieralisi
@ 2020-12-01 13:27 ` Marek Szyprowski
0 siblings, 0 replies; 3+ messages in thread
From: Marek Szyprowski @ 2020-12-01 13:27 UTC (permalink / raw)
To: Lorenzo Pieralisi, Randy Dunlap
Cc: Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, Jaehoon Chung, linux-pci,
Bjorn Helgaas
Hi
On 01.12.2020 12:34, Lorenzo Pieralisi wrote:
> On Mon, Nov 30, 2020 at 08:44:55PM -0800, Randy Dunlap wrote:
>> On 11/30/20 12:36 AM, Stephen Rothwell wrote:
>>> Changes since 20201127:
>> on x86_64:
>>
>> WARNING: unmet direct dependencies detected for PCIE_DW_HOST
>> Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
>> Selected by [y]:
>> - PCI_EXYNOS [=y] && PCI [=y] && (ARCH_EXYNOS || COMPILE_TEST [=y])
>
> [...]
>
>> caused by:
>> commit f0a6743028f938cdd34e0c3249d3f0e6bfa04073
>> Author: Jaehoon Chung <jh80.chung@samsung.com>
>> Date: Fri Nov 13 18:01:39 2020 +0100
>>
>> PCI: dwc: exynos: Rework the driver to support Exynos5433 varian
>>
>>
>> which removed "depends on PCI_MSI_IRQ_DOMAIN from config PCI_EXYNOS.
> Fixed up and squashed in the original commit - we should probably rework
> the DWC driver dependencies on PCI_MSI_IRQ_DOMAIN to really fix it, for
> the time being this should do.
Thanks! I wasn't aware of that hidden dependency.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-01 13:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201130193626.1c408e47@canb.auug.org.au>
2020-12-01 4:44 ` linux-next: Tree for Nov 30 (drivers/pci/controller/dwc/pcie-designware-host.c) Randy Dunlap
2020-12-01 11:34 ` Lorenzo Pieralisi
2020-12-01 13:27 ` Marek Szyprowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).