From: Marek Vasut <marek.vasut@gmail.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Simon Horman <horms@verge.net.au>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-pci <linux-pci@vger.kernel.org>,
Dien Pham <dien.pham.ry@rvc.renesas.com>,
Hien Dang <hien.dang.eb@renesas.com>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Phil Edworthy <phil.edworthy@renesas.com>,
Wolfram Sang <wsa@the-dreams.de>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH V5] PCI: rcar: Use runtime PM to control controller clock
Date: Mon, 14 May 2018 17:32:04 +0200 [thread overview]
Message-ID: <d03db400-9f3e-906f-7886-a54cccb96a40@gmail.com> (raw)
In-Reply-To: <20180501105556.GB19391@e107981-ln.cambridge.arm.com>
On 05/01/2018 12:55 PM, Lorenzo Pieralisi wrote:
> On Fri, Apr 13, 2018 at 02:48:19PM +0200, Simon Horman wrote:
>> On Tue, Apr 10, 2018 at 06:17:04PM +0200, Marek Vasut wrote:
>>> On 04/10/2018 05:28 PM, Geert Uytterhoeven wrote:
>>
>> ...
>>
>>>>>> rcar_pcie_get_resources() is called while the device is
>>>>>> runtime-enabled/resumed,
>>>>>> pci_free_resource_list() is called while the device is runtime-disabled.
>>>
>>> rcar_pcie_get_resources() is NOT a pair function for
>>> pci_free_resource_list() . rcar_pcie_parse_request_of_pci_ranges() is a
>>> pair function for pci_free_resource_list().
>>>
>>> rcar_pcie_parse_request_of_pci_ranges() calls
>>> of_pci_get_host_bridge_resources() internally, so every single function
>>> called after successful call of rcar_pcie_parse_request_of_pci_ranges()
>>> must call pci_free_resource_list().
>>>
>>> Both of_pci_get_host_bridge_resources() and pci_free_resource_list() are
>>> called with runtime PM disabled.
>>>
>>> The naming of the functions is confusing though.
>>
>> Hi,
>>
>> thanks everyone for their efforts in preparing/reviewing this patch.
>>
>> It seems there are some differences of opinion on how best to handle the
>> error paths but unlike earlier versions this one seems correct to me. If
>> that turns out to be false we can address it. But I don't think its likely
>> things will be enhanced by continuing this review.
>>
>> Lorenzo, please consider taking this patch in its current form.
>>
>> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> Applied to pci/rcar for v4.18, thanks.
Is there any reason why this patch isnt in next yet ?
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-05-14 15:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 13:09 [PATCH V5] PCI: rcar: Use runtime PM to control controller clock Marek Vasut
2018-04-09 8:07 ` Geert Uytterhoeven
2018-04-09 8:20 ` Marek Vasut
2018-04-09 11:41 ` Simon Horman
2018-04-09 11:47 ` Geert Uytterhoeven
2018-04-09 12:26 ` Simon Horman
2018-04-10 14:31 ` Marek Vasut
2018-04-10 14:42 ` Geert Uytterhoeven
2018-04-10 15:25 ` Marek Vasut
2018-04-10 15:28 ` Geert Uytterhoeven
2018-04-10 16:17 ` Marek Vasut
2018-04-13 12:48 ` Simon Horman
2018-04-13 17:48 ` Lorenzo Pieralisi
2018-05-01 10:55 ` Lorenzo Pieralisi
2018-05-14 15:32 ` Marek Vasut [this message]
2018-05-14 15:49 ` Lorenzo Pieralisi
2018-05-21 11:08 ` Marek Vasut
2018-05-21 13:03 ` Lorenzo Pieralisi
2018-05-21 13:09 ` Marek Vasut
2018-04-19 10:00 ` Geert Uytterhoeven
2018-05-21 12:57 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d03db400-9f3e-906f-7886-a54cccb96a40@gmail.com \
--to=marek.vasut@gmail.com \
--cc=dien.pham.ry@rvc.renesas.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=hien.dang.eb@renesas.com \
--cc=horms@verge.net.au \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=phil.edworthy@renesas.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).