From: Vidya Sagar <vidyas@nvidia.com>
To: "Serge Semin" <Sergey.Semin@baikalelectronics.ru>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Thierry Reding" <treding@nvidia.com>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
Frank Li <Frank.Li@nxp.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 06/18] PCI: dwc: Enable CDM-check independently from the num_lanes value
Date: Mon, 13 Jun 2022 13:32:11 +0530 [thread overview]
Message-ID: <ded0e4f1-ed94-7518-f190-ed7aff1bc832@nvidia.com> (raw)
In-Reply-To: <20220610082535.12802-7-Sergey.Semin@baikalelectronics.ru>
Thanks for pushing this change.
Reviewed-by: Vidya Sagar <vidyas@nvidia.com>
On 6/10/2022 1:55 PM, Serge Semin wrote:
> External email: Use caution opening links or attachments
>
>
> Currently the embedded CDM IOs consistency check-engine is enabled only if
> the num_lanes field of dw_pcie structure is set to non-zero value. It's
> definitely wrong since the CDM checking has nothing to do with the PCIe
> lanes settings, while that feature will be left disabled for the platforms
> which expect it being enabled and prefer keeping the default lanes setup.
> Let's fix that by enabling the CDM-check feature before the num_lanes
> parameter is handled.
>
> Fixes: 07f123def73e ("PCI: dwc: Add support to enable CDM register check")
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> ---
>
> Changelog v4:
> - This is a new patch created on v4 lap of the series.
> ---
> drivers/pci/controller/dwc/pcie-designware.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index 347251bf87d0..5848cc520b52 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -740,6 +740,13 @@ void dw_pcie_setup(struct dw_pcie *pci)
> val |= PORT_LINK_DLL_LINK_EN;
> dw_pcie_writel_dbi(pci, PCIE_PORT_LINK_CONTROL, val);
>
> + if (of_property_read_bool(np, "snps,enable-cdm-check")) {
> + val = dw_pcie_readl_dbi(pci, PCIE_PL_CHK_REG_CONTROL_STATUS);
> + val |= PCIE_PL_CHK_REG_CHK_REG_CONTINUOUS |
> + PCIE_PL_CHK_REG_CHK_REG_START;
> + dw_pcie_writel_dbi(pci, PCIE_PL_CHK_REG_CONTROL_STATUS, val);
> + }
> +
> of_property_read_u32(np, "num-lanes", &pci->num_lanes);
> if (!pci->num_lanes) {
> dev_dbg(pci->dev, "Using h/w default number of lanes\n");
> @@ -786,11 +793,4 @@ void dw_pcie_setup(struct dw_pcie *pci)
> break;
> }
> dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, val);
> -
> - if (of_property_read_bool(np, "snps,enable-cdm-check")) {
> - val = dw_pcie_readl_dbi(pci, PCIE_PL_CHK_REG_CONTROL_STATUS);
> - val |= PCIE_PL_CHK_REG_CHK_REG_CONTINUOUS |
> - PCIE_PL_CHK_REG_CHK_REG_START;
> - dw_pcie_writel_dbi(pci, PCIE_PL_CHK_REG_CONTROL_STATUS, val);
> - }
> }
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-06-13 8:02 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 8:25 [PATCH v4 00/18] PCI: dwc: Various fixes and cleanups Serge Semin
2022-06-10 8:25 ` [PATCH v4 01/18] PCI: dwc: Stop link in the host init error and de-initialization Serge Semin
2022-06-10 8:25 ` [PATCH v4 02/18] PCI: dwc: Add unroll iATU space support to the regions disable method Serge Semin
2022-06-13 20:00 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 03/18] PCI: dwc: Disable outbound windows for controllers with iATU Serge Semin
2022-06-13 20:03 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 04/18] PCI: dwc: Set INCREASE_REGION_SIZE flag based on limit address Serge Semin
2022-06-13 20:07 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 05/18] PCI: dwc: Deallocate EPC memory on EP init error Serge Semin
2022-06-13 20:09 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 06/18] PCI: dwc: Enable CDM-check independently from the num_lanes value Serge Semin
2022-06-13 8:02 ` Vidya Sagar [this message]
2022-06-13 20:49 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 07/18] PCI: dwc: Add braces to the multi-line if-else statements Serge Semin
2022-06-13 20:10 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 08/18] PCI: dwc: Add trailing new-line literals to the log messages Serge Semin
2022-06-13 20:15 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 09/18] PCI: dwc: Discard IP-core version checking on unrolled iATU detection Serge Semin
2022-06-13 20:20 ` Rob Herring
2022-06-14 20:14 ` Serge Semin
2022-06-10 8:25 ` [PATCH v4 10/18] PCI: dwc: Convert Link-up status method to using dw_pcie_readl_dbi() Serge Semin
2022-06-13 20:22 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 11/18] PCI: dwc: Organize local variables usage Serge Semin
2022-06-13 20:26 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 12/18] PCI: dwc: Re-use local pointer to the resource data Serge Semin
2022-06-13 20:28 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 13/18] PCI: dwc: Add start_link/stop_link inliners Serge Semin
2022-06-13 20:39 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 14/18] PCI: dwc: Move io_cfg_atu_shared to the Root Port descriptor Serge Semin
2022-06-13 20:42 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 15/18] PCI: dwc: Add dw_ prefix to the pcie_port structure name Serge Semin
2022-06-10 14:16 ` Jesper Nilsson
2022-06-10 21:42 ` Serge Semin
2022-06-13 20:48 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 16/18] PCI: dwc-plat: Simplify the probe method return value handling Serge Semin
2022-06-13 20:44 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 17/18] PCI: dwc-plat: Discard unused regmap pointer Serge Semin
2022-06-13 20:45 ` Rob Herring
2022-06-10 8:25 ` [PATCH v4 18/18] PCI: dwc-plat: Drop dw_plat_pcie_of_match forward declaration Serge Semin
2022-06-13 20:45 ` Rob Herring
2022-06-10 8:29 ` [PATCH v4 00/18] PCI: dwc: Various fixes and cleanups Serge Semin
2022-06-16 21:04 ` Manivannan Sadhasivam
2022-06-17 10:42 ` Serge Semin
2022-06-16 20:03 ` Bjorn Helgaas
2022-06-17 10:41 ` Serge Semin
2022-06-17 11:29 ` Bjorn Helgaas
2022-06-17 13:11 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ded0e4f1-ed94-7518-f190-ed7aff1bc832@nvidia.com \
--to=vidyas@nvidia.com \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Frank.Li@nxp.com \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).