* [PATCH v4] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195
@ 2022-08-02 12:06 Jianjun Wang
2022-08-03 6:44 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jianjun Wang @ 2022-08-02 12:06 UTC (permalink / raw)
To: Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski, Matthias Brugger
Cc: linux-pci, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Ryder Lee, Jianjun Wang, Rex-BC.Chen,
TingHan.Shen, Liju-clr.Chen, Jian.Yang
MT8188 and MT8195 are ARM platform SoCs with the same PCIe IP as MT8192.
Also add new clock name "peri_mem" since the MT8188 and MT8195 use clock
"peri_mem" instead of "top_133m".
Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
---
Changes in v4:
Remove "items" for "mediatek,mt8192-pcie" since it only have one item.
Changes in v3:
Use enum property to add the new clock name.
Changes in v2:
Merge two patches into one.
---
.../devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
index 0499b94627ae..c00be39af64e 100644
--- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
+++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
@@ -48,7 +48,13 @@ allOf:
properties:
compatible:
- const: mediatek,mt8192-pcie
+ oneOf:
+ - items:
+ - enum:
+ - mediatek,mt8188-pcie
+ - mediatek,mt8195-pcie
+ - const: mediatek,mt8192-pcie
+ - const: mediatek,mt8192-pcie
reg:
maxItems: 1
@@ -84,7 +90,9 @@ properties:
- const: tl_96m
- const: tl_32k
- const: peri_26m
- - const: top_133m
+ - enum:
+ - top_133m # for MT8192
+ - peri_mem # for MT8188/MT8195
assigned-clocks:
maxItems: 1
@@ -126,6 +134,7 @@ required:
- interrupts
- ranges
- clocks
+ - clock-names
- '#interrupt-cells'
- interrupt-controller
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195
2022-08-02 12:06 [PATCH v4] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195 Jianjun Wang
@ 2022-08-03 6:44 ` Krzysztof Kozlowski
2022-08-23 12:51 ` Lorenzo Pieralisi
2022-08-17 3:13 ` Jianjun Wang
2022-08-23 13:40 ` Lorenzo Pieralisi
2 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-03 6:44 UTC (permalink / raw)
To: Jianjun Wang, Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger
Cc: linux-pci, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Ryder Lee, Rex-BC.Chen, TingHan.Shen,
Liju-clr.Chen, Jian.Yang
On 02/08/2022 14:06, Jianjun Wang wrote:
> MT8188 and MT8195 are ARM platform SoCs with the same PCIe IP as MT8192.
>
> Also add new clock name "peri_mem" since the MT8188 and MT8195 use clock
> "peri_mem" instead of "top_133m".
>
> Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> ---
> Changes in v4:
> Remove "items" for "mediatek,mt8192-pcie" since it only have one item.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195
2022-08-03 6:44 ` Krzysztof Kozlowski
@ 2022-08-23 12:51 ` Lorenzo Pieralisi
2022-08-23 13:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Lorenzo Pieralisi @ 2022-08-23 12:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Jianjun Wang, Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger, linux-pci, linux-mediatek, devicetree,
linux-kernel, linux-arm-kernel, Ryder Lee, Rex-BC.Chen,
TingHan.Shen, Liju-clr.Chen, Jian.Yang
On Wed, Aug 03, 2022 at 08:44:11AM +0200, Krzysztof Kozlowski wrote:
> On 02/08/2022 14:06, Jianjun Wang wrote:
> > MT8188 and MT8195 are ARM platform SoCs with the same PCIe IP as MT8192.
> >
> > Also add new clock name "peri_mem" since the MT8188 and MT8195 use clock
> > "peri_mem" instead of "top_133m".
> >
> > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> > ---
> > Changes in v4:
> > Remove "items" for "mediatek,mt8192-pcie" since it only have one item.
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Should I pick this up ?
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195
2022-08-23 12:51 ` Lorenzo Pieralisi
@ 2022-08-23 13:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-23 13:27 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: Jianjun Wang, Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger, linux-pci, linux-mediatek, devicetree,
linux-kernel, linux-arm-kernel, Ryder Lee, Rex-BC.Chen,
TingHan.Shen, Liju-clr.Chen, Jian.Yang
On 23/08/2022 15:51, Lorenzo Pieralisi wrote:
> On Wed, Aug 03, 2022 at 08:44:11AM +0200, Krzysztof Kozlowski wrote:
>> On 02/08/2022 14:06, Jianjun Wang wrote:
>>> MT8188 and MT8195 are ARM platform SoCs with the same PCIe IP as MT8192.
>>>
>>> Also add new clock name "peri_mem" since the MT8188 and MT8195 use clock
>>> "peri_mem" instead of "top_133m".
>>>
>>> Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
>>> ---
>>> Changes in v4:
>>> Remove "items" for "mediatek,mt8192-pcie" since it only have one item.
>>
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Should I pick this up ?
Yes, go ahead. Thanks!
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195
2022-08-02 12:06 [PATCH v4] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195 Jianjun Wang
2022-08-03 6:44 ` Krzysztof Kozlowski
@ 2022-08-17 3:13 ` Jianjun Wang
2022-08-23 13:40 ` Lorenzo Pieralisi
2 siblings, 0 replies; 6+ messages in thread
From: Jianjun Wang @ 2022-08-17 3:13 UTC (permalink / raw)
To: Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski, Matthias Brugger
Cc: linux-pci, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Ryder Lee, Rex-BC.Chen, TingHan.Shen,
Liju-clr.Chen, Jian.Yang
Hi Maintainers,
Gentle ping for this patch, if there is anything I need to modify,
please kindly let me know.
Thanks.
On Tue, 2022-08-02 at 20:06 +0800, Jianjun Wang wrote:
> MT8188 and MT8195 are ARM platform SoCs with the same PCIe IP as
> MT8192.
>
> Also add new clock name "peri_mem" since the MT8188 and MT8195 use
> clock
> "peri_mem" instead of "top_133m".
>
> Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> ---
> Changes in v4:
> Remove "items" for "mediatek,mt8192-pcie" since it only have one
> item.
>
> Changes in v3:
> Use enum property to add the new clock name.
>
> Changes in v2:
> Merge two patches into one.
> ---
> .../devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 13
> +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-
> gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-
> gen3.yaml
> index 0499b94627ae..c00be39af64e 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -48,7 +48,13 @@ allOf:
>
> properties:
> compatible:
> - const: mediatek,mt8192-pcie
> + oneOf:
> + - items:
> + - enum:
> + - mediatek,mt8188-pcie
> + - mediatek,mt8195-pcie
> + - const: mediatek,mt8192-pcie
> + - const: mediatek,mt8192-pcie
>
> reg:
> maxItems: 1
> @@ -84,7 +90,9 @@ properties:
> - const: tl_96m
> - const: tl_32k
> - const: peri_26m
> - - const: top_133m
> + - enum:
> + - top_133m # for MT8192
> + - peri_mem # for MT8188/MT8195
>
> assigned-clocks:
> maxItems: 1
> @@ -126,6 +134,7 @@ required:
> - interrupts
> - ranges
> - clocks
> + - clock-names
> - '#interrupt-cells'
> - interrupt-controller
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195
2022-08-02 12:06 [PATCH v4] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195 Jianjun Wang
2022-08-03 6:44 ` Krzysztof Kozlowski
2022-08-17 3:13 ` Jianjun Wang
@ 2022-08-23 13:40 ` Lorenzo Pieralisi
2 siblings, 0 replies; 6+ messages in thread
From: Lorenzo Pieralisi @ 2022-08-23 13:40 UTC (permalink / raw)
To: Krzysztof Kozlowski, Matthias Brugger, Rob Herring,
Bjorn Helgaas, Jianjun Wang
Cc: Lorenzo Pieralisi, Ryder Lee, devicetree, linux-arm-kernel,
linux-pci, Rex-BC.Chen, Liju-clr.Chen, linux-mediatek,
linux-kernel, Jian.Yang, TingHan.Shen
On Tue, 2 Aug 2022 20:06:24 +0800, Jianjun Wang wrote:
> MT8188 and MT8195 are ARM platform SoCs with the same PCIe IP as MT8192.
>
> Also add new clock name "peri_mem" since the MT8188 and MT8195 use clock
> "peri_mem" instead of "top_133m".
>
>
Applied to pci/dt, thanks!
[1/1] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195
https://git.kernel.org/lpieralisi/pci/c/7f08e806a03e
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-23 17:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-02 12:06 [PATCH v4] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195 Jianjun Wang
2022-08-03 6:44 ` Krzysztof Kozlowski
2022-08-23 12:51 ` Lorenzo Pieralisi
2022-08-23 13:27 ` Krzysztof Kozlowski
2022-08-17 3:13 ` Jianjun Wang
2022-08-23 13:40 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).