[PATCH] microblaze/PCI: Remove stale pcibios_align_resource() comment

[PATCH] microblaze/PCI: Remove stale pcibios_align_resource() comment

[Lorenzo Pieralisi]

commit 01cf9d524ff0 ("microblaze/PCI: Support generic Xilinx AXI PCIe Host
Bridge IP driver")

and

commit ecf677c8dcaa ("PCI: Add a generic weak pcibios_align_resource()")

first patched then removed pcibios_align_resource() from the microblaze
architecture code but failed to remove the comment that was added to
it.

Remove it since it has now become stale and it is quite confusing.

Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Bharat Kumar Gogada <bharatku@xilinx.com>
Cc: Michal Simek <monstr@monstr.eu>
---
 arch/microblaze/pci/pci-common.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c
index f34346d56095..2ffd171af8b6 100644
--- a/arch/microblaze/pci/pci-common.c
+++ b/arch/microblaze/pci/pci-common.c
@@ -597,19 +597,6 @@ static void pcibios_fixup_resources(struct pci_dev *dev)
 }
 DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, pcibios_fixup_resources);
 
-/*
- * We need to avoid collisions with `mirrored' VGA ports
- * and other strange ISA hardware, so we always want the
- * addresses to be allocated in the 0x000-0x0ff region
- * modulo 0x400.
- *
- * Why? Because some silly external IO cards only decode
- * the low 10 bits of the IO address. The 0x00-0xff region
- * is reserved for motherboard devices that decode all 16
- * bits, so it's ok to allocate at, say, 0x2800-0x28ff,
- * but we want to try to avoid allocating at 0x2900-0x2bff
- * which might have be mirrored at 0x0100-0x03ff..
- */
 int pcibios_add_device(struct pci_dev *dev)
 {
 	dev->irq = of_irq_parse_and_map_pci(dev, 0, 0);
-- 
2.15.0

Re: [PATCH] microblaze/PCI: Remove stale pcibios_align_resource() comment

[Michal Simek]

[-- Attachment #1.1: Type: text/plain, Size: 2185 bytes --]

On 20.8.2018 11:47, Lorenzo Pieralisi wrote:
> commit 01cf9d524ff0 ("microblaze/PCI: Support generic Xilinx AXI PCIe Host
> Bridge IP driver")
> 
> and
> 
> commit ecf677c8dcaa ("PCI: Add a generic weak pcibios_align_resource()")
> 
> first patched then removed pcibios_align_resource() from the microblaze
> architecture code but failed to remove the comment that was added to
> it.
> 
> Remove it since it has now become stale and it is quite confusing.
> 
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Bharat Kumar Gogada <bharatku@xilinx.com>
> Cc: Michal Simek <monstr@monstr.eu>
> ---
>  arch/microblaze/pci/pci-common.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c
> index f34346d56095..2ffd171af8b6 100644
> --- a/arch/microblaze/pci/pci-common.c
> +++ b/arch/microblaze/pci/pci-common.c
> @@ -597,19 +597,6 @@ static void pcibios_fixup_resources(struct pci_dev *dev)
>  }
>  DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, pcibios_fixup_resources);
>  
> -/*
> - * We need to avoid collisions with `mirrored' VGA ports
> - * and other strange ISA hardware, so we always want the
> - * addresses to be allocated in the 0x000-0x0ff region
> - * modulo 0x400.
> - *
> - * Why? Because some silly external IO cards only decode
> - * the low 10 bits of the IO address. The 0x00-0xff region
> - * is reserved for motherboard devices that decode all 16
> - * bits, so it's ok to allocate at, say, 0x2800-0x28ff,
> - * but we want to try to avoid allocating at 0x2900-0x2bff
> - * which might have be mirrored at 0x0100-0x03ff..
> - */
>  int pcibios_add_device(struct pci_dev *dev)
>  {
>  	dev->irq = of_irq_parse_and_map_pci(dev, 0, 0);
> 

Applied.
M

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] microblaze/PCI: Remove stale pcibios_align_resource() comment

[Palmer Dabbelt]

On Mon, 20 Aug 2018 23:24:53 PDT (-0700), monstr@monstr.eu wrote:
> On 20.8.2018 11:47, Lorenzo Pieralisi wrote:
>> commit 01cf9d524ff0 ("microblaze/PCI: Support generic Xilinx AXI PCIe Host
>> Bridge IP driver")
>>
>> and
>>
>> commit ecf677c8dcaa ("PCI: Add a generic weak pcibios_align_resource()")
>>
>> first patched then removed pcibios_align_resource() from the microblaze
>> architecture code but failed to remove the comment that was added to
>> it.
>>
>> Remove it since it has now become stale and it is quite confusing.
>>
>> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Cc: Palmer Dabbelt <palmer@dabbelt.com>
>> Cc: Bjorn Helgaas <bhelgaas@google.com>
>> Cc: Bharat Kumar Gogada <bharatku@xilinx.com>
>> Cc: Michal Simek <monstr@monstr.eu>
>> ---
>>  arch/microblaze/pci/pci-common.c | 13 -------------
>>  1 file changed, 13 deletions(-)
>>
>> diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c
>> index f34346d56095..2ffd171af8b6 100644
>> --- a/arch/microblaze/pci/pci-common.c
>> +++ b/arch/microblaze/pci/pci-common.c
>> @@ -597,19 +597,6 @@ static void pcibios_fixup_resources(struct pci_dev *dev)
>>  }
>>  DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, pcibios_fixup_resources);
>>
>> -/*
>> - * We need to avoid collisions with `mirrored' VGA ports
>> - * and other strange ISA hardware, so we always want the
>> - * addresses to be allocated in the 0x000-0x0ff region
>> - * modulo 0x400.
>> - *
>> - * Why? Because some silly external IO cards only decode
>> - * the low 10 bits of the IO address. The 0x00-0xff region
>> - * is reserved for motherboard devices that decode all 16
>> - * bits, so it's ok to allocate at, say, 0x2800-0x28ff,
>> - * but we want to try to avoid allocating at 0x2900-0x2bff
>> - * which might have be mirrored at 0x0100-0x03ff..
>> - */
>>  int pcibios_add_device(struct pci_dev *dev)
>>  {
>>  	dev->irq = of_irq_parse_and_map_pci(dev, 0, 0);
>>
>
> Applied.

Sorry, I missed this.  Thanks for the fix!