From: Jiri Olsa <jolsa@redhat.com>
To: Kajol Jain <kjain@linux.ibm.com>
Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
pc@us.ibm.com, namhyung@kernel.org, ak@linux.intel.com,
yao.jin@linux.intel.com, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, irogers@google.com,
maddy@linux.ibm.com, ravi.bangoria@linux.ibm.com,
anju@linux.vnet.ibm.com, kan.liang@linux.intel.com,
nasastry@in.ibm.com
Subject: Re: [RFC v2 5/5] perf/tools/pmu_events/powerpc: Add hv_24x7 core level metric events
Date: Sun, 12 Jul 2020 20:55:43 +0200 [thread overview]
Message-ID: <20200712185543.GC147742@krava> (raw)
In-Reply-To: <20200707122314.624400-6-kjain@linux.ibm.com>
On Tue, Jul 07, 2020 at 05:53:14PM +0530, Kajol Jain wrote:
> This patch adds hv_24x7 core level events in nest_metric.json file
> and also add PerChip/PerCore field in metric events.
>
> Result:
>
> power9 platform:
>
> command:# ./perf stat --metric-only -M PowerBUS_Frequency -C 0 -I 1000
> 1.000070601 1.9 2.0
> 2.000253881 2.0 1.9
> 3.000364810 2.0 2.0
>
> Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
> ---
> .../arch/powerpc/power9/nest_metrics.json | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json b/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json
> index c121e526442a..2a471cb5dd7a 100644
> --- a/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json
> +++ b/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json
> @@ -3,17 +3,26 @@
> "MetricExpr": "(hv_24x7@PM_MCS01_128B_RD_DISP_PORT01\\,chip\\=?@ + hv_24x7@PM_MCS01_128B_RD_DISP_PORT23\\,chip\\=?@ + hv_24x7@PM_MCS23_128B_RD_DISP_PORT01\\,chip\\=?@ + hv_24x7@PM_MCS23_128B_RD_DISP_PORT23\\,chip\\=?@)",
> "MetricName": "Memory_RD_BW_Chip",
> "MetricGroup": "Memory_BW",
> - "ScaleUnit": "1.6e-2MB"
> + "ScaleUnit": "1.6e-2MB",
> + "AggregationMode": "PerChip"
> },
> {
> "MetricExpr": "(hv_24x7@PM_MCS01_128B_WR_DISP_PORT01\\,chip\\=?@ + hv_24x7@PM_MCS01_128B_WR_DISP_PORT23\\,chip\\=?@ + hv_24x7@PM_MCS23_128B_WR_DISP_PORT01\\,chip\\=?@ + hv_24x7@PM_MCS23_128B_WR_DISP_PORT23\\,chip\\=?@ )",
> "MetricName": "Memory_WR_BW_Chip",
> "MetricGroup": "Memory_BW",
> - "ScaleUnit": "1.6e-2MB"
> + "ScaleUnit": "1.6e-2MB",
> + "AggregationMode": "PerChip"
please keep the same indentation, also below
jirka
> },
> {
> "MetricExpr": "(hv_24x7@PM_PB_CYC\\,chip\\=?@ )",
> "MetricName": "PowerBUS_Frequency",
> - "ScaleUnit": "2.5e-7GHz"
> - }
> + "ScaleUnit": "2.5e-7GHz",
> + "AggregationMode": "PerChip"
> + },
> + {
> + "MetricExpr": "(hv_24x7@CPM_CS_32MHZ_CYC\\,domain\\=3\\,core\\=?@ )",
> + "MetricName": "CPM_CS_32MHZ_CYC",
> + "ScaleUnit": "1MHz",
> + "AggregationMode": "PerCore"
> + }
> ]
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-07-12 18:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 12:23 [RFC v2 0/5] tools/perf/pmu-events/jevents.c Kajol Jain
2020-07-07 12:23 ` [RFC v2 1/5] perf/pmu-events/jevents: Add enum to store aggregation like PerPkg Kajol Jain
2020-07-12 18:55 ` Jiri Olsa
2020-07-14 9:09 ` kajoljain
2020-07-07 12:23 ` [RFC v2 2/5] pmu-events/x86/uncore: Replace PerPkg field to AggregationMode in x86 json files Kajol Jain
2020-07-07 12:23 ` [RFC v2 3/5] perf jevents: Add support for parsing perchip/percore events Kajol Jain
2020-07-12 18:55 ` Jiri Olsa
2020-07-14 9:12 ` kajoljain
2020-07-07 12:23 ` [RFC v2 4/5] perf/tools: Pass pmu_event structure as a parameter for arch_get_runtimeparam Kajol Jain
2020-07-07 12:23 ` [RFC v2 5/5] perf/tools/pmu_events/powerpc: Add hv_24x7 core level metric events Kajol Jain
2020-07-12 18:55 ` Jiri Olsa [this message]
2020-07-12 18:57 ` [RFC v2 0/5] tools/perf/pmu-events/jevents.c Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200712185543.GC147742@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anju@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nasastry@in.ibm.com \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).