From: kajoljain <kjain@linux.ibm.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
pc@us.ibm.com, namhyung@kernel.org, ak@linux.intel.com,
yao.jin@linux.intel.com, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, irogers@google.com,
maddy@linux.ibm.com, ravi.bangoria@linux.ibm.com,
anju@linux.vnet.ibm.com, kan.liang@linux.intel.com,
nasastry@in.ibm.com
Subject: Re: [RFC v2 1/5] perf/pmu-events/jevents: Add enum to store aggregation like PerPkg
Date: Tue, 14 Jul 2020 14:39:20 +0530 [thread overview]
Message-ID: <38d2fd54-41aa-61b0-c396-c58fc1da70da@linux.ibm.com> (raw)
In-Reply-To: <20200712185534.GB147742@krava>
On 7/13/20 12:25 AM, Jiri Olsa wrote:
> On Tue, Jul 07, 2020 at 05:53:10PM +0530, Kajol Jain wrote:
>
> SNIP
>
>> }
>>
>> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
>> index 93fe72a9dc0b..3cafbb320d68 100644
>> --- a/tools/perf/util/pmu.c
>> +++ b/tools/perf/util/pmu.c
>> @@ -306,7 +306,7 @@ static bool perf_pmu_merge_alias(struct perf_pmu_alias *newalias,
>> static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
>> char *desc, char *val,
>> char *long_desc, char *topic,
>> - char *unit, char *perpkg,
>> + char *unit, char *aggr_mode,
>> char *metric_expr,
>> char *metric_name,
>> char *deprecated)
>> @@ -378,7 +378,7 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
>> return -1;
>> snprintf(alias->unit, sizeof(alias->unit), "%s", unit);
>> }
>> - alias->per_pkg = perpkg && sscanf(perpkg, "%d", &num) == 1 && num == 1;
>> + alias->per_pkg = aggr_mode && sscanf(aggr_mode, "%d", &num) == 1 && num == 1;
>
> should you rather use 'num == PerPkg' instead 'num == 1' ?
Hi Jiri,
Thanks for reviewing the patchset. Sure I will update it.
Thanks,
Kajol Jain
>
> jirka
>
next prev parent reply other threads:[~2020-07-14 9:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 12:23 [RFC v2 0/5] tools/perf/pmu-events/jevents.c Kajol Jain
2020-07-07 12:23 ` [RFC v2 1/5] perf/pmu-events/jevents: Add enum to store aggregation like PerPkg Kajol Jain
2020-07-12 18:55 ` Jiri Olsa
2020-07-14 9:09 ` kajoljain [this message]
2020-07-07 12:23 ` [RFC v2 2/5] pmu-events/x86/uncore: Replace PerPkg field to AggregationMode in x86 json files Kajol Jain
2020-07-07 12:23 ` [RFC v2 3/5] perf jevents: Add support for parsing perchip/percore events Kajol Jain
2020-07-12 18:55 ` Jiri Olsa
2020-07-14 9:12 ` kajoljain
2020-07-07 12:23 ` [RFC v2 4/5] perf/tools: Pass pmu_event structure as a parameter for arch_get_runtimeparam Kajol Jain
2020-07-07 12:23 ` [RFC v2 5/5] perf/tools/pmu_events/powerpc: Add hv_24x7 core level metric events Kajol Jain
2020-07-12 18:55 ` Jiri Olsa
2020-07-12 18:57 ` [RFC v2 0/5] tools/perf/pmu-events/jevents.c Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38d2fd54-41aa-61b0-c396-c58fc1da70da@linux.ibm.com \
--to=kjain@linux.ibm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anju@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nasastry@in.ibm.com \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).