From: Jiri Olsa <jolsa@redhat.com>
To: kajoljain <kjain@linux.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, pc@us.ibm.com,
namhyung@kernel.org, ak@linux.intel.com, yao.jin@linux.intel.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
irogers@google.com, maddy@linux.ibm.com,
ravi.bangoria@linux.ibm.com, anju@linux.vnet.ibm.com,
kan.liang@linux.intel.com, nasastry@in.ibm.com
Subject: Re: [PATCH v3 0/5] powerpc/perf: Add json file support for hv_24x7 core level events
Date: Fri, 17 Jul 2020 10:55:36 +0200 [thread overview]
Message-ID: <20200717085536.GC528602@krava> (raw)
In-Reply-To: <a80eebc2-885c-171d-7c7a-74df727d60b4@linux.ibm.com>
On Fri, Jul 17, 2020 at 01:41:22PM +0530, kajoljain wrote:
>
>
> On 7/16/20 8:52 PM, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jul 16, 2020 at 03:12:11PM +0530, Kajol Jain escreveu:
> >> Patchset enhance current runtime parameter support. It introduces new
> >> fields like "PerChip" and "PerCore" similar to the field "PerPkg" which is
> >> used to specify perpkg events.
> >>
> >> The "PerCore" and "PerChip" specifies whether its core or chip events.
> >> Based on which we can decide which runtime parameter user want to
> >> access. Now character '?' can refers different parameter based on user
> >> requirement.
> >>
> >> Initially, every time we want to add new terms like chip, core, thread
> >> etc, we need to create corrsponding fields in pmu_events and event
> >> struct.
> >> This patchset adds an enum called 'aggr_mode_class' which store all these
> >> aggregation like perpkg/percore. It also adds new field 'AggregationMode'
> >> to capture these terms.
> >> Now, if user wants to add any new term, they just need to add it in
> >> the enum defined. I try to test it with my current setup.
> >>
> >> I also need to replace PerPkg field to AggregationMode in all the
> >> x86 uncore json files. It will great if Andi and team can test it
> >> and let me know if they have any concerns.
> >>
> >> Changelog:
> >> v2 -> v3:
> >> - Did some nits changes suggested by Jiri include correction of
> >> indentation, and making PerCore/PerChip values forward after
> >> PerPkg as 1 in the enum.
> >> - Rebase the patchset on Arnaldo's tmp.perf/core branch.
> >> - Change RFC tag
> >
> > Hey, have anybody provided Acked-by/Reviewed-by for previous revisions
> > of this patchset? If so you could have collected them for patches
> > without changes, was that the case?
>
> Hi Arnaldo,
> I did get "Acked-by: Ian Rogers" on my initial prototype which I send in my RFC.
> Link to the patch: https://lkml.org/lkml/2020/7/5/399
>
> After that, I break it down and made some nits changes as suggested by Jiri, that's why I didn't
> add his Acked-by tag.
> Ian should I add it, if it seems fine to you.
I posted one more comment and I'd also like to hear from
guys maintainng json list on intel side that they are ok
with this, mainly the change introduced in:
pmu-events/x86/uncore: Replace PerPkg field to AggregationMode in x86 json files
Andi?
thanks,
jirka
next prev parent reply other threads:[~2020-07-17 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 9:42 [PATCH v3 0/5] powerpc/perf: Add json file support for hv_24x7 core level events Kajol Jain
2020-07-16 9:42 ` [PATCH v3 1/5] perf/pmu-events/jevents: Add enum to store aggregation like PerPkg Kajol Jain
2020-07-17 8:53 ` Jiri Olsa
2020-07-16 9:42 ` [PATCH v3 2/5] pmu-events/x86/uncore: Replace PerPkg field to AggregationMode in x86 json files Kajol Jain
2020-07-16 9:42 ` [PATCH v3 3/5] perf jevents: Add support for parsing perchip/percore events Kajol Jain
2020-07-16 9:42 ` [PATCH v3 4/5] perf/tools: Pass pmu_event structure as a parameter for arch_get_runtimeparam Kajol Jain
2020-07-16 9:42 ` [PATCH v3 5/5] perf/tools/pmu_events/powerpc: Add hv_24x7 core level metric events Kajol Jain
2020-07-16 15:22 ` [PATCH v3 0/5] powerpc/perf: Add json file support for hv_24x7 core level events Arnaldo Carvalho de Melo
2020-07-17 8:11 ` kajoljain
2020-07-17 8:55 ` Jiri Olsa [this message]
2020-07-17 22:11 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717085536.GC528602@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anju@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nasastry@in.ibm.com \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).