From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Jie Zhan <zhanjie9@hisilicon.com>
Cc: <will@kernel.org>, <mark.rutland@arm.com>,
<mathieu.poirier@linaro.org>, <suzuki.poulose@arm.com>,
<mike.leach@linaro.org>, <leo.yan@linaro.org>,
<john.g.garry@oracle.com>, <james.clark@arm.com>,
<peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<corbet@lwn.net>, <zhangshaokun@hisilicon.com>,
<shenyang39@huawei.com>, <hejunhao3@huawei.com>,
<yangyicong@hisilicon.com>, <prime.zeng@huawei.com>,
<suntao25@huawei.com>, <jiazhao4@hisilicon.com>,
<linuxarm@huawei.com>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-perf-users@vger.kernel.org>
Subject: Re: [RFC PATCH v1 3/4] perf tool: Add HiSilicon PMCU data recording support
Date: Fri, 17 Mar 2023 15:13:22 +0000 [thread overview]
Message-ID: <20230317151322.000034eb@Huawei.com> (raw)
In-Reply-To: <20230206065146.645505-4-zhanjie9@hisilicon.com>
On Mon, 6 Feb 2023 14:51:45 +0800
Jie Zhan <zhanjie9@hisilicon.com> wrote:
> Support for HiSilicon PMCU data recording using 'perf-record'.
>
> Users can start PMCU profiling through 'perf-record'. Event numbers are
> passed by a sysfs interface. The following optional parameters can be
> passed through 'perf-record':
> - nr_sample: number of samples to take
> - sample_period_ms: time in ms for PMU counters to stay on for an event
> - pmccfiltr: bits[31-24] of system register PMCCFILTR_EL0
>
> Example usage:
>
> 1. Enter event numbers in the 'user_events' file:
>
> echo "0x10 0x11" > /sys/devices/hisi_pmcu_sccl3/user_events
>
> 2. Start the sampling with 'perf-record':
>
> perf record -e hisi_pmcu_sccl3/nr_sample=1000,sample_period_ms=1/
>
> In this example, the PMCU takes 1000 samples of event 0x0010 and 0x0011
> with a sampling period of 1ms. Data will be written to a 'perf.data' file.
>
> Co-developed-by: Yang Shen <shenyang39@huawei.com>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
> Signed-off-by: Jie Zhan <zhanjie9@hisilicon.com>
I'm not particularly knowledgeable about perf tool so just some superficial comments
from me.
> ---
> diff --git a/tools/perf/arch/arm64/util/hisi-pmcu.c b/tools/perf/arch/arm64/util/hisi-pmcu.c
> new file mode 100644
> index 000000000000..7c33abf1182d
> --- /dev/null
> +++ b/tools/perf/arch/arm64/util/hisi-pmcu.c
> +struct hisi_pmcu_record {
> + struct auxtrace_record itr;
> + struct perf_pmu *hisi_pmcu_pmu;
> + struct evlist *evlist;
> +};
...
> +struct auxtrace_record *hisi_pmcu_recording_init(int *err,
> + struct perf_pmu *hisi_pmcu_pmu)
> +{
...
> + pmcu_record->hisi_pmcu_pmu = hisi_pmcu_pmu;
> + pmcu_record->itr.recording_options = hisi_pmcu_recording_options;
> + pmcu_record->itr.info_priv_size = hisi_pmcu_info_priv_size;
> + pmcu_record->itr.info_fill = hisi_pmcu_info_fill;
> + pmcu_record->itr.free = hisi_pmcu_record_free;
> + pmcu_record->itr.reference = hisi_pmcu_reference;
> + pmcu_record->itr.read_finish = auxtrace_record__read_finish;
> + pmcu_record->itr.alignment = HISI_PMCU_DATA_ALIGNMENT;
> + pmcu_record->itr.pmu = hisi_pmcu_pmu;
Maybe a local variable for itr - or if you can rely on c99 in perf tool
a compound literal to use structure field names etc.
pmcu_record->itr = (struct xxx){
.recording_options = ,
etc
> +
> + *err = 0;
> + return &pmcu_record->itr;
> +}
> diff --git a/tools/perf/util/hisi-pmcu.h b/tools/perf/util/hisi-pmcu.h
> new file mode 100644
> index 000000000000..d46d523a3aee
> --- /dev/null
> +++ b/tools/perf/util/hisi-pmcu.h
> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * HiSilicon Performance Monitor Control Unit (PMCU) support
> + *
> + * Copyright (C) 2022 HiSilicon Limited
Probably want to update the dates if any substantial changes for v2.
next prev parent reply other threads:[~2023-03-17 15:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 6:51 [RFC PATCH v1 0/4] HiSilicon Performance Monitor Control Unit Jie Zhan
2023-02-06 6:51 ` [RFC PATCH v1 1/4] docs: perf: Add documentation for HiSilicon PMCU Jie Zhan
2023-02-07 3:03 ` Jie Zhan
2023-03-17 13:37 ` Jonathan Cameron
2023-03-24 9:32 ` Jie Zhan
2023-03-24 12:14 ` Jonathan Cameron
2023-03-25 2:48 ` Jie Zhan
2023-02-06 6:51 ` [RFC PATCH v1 2/4] drivers/perf: hisi: Add driver support " Jie Zhan
2023-03-17 14:52 ` Jonathan Cameron
2023-03-25 10:21 ` Jie Zhan
2023-02-06 6:51 ` [RFC PATCH v1 3/4] perf tool: Add HiSilicon PMCU data recording support Jie Zhan
2023-03-17 15:13 ` Jonathan Cameron [this message]
2023-02-06 6:51 ` [RFC PATCH v1 4/4] perf tool: Add HiSilicon PMCU data decoding support Jie Zhan
2023-02-27 8:49 ` [RFC PATCH v1 0/4] HiSilicon Performance Monitor Control Unit Jie Zhan
2023-03-17 13:11 ` Jonathan Cameron
2023-04-19 8:01 ` Jie Zhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230317151322.000034eb@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=acme@kernel.org \
--cc=corbet@lwn.net \
--cc=hejunhao3@huawei.com \
--cc=james.clark@arm.com \
--cc=jiazhao4@hisilicon.com \
--cc=john.g.garry@oracle.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=prime.zeng@huawei.com \
--cc=shenyang39@huawei.com \
--cc=suntao25@huawei.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=zhangshaokun@hisilicon.com \
--cc=zhanjie9@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).