* [PATCH] perf sched: sync task state macros with kernel
@ 2023-03-29 3:52 Ze Gao
2023-03-29 7:11 ` Peter Zijlstra
0 siblings, 1 reply; 2+ messages in thread
From: Ze Gao @ 2023-03-29 3:52 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Ian Rogers, Adrian Hunter
Cc: Ze Gao, Ingo Molnar, linux-perf-users, linux-kernel
commit 8ef9925b02c2 ("sched/debug: Add explicit TASK_PARKED printing")
changes some task state macros, this patch makes perf-sched in sync
Fixes: 8ef9925b02c2 ("sched/debug: Add explicit TASK_PARKED printing")
Signed-off-by: Ze Gao <zegao2021@gmail.com>
---
tools/perf/builtin-sched.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 86e18575c9be..c715593d88c4 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -105,10 +105,10 @@ struct sched_atom {
#define EXIT_ZOMBIE 32
#define EXIT_TRACE (EXIT_ZOMBIE | EXIT_DEAD)
/* in tsk->state again */
-#define TASK_DEAD 64
-#define TASK_WAKEKILL 128
-#define TASK_WAKING 256
-#define TASK_PARKED 512
+#define TASK_PARKED 64
+#define TASK_DEAD 128
+#define TASK_WAKEKILL 256
+#define TASK_WAKING 512
enum thread_state {
THREAD_SLEEPING = 0,
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf sched: sync task state macros with kernel
2023-03-29 3:52 [PATCH] perf sched: sync task state macros with kernel Ze Gao
@ 2023-03-29 7:11 ` Peter Zijlstra
0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2023-03-29 7:11 UTC (permalink / raw)
To: Ze Gao
Cc: Ingo Molnar, Arnaldo Carvalho de Melo, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, Ian Rogers,
Adrian Hunter, Ingo Molnar, linux-perf-users, linux-kernel
On Wed, Mar 29, 2023 at 11:52:02AM +0800, Ze Gao wrote:
> commit 8ef9925b02c2 ("sched/debug: Add explicit TASK_PARKED printing")
> changes some task state macros, this patch makes perf-sched in sync
>
Why does perf care? Where do we export raw state values?
That is, I really don't like this being ABI...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-29 7:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-29 3:52 [PATCH] perf sched: sync task state macros with kernel Ze Gao
2023-03-29 7:11 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).