Re: [PATCH 1/2] replace 2&>1 by 2>&1

[Namhyung Kim <namhyung@gmail.com>]

Hello,

On Fri, Mar 24, 2023 at 1:19 PM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Thu, Mar 23, 2023 at 11:03:49AM -0700, Ian Rogers escreveu:
> > On Mon, Mar 6, 2023 at 1:46 PM Ian Rogers <irogers@google.com> wrote:
> > >
> > > On Fri, Mar 3, 2023 at 11:31 AM Patrice Duroux <patrice.duroux@gmail.com> wrote:
> > > >
> > > > Signed-off-by: Patrice Duroux <patrice.duroux@gmail.com>
> > >
> > > Fixes: ade1d0307b2f ("perf offcpu: Update offcpu test for child process")
> > > Acked-by: Ian Rogers <irogers@google.com>
> > >
> > > Thanks,
> > > Ian
> >
> > Arnaldo, could we pick this up?
>
> Yeah, but next time please write in the subject line that its a patch
> for the perf tools :-)

Oops, it was me who messed this up.. sorry about that.
At least now I know where the file named "1" is created. :)

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

> >
> > > > ---
> > > >  tools/perf/tests/shell/record_offcpu.sh | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
> > > > index e01973d4e0fb..f062ae9a95e1 100755
> > > > --- a/tools/perf/tests/shell/record_offcpu.sh
> > > > +++ b/tools/perf/tests/shell/record_offcpu.sh
> > > > @@ -65,7 +65,7 @@ test_offcpu_child() {
> > > >
> > > >    # perf bench sched messaging creates 400 processes
> > > >    if ! perf record --off-cpu -e dummy -o ${perfdata} -- \
> > > > -    perf bench sched messaging -g 10 > /dev/null 2&>1
> > > > +    perf bench sched messaging -g 10 > /dev/null 2>&1
> > > >    then
> > > >      echo "Child task off-cpu test [Failed record]"
> > > >      err=1
> > > > --
> > > > 2.39.2
> > > >
>
> --
>
> - Arnaldo