* [PATCH 1/2] replace 2&>1 by 2>&1
[not found] <CAGKjw9KHDnVgRz5bstJYkq4t0-bT5fvkuQZbEB48d-8jo4Q00g@mail.gmail.com>
@ 2023-03-03 19:30 ` Patrice Duroux
2023-03-06 21:46 ` Ian Rogers
0 siblings, 1 reply; 5+ messages in thread
From: Patrice Duroux @ 2023-03-03 19:30 UTC (permalink / raw)
To: linux-perf-users; +Cc: Patrice Duroux
Signed-off-by: Patrice Duroux <patrice.duroux@gmail.com>
---
tools/perf/tests/shell/record_offcpu.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
index e01973d4e0fb..f062ae9a95e1 100755
--- a/tools/perf/tests/shell/record_offcpu.sh
+++ b/tools/perf/tests/shell/record_offcpu.sh
@@ -65,7 +65,7 @@ test_offcpu_child() {
# perf bench sched messaging creates 400 processes
if ! perf record --off-cpu -e dummy -o ${perfdata} -- \
- perf bench sched messaging -g 10 > /dev/null 2&>1
+ perf bench sched messaging -g 10 > /dev/null 2>&1
then
echo "Child task off-cpu test [Failed record]"
err=1
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] replace 2&>1 by 2>&1
2023-03-03 19:30 ` [PATCH 1/2] replace 2&>1 by 2>&1 Patrice Duroux
@ 2023-03-06 21:46 ` Ian Rogers
2023-03-23 18:03 ` Ian Rogers
0 siblings, 1 reply; 5+ messages in thread
From: Ian Rogers @ 2023-03-06 21:46 UTC (permalink / raw)
To: Patrice Duroux; +Cc: linux-perf-users
On Fri, Mar 3, 2023 at 11:31 AM Patrice Duroux <patrice.duroux@gmail.com> wrote:
>
> Signed-off-by: Patrice Duroux <patrice.duroux@gmail.com>
Fixes: ade1d0307b2f ("perf offcpu: Update offcpu test for child process")
Acked-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
> tools/perf/tests/shell/record_offcpu.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
> index e01973d4e0fb..f062ae9a95e1 100755
> --- a/tools/perf/tests/shell/record_offcpu.sh
> +++ b/tools/perf/tests/shell/record_offcpu.sh
> @@ -65,7 +65,7 @@ test_offcpu_child() {
>
> # perf bench sched messaging creates 400 processes
> if ! perf record --off-cpu -e dummy -o ${perfdata} -- \
> - perf bench sched messaging -g 10 > /dev/null 2&>1
> + perf bench sched messaging -g 10 > /dev/null 2>&1
> then
> echo "Child task off-cpu test [Failed record]"
> err=1
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] replace 2&>1 by 2>&1
2023-03-06 21:46 ` Ian Rogers
@ 2023-03-23 18:03 ` Ian Rogers
2023-03-24 20:09 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 5+ messages in thread
From: Ian Rogers @ 2023-03-23 18:03 UTC (permalink / raw)
To: Patrice Duroux; +Cc: linux-perf-users
On Mon, Mar 6, 2023 at 1:46 PM Ian Rogers <irogers@google.com> wrote:
>
> On Fri, Mar 3, 2023 at 11:31 AM Patrice Duroux <patrice.duroux@gmail.com> wrote:
> >
> > Signed-off-by: Patrice Duroux <patrice.duroux@gmail.com>
>
> Fixes: ade1d0307b2f ("perf offcpu: Update offcpu test for child process")
> Acked-by: Ian Rogers <irogers@google.com>
>
> Thanks,
> Ian
Arnaldo, could we pick this up?
Thanks,
Ian
> > ---
> > tools/perf/tests/shell/record_offcpu.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
> > index e01973d4e0fb..f062ae9a95e1 100755
> > --- a/tools/perf/tests/shell/record_offcpu.sh
> > +++ b/tools/perf/tests/shell/record_offcpu.sh
> > @@ -65,7 +65,7 @@ test_offcpu_child() {
> >
> > # perf bench sched messaging creates 400 processes
> > if ! perf record --off-cpu -e dummy -o ${perfdata} -- \
> > - perf bench sched messaging -g 10 > /dev/null 2&>1
> > + perf bench sched messaging -g 10 > /dev/null 2>&1
> > then
> > echo "Child task off-cpu test [Failed record]"
> > err=1
> > --
> > 2.39.2
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] replace 2&>1 by 2>&1
2023-03-23 18:03 ` Ian Rogers
@ 2023-03-24 20:09 ` Arnaldo Carvalho de Melo
2023-03-25 3:18 ` Namhyung Kim
0 siblings, 1 reply; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-03-24 20:09 UTC (permalink / raw)
To: Ian Rogers; +Cc: Patrice Duroux, linux-perf-users
Em Thu, Mar 23, 2023 at 11:03:49AM -0700, Ian Rogers escreveu:
> On Mon, Mar 6, 2023 at 1:46 PM Ian Rogers <irogers@google.com> wrote:
> >
> > On Fri, Mar 3, 2023 at 11:31 AM Patrice Duroux <patrice.duroux@gmail.com> wrote:
> > >
> > > Signed-off-by: Patrice Duroux <patrice.duroux@gmail.com>
> >
> > Fixes: ade1d0307b2f ("perf offcpu: Update offcpu test for child process")
> > Acked-by: Ian Rogers <irogers@google.com>
> >
> > Thanks,
> > Ian
>
> Arnaldo, could we pick this up?
Yeah, but next time please write in the subject line that its a patch
for the perf tools :-)
- Arnaldo
> Thanks,
> Ian
>
> > > ---
> > > tools/perf/tests/shell/record_offcpu.sh | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
> > > index e01973d4e0fb..f062ae9a95e1 100755
> > > --- a/tools/perf/tests/shell/record_offcpu.sh
> > > +++ b/tools/perf/tests/shell/record_offcpu.sh
> > > @@ -65,7 +65,7 @@ test_offcpu_child() {
> > >
> > > # perf bench sched messaging creates 400 processes
> > > if ! perf record --off-cpu -e dummy -o ${perfdata} -- \
> > > - perf bench sched messaging -g 10 > /dev/null 2&>1
> > > + perf bench sched messaging -g 10 > /dev/null 2>&1
> > > then
> > > echo "Child task off-cpu test [Failed record]"
> > > err=1
> > > --
> > > 2.39.2
> > >
--
- Arnaldo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] replace 2&>1 by 2>&1
2023-03-24 20:09 ` Arnaldo Carvalho de Melo
@ 2023-03-25 3:18 ` Namhyung Kim
0 siblings, 0 replies; 5+ messages in thread
From: Namhyung Kim @ 2023-03-25 3:18 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: Ian Rogers, Patrice Duroux, linux-perf-users
Hello,
On Fri, Mar 24, 2023 at 1:19 PM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Thu, Mar 23, 2023 at 11:03:49AM -0700, Ian Rogers escreveu:
> > On Mon, Mar 6, 2023 at 1:46 PM Ian Rogers <irogers@google.com> wrote:
> > >
> > > On Fri, Mar 3, 2023 at 11:31 AM Patrice Duroux <patrice.duroux@gmail.com> wrote:
> > > >
> > > > Signed-off-by: Patrice Duroux <patrice.duroux@gmail.com>
> > >
> > > Fixes: ade1d0307b2f ("perf offcpu: Update offcpu test for child process")
> > > Acked-by: Ian Rogers <irogers@google.com>
> > >
> > > Thanks,
> > > Ian
> >
> > Arnaldo, could we pick this up?
>
> Yeah, but next time please write in the subject line that its a patch
> for the perf tools :-)
Oops, it was me who messed this up.. sorry about that.
At least now I know where the file named "1" is created. :)
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> >
> > > > ---
> > > > tools/perf/tests/shell/record_offcpu.sh | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
> > > > index e01973d4e0fb..f062ae9a95e1 100755
> > > > --- a/tools/perf/tests/shell/record_offcpu.sh
> > > > +++ b/tools/perf/tests/shell/record_offcpu.sh
> > > > @@ -65,7 +65,7 @@ test_offcpu_child() {
> > > >
> > > > # perf bench sched messaging creates 400 processes
> > > > if ! perf record --off-cpu -e dummy -o ${perfdata} -- \
> > > > - perf bench sched messaging -g 10 > /dev/null 2&>1
> > > > + perf bench sched messaging -g 10 > /dev/null 2>&1
> > > > then
> > > > echo "Child task off-cpu test [Failed record]"
> > > > err=1
> > > > --
> > > > 2.39.2
> > > >
>
> --
>
> - Arnaldo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-25 3:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAGKjw9KHDnVgRz5bstJYkq4t0-bT5fvkuQZbEB48d-8jo4Q00g@mail.gmail.com>
2023-03-03 19:30 ` [PATCH 1/2] replace 2&>1 by 2>&1 Patrice Duroux
2023-03-06 21:46 ` Ian Rogers
2023-03-23 18:03 ` Ian Rogers
2023-03-24 20:09 ` Arnaldo Carvalho de Melo
2023-03-25 3:18 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).