* [PATCH] perf annotate: do not jump after 'k' is pressed
@ 2021-02-15 12:45 Martin Liška
2021-02-17 18:25 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Martin Liška @ 2021-02-15 12:45 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-perf-users, Arnaldo Carvalho de Melo
Do not jump when 'k' is pressed, the cursor show stay where it is.
Right now, it jumps to the currently selected hot instruction.
Signed-off-by: Martin Liška <mliska@suse.cz>
---
tools/perf/ui/browsers/annotate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index bd77825fd5a1..35b82caf8090 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -759,7 +759,7 @@ static int annotate_browser__run(struct annotate_browser *browser,
continue;
case 'k':
notes->options->show_linenr = !notes->options->show_linenr;
- break;
+ continue;
case 'H':
nd = browser->curr_hot;
break;
--
2.30.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf annotate: do not jump after 'k' is pressed
2021-02-15 12:45 [PATCH] perf annotate: do not jump after 'k' is pressed Martin Liška
@ 2021-02-17 18:25 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-02-17 18:25 UTC (permalink / raw)
To: Martin Liška; +Cc: linux-kernel, linux-perf-users
Em Mon, Feb 15, 2021 at 01:45:25PM +0100, Martin Liška escreveu:
> Do not jump when 'k' is pressed, the cursor show stay where it is.
> Right now, it jumps to the currently selected hot instruction.
Thanks, applied.
- Arnaldo
> Signed-off-by: Martin Liška <mliska@suse.cz>
> ---
> tools/perf/ui/browsers/annotate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
> index bd77825fd5a1..35b82caf8090 100644
> --- a/tools/perf/ui/browsers/annotate.c
> +++ b/tools/perf/ui/browsers/annotate.c
> @@ -759,7 +759,7 @@ static int annotate_browser__run(struct annotate_browser *browser,
> continue;
> case 'k':
> notes->options->show_linenr = !notes->options->show_linenr;
> - break;
> + continue;
> case 'H':
> nd = browser->curr_hot;
> break;
> --
> 2.30.0
>
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-17 18:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15 12:45 [PATCH] perf annotate: do not jump after 'k' is pressed Martin Liška
2021-02-17 18:25 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).