linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Michael Petlan <mpetlan@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
	acme@redhat.com, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf: enable libtraceevent dynamic linking
Date: Fri, 30 Apr 2021 10:28:45 -0300	[thread overview]
Message-ID: <YIwGDanvkoovICay@kernel.org> (raw)
In-Reply-To: <alpine.LRH.2.20.2104301450540.10640@Diego>

Em Fri, Apr 30, 2021 at 02:59:00PM +0200, Michael Petlan escreveu:
> On Wed, 28 Apr 2021, Jiri Olsa wrote:
> > On Wed, Apr 28, 2021 at 11:20:23AM +0200, Michael Petlan wrote:
> > 
> > SNIP
> > 
> > >  unexport LC_ALL
> > > @@ -309,7 +311,6 @@ endif
> > >  
> > >  LIBTRACEEVENT = $(TE_PATH)libtraceevent.a
> > >  export LIBTRACEEVENT
> > > -
> > >  LIBTRACEEVENT_DYNAMIC_LIST = $(PLUGINS_PATH)libtraceevent-dynamic-list
> > >  
> > >  #
> > > @@ -374,12 +375,15 @@ endif
> > >  
> > >  export PERL_PATH
> > >  
> > > -PERFLIBS = $(LIBAPI) $(LIBTRACEEVENT) $(LIBSUBCMD) $(LIBPERF)
> > > +PERFLIBS = $(LIBAPI) $(LIBSUBCMD) $(LIBPERF)
> > >  ifndef NO_LIBBPF
> > >    ifndef LIBBPF_DYNAMIC
> > >      PERFLIBS += $(LIBBPF)
> > >    endif
> > >  endif
> > > +ifndef LIBTRACEEVENT_DYNAMIC
> > > +  PERFLIBS += $(LIBTRACEEVENT)
> > > +endif
> > 
> > there's also install-traceevent-plugins target called during install,
> > which should be skipped for LIBTRACEEVENT_DYNAMIC 
> 
> Oh, didn't notice that. Thanks.
> 
> However, it seems that's not all what we miss in the patch.
> Seems that libtraceevent-dynamic-list should be also taken
> from external libtraceevent, when linked dynamically, shouldn't
> it.

Please send patches on top of what you already sent, that I have already
merged and sent upstream, since it is opt-in.

- Arnaldo

  reply	other threads:[~2021-04-30 13:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28  9:20 [PATCH] perf: enable libtraceevent dynamic linking Michael Petlan
2021-04-28 16:29 ` Jiri Olsa
2021-04-30 12:59   ` Michael Petlan
2021-04-30 13:28     ` Arnaldo Carvalho de Melo [this message]
2021-04-30 13:53       ` Michael Petlan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIwGDanvkoovICay@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mpetlan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).