Re: [PATCH] perf: enable libtraceevent dynamic linking

[Michael Petlan <mpetlan@redhat.com>]

On Fri, 30 Apr 2021, Arnaldo Carvalho de Melo wrote:
> Em Fri, Apr 30, 2021 at 02:59:00PM +0200, Michael Petlan escreveu:
> > On Wed, 28 Apr 2021, Jiri Olsa wrote:
> > > On Wed, Apr 28, 2021 at 11:20:23AM +0200, Michael Petlan wrote:
> > > 
> > > SNIP
> > > 
> > > >  unexport LC_ALL
> > > > @@ -309,7 +311,6 @@ endif
> > > >  
> > > >  LIBTRACEEVENT = $(TE_PATH)libtraceevent.a
> > > >  export LIBTRACEEVENT
> > > > -
> > > >  LIBTRACEEVENT_DYNAMIC_LIST = $(PLUGINS_PATH)libtraceevent-dynamic-list
> > > >  
> > > >  #
> > > > @@ -374,12 +375,15 @@ endif
> > > >  
> > > >  export PERL_PATH
> > > >  
> > > > -PERFLIBS = $(LIBAPI) $(LIBTRACEEVENT) $(LIBSUBCMD) $(LIBPERF)
> > > > +PERFLIBS = $(LIBAPI) $(LIBSUBCMD) $(LIBPERF)
> > > >  ifndef NO_LIBBPF
> > > >    ifndef LIBBPF_DYNAMIC
> > > >      PERFLIBS += $(LIBBPF)
> > > >    endif
> > > >  endif
> > > > +ifndef LIBTRACEEVENT_DYNAMIC
> > > > +  PERFLIBS += $(LIBTRACEEVENT)
> > > > +endif
> > > 
> > > there's also install-traceevent-plugins target called during install,
> > > which should be skipped for LIBTRACEEVENT_DYNAMIC 
> > 
> > Oh, didn't notice that. Thanks.
> > 
> > However, it seems that's not all what we miss in the patch.
> > Seems that libtraceevent-dynamic-list should be also taken
> > from external libtraceevent, when linked dynamically, shouldn't
> > it.
> 
> Please send patches on top of what you already sent, that I have already
> merged and sent upstream, since it is opt-in.

OK, this is great. I can already use the patch downstream, and polish it
later.
Thank you!

> 
> - Arnaldo
> 
>