From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Michael Petlan <mpetlan@redhat.com>,
Ian Rogers <irogers@google.com>,
nakamura.shun@fujitsu.com, linux-perf-users@vger.kernel.org
Subject: Re: [RFCv2 0/7] libperf: Add leader/group info to perf_evsel
Date: Wed, 7 Jul 2021 11:47:23 -0300 [thread overview]
Message-ID: <YOW+eyxYtPhc2hSf@kernel.org> (raw)
In-Reply-To: <20210706151704.73662-1-jolsa@kernel.org>
Em Tue, Jul 06, 2021 at 05:16:57PM +0200, Jiri Olsa escreveu:
> hi,
> moving leader/group info to libperf's perf_evsel.
>
> This was asked for by Shunsuke [1] and is on my list
> as a prereq for event parsing move to libperf.
So I'll add a:
Requested-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com>
- Arnaldo
> I still need to do more tests, but I'd like to check
> with you guys if there's any feedback on this first.
>
> Also available in:
> git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> libperf/groups
>
> v2 change:
> - repost due to smtp failures, no changes
>
> thanks,
> jirka
>
>
> [1] https://lore.kernel.org/linux-perf-users/OSBPR01MB46005B38568E90509946ECA9F7319@OSBPR01MB4600.jpnprd01.prod.outlook.com/
>
>
> ---
> Jiri Olsa (7):
> libperf: Change tests to single static and shared binaries
> libperf: Move idx to perf_evsel::idx
> libperf: Move leader to perf_evsel::leader
> libperf: Move nr_groups to evlist::nr_groups
> libperf: Add perf_evlist__set_leader function
> libperF: Add group support to perf_evsel__open
> libperf: Add tests for perf_evlist__set_leader function
>
> tools/lib/perf/Build | 2 ++
> tools/lib/perf/Makefile | 30 +++++++++++++++++++++++++-----
> tools/lib/perf/evlist.c | 22 ++++++++++++++++++++++
> tools/lib/perf/evsel.c | 33 +++++++++++++++++++++++++++++----
> tools/lib/perf/include/internal/evlist.h | 2 ++
> tools/lib/perf/include/internal/evsel.h | 5 ++++-
> tools/lib/perf/include/internal/tests.h | 4 ++--
> tools/lib/perf/include/perf/evlist.h | 1 +
> tools/lib/perf/libperf.map | 1 +
> tools/lib/perf/tests/Build | 5 +++++
> tools/lib/perf/tests/Makefile | 40 ----------------------------------------
> tools/lib/perf/tests/main.c | 15 +++++++++++++++
> tools/lib/perf/tests/test-cpumap.c | 3 ++-
> tools/lib/perf/tests/test-evlist.c | 30 +++++++++++++++++++++++-------
> tools/lib/perf/tests/test-evsel.c | 3 ++-
> tools/lib/perf/tests/test-threadmap.c | 3 ++-
> tools/lib/perf/tests/tests.h | 10 ++++++++++
> tools/perf/arch/x86/util/iostat.c | 4 ++--
> tools/perf/builtin-diff.c | 4 ++--
> tools/perf/builtin-record.c | 4 ++--
> tools/perf/builtin-report.c | 8 ++++----
> tools/perf/builtin-script.c | 9 +++++----
> tools/perf/builtin-stat.c | 12 ++++++------
> tools/perf/builtin-top.c | 10 +++++-----
> tools/perf/tests/bpf.c | 2 +-
> tools/perf/tests/evsel-roundtrip-name.c | 6 +++---
> tools/perf/tests/mmap-basic.c | 8 ++++----
> tools/perf/tests/parse-events.c | 74 +++++++++++++++++++++++++++++++++++++-------------------------------------
> tools/perf/tests/pfm.c | 4 ++--
> tools/perf/ui/browsers/annotate.c | 2 +-
> tools/perf/util/annotate.c | 8 ++++----
> tools/perf/util/auxtrace.c | 12 ++++++------
> tools/perf/util/cgroup.c | 2 +-
> tools/perf/util/evlist.c | 44 +++++++++++++-------------------------------
> tools/perf/util/evlist.h | 2 --
> tools/perf/util/evsel.c | 32 +++++++++++++++++++++++++-------
> tools/perf/util/evsel.h | 14 ++++++++------
> tools/perf/util/header.c | 18 +++++++++---------
> tools/perf/util/metricgroup.c | 22 +++++++++++-----------
> tools/perf/util/parse-events.c | 8 ++++----
> tools/perf/util/pfm.c | 2 +-
> tools/perf/util/python.c | 2 +-
> tools/perf/util/record.c | 6 +++---
> tools/perf/util/stat-shadow.c | 2 +-
> tools/perf/util/stat.c | 2 +-
> tools/perf/util/stream.c | 2 +-
> 46 files changed, 310 insertions(+), 224 deletions(-)
> create mode 100644 tools/lib/perf/tests/Build
> delete mode 100644 tools/lib/perf/tests/Makefile
> create mode 100644 tools/lib/perf/tests/main.c
> create mode 100644 tools/lib/perf/tests/tests.h
>
--
- Arnaldo
next prev parent reply other threads:[~2021-07-07 14:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 15:16 [RFCv2 0/7] libperf: Add leader/group info to perf_evsel Jiri Olsa
2021-07-06 15:16 ` [PATCH 1/7] libperf: Change tests to single static and shared binaries Jiri Olsa
2021-07-06 15:16 ` [PATCH 2/7] libperf: Move idx to perf_evsel::idx Jiri Olsa
2021-07-07 14:45 ` Arnaldo Carvalho de Melo
2021-07-07 18:17 ` Jiri Olsa
2021-07-07 18:36 ` Arnaldo Carvalho de Melo
2021-07-07 14:49 ` Arnaldo Carvalho de Melo
2021-07-07 17:48 ` Arnaldo Carvalho de Melo
2021-07-07 18:18 ` Jiri Olsa
2021-07-07 18:17 ` Jiri Olsa
2021-07-06 15:17 ` [PATCH 3/7] libperf: Move leader to perf_evsel::leader Jiri Olsa
2021-07-07 14:53 ` Arnaldo Carvalho de Melo
2021-07-07 18:14 ` Jiri Olsa
2021-07-07 18:34 ` Arnaldo Carvalho de Melo
2021-07-06 15:17 ` [PATCH 4/7] libperf: Move nr_groups to evlist::nr_groups Jiri Olsa
2021-07-06 15:17 ` [PATCH 5/7] libperf: Add perf_evlist__set_leader function Jiri Olsa
2021-07-06 15:17 ` [PATCH 6/7] libperF: Add group support to perf_evsel__open Jiri Olsa
2021-07-07 17:43 ` Arnaldo Carvalho de Melo
2021-07-07 18:15 ` Jiri Olsa
2021-07-09 17:57 ` [PATCH] libperf: Remove BUG_ON() from library code in get_group_fd(). was " Arnaldo Carvalho de Melo
2021-07-06 15:17 ` [PATCH 7/7] libperf: Add tests for perf_evlist__set_leader function Jiri Olsa
2021-07-09 17:59 ` Arnaldo Carvalho de Melo
2021-07-07 14:47 ` Arnaldo Carvalho de Melo [this message]
2021-07-07 18:20 ` [RFCv2 0/7] libperf: Add leader/group info to perf_evsel Jiri Olsa
2021-07-07 18:37 ` Arnaldo Carvalho de Melo
2021-07-09 8:32 ` nakamura.shun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOW+eyxYtPhc2hSf@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=nakamura.shun@fujitsu.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).