[PATCH] perf: Fix perf-record manual typo

[PATCH] perf: Fix perf-record manual typo

[Kevin Grigorenko]

From: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
Date: Wed, 22 Dec 2021 13:21:44 -0800
Subject: [PATCH] perf: Fix perf-record manual typo

Signed-off-by: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
---
 tools/perf/Documentation/perf-record.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Documentation/perf-record.txt 
b/tools/perf/Documentation/perf-record.txt
index 3cf7bac67239..52f98d53a97e 100644
--- a/tools/perf/Documentation/perf-record.txt
+++ b/tools/perf/Documentation/perf-record.txt
@@ -258,7 +258,7 @@ OPTIONS
        Call Frame Information) or "lbr" (Hardware Last Branch Record
        facility).
 
-       In some systems, where binaries are build with gcc
+       In some systems, where binaries are built with gcc
        --fomit-frame-pointer, using the "fp" method will produce bogus
        call graphs, using "dwarf", if available (perf tools linked to
        the libunwind or libdw library) should be used instead.
-- 
2.33.0

Re: [PATCH] perf: Fix perf-record manual typo

[Ian Rogers]

On Wed, Dec 22, 2021 at 1:34 PM Kevin Grigorenko
<kevin.grigorenko@us.ibm.com> wrote:
>
> From: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
> Date: Wed, 22 Dec 2021 13:21:44 -0800
> Subject: [PATCH] perf: Fix perf-record manual typo
>
> Signed-off-by: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/Documentation/perf-record.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Documentation/perf-record.txt
> b/tools/perf/Documentation/perf-record.txt
> index 3cf7bac67239..52f98d53a97e 100644
> --- a/tools/perf/Documentation/perf-record.txt
> +++ b/tools/perf/Documentation/perf-record.txt
> @@ -258,7 +258,7 @@ OPTIONS
>         Call Frame Information) or "lbr" (Hardware Last Branch Record
>         facility).
>
> -       In some systems, where binaries are build with gcc
> +       In some systems, where binaries are built with gcc
>         --fomit-frame-pointer, using the "fp" method will produce bogus
>         call graphs, using "dwarf", if available (perf tools linked to
>         the libunwind or libdw library) should be used instead.
> --
> 2.33.0
>
>

Re: [PATCH] perf: Fix perf-record manual typo

[Arnaldo Carvalho de Melo]

Em Wed, Dec 22, 2021 at 02:33:20PM -0700, Kevin Grigorenko escreveu:
> From: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
> Date: Wed, 22 Dec 2021 13:21:44 -0800
> Subject: [PATCH] perf: Fix perf-record manual typo
> 
> Signed-off-by: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
> ---
>  tools/perf/Documentation/perf-record.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Documentation/perf-record.txt 
> b/tools/perf/Documentation/perf-record.txt
> index 3cf7bac67239..52f98d53a97e 100644
> --- a/tools/perf/Documentation/perf-record.txt
> +++ b/tools/perf/Documentation/perf-record.txt
> @@ -258,7 +258,7 @@ OPTIONS
>         Call Frame Information) or "lbr" (Hardware Last Branch Record
>         facility).
>  
> -       In some systems, where binaries are build with gcc
> +       In some systems, where binaries are built with gcc
>         --fomit-frame-pointer, using the "fp" method will produce bogus
>         call graphs, using "dwarf", if available (perf tools linked to
>         the libunwind or libdw library) should be used instead.

Can you please check this works with what is in acme/perf/core?

⬢[acme@toolbox perf]$ git checkout perf/core
Switched to branch 'perf/core'
⬢[acme@toolbox perf]$ am
Applying: perf: Fix perf-record manual typo
error: git diff header lacks filename information when removing 1 leading pathname component (line 6)
Patch failed at 0001 perf: Fix perf-record manual typo
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
⬢[acme@toolbox perf]$ git am --abort
⬢[acme@toolbox perf]$ git diff
⬢[acme@toolbox perf]$ patch -p1 < ~/wb/1.patch
patching file tools/perf/Documentation/perf-record.txt
Hunk #1 FAILED at 258.
1 out of 1 hunk FAILED -- saving rejects to file tools/perf/Documentation/perf-record.txt.rej
⬢[acme@toolbox perf]$