linux-phy.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] phy: xilinx: phy-zynqmp: mention SGMII as supported protocol
@ 2023-03-24 12:24 Radhey Shyam Pandey
  2023-03-24 20:44 ` Laurent Pinchart
  0 siblings, 1 reply; 2+ messages in thread
From: Radhey Shyam Pandey @ 2023-03-24 12:24 UTC (permalink / raw)
  To: laurent.pinchart, vkoul, kishon, michal.simek
  Cc: linux-kernel, linux-phy, linux-arm-kernel, git, Radhey Shyam Pandey

SGMII is validated on kria KR260 robotics starter kit. So modify the
comment description to include it in supported controllers list.

Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
---
 drivers/phy/xilinx/phy-zynqmp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c
index 9be9535ad7ab..ebe5ba730234 100644
--- a/drivers/phy/xilinx/phy-zynqmp.c
+++ b/drivers/phy/xilinx/phy-zynqmp.c
@@ -8,9 +8,9 @@
  * Author: Subbaraya Sundeep <sundeep.lkml@gmail.com>
  * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
  *
- * This driver is tested for USB, SATA and Display Port currently.
- * Other controllers PCIe and SGMII should also work but that is
- * experimental as of now.
+ * This driver is tested for USB, SGMII, SATA and Display Port currently.
+ * Other controller i.e PCIe should also work but that is experimental
+ * as of now.
  */
 
 #include <linux/clk.h>
-- 
2.25.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] phy: xilinx: phy-zynqmp: mention SGMII as supported protocol
  2023-03-24 12:24 [PATCH] phy: xilinx: phy-zynqmp: mention SGMII as supported protocol Radhey Shyam Pandey
@ 2023-03-24 20:44 ` Laurent Pinchart
  0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2023-03-24 20:44 UTC (permalink / raw)
  To: Radhey Shyam Pandey
  Cc: vkoul, kishon, michal.simek, linux-kernel, linux-phy,
	linux-arm-kernel, git

Hi Radhey,

Thank you for the patch.

On Fri, Mar 24, 2023 at 05:54:39PM +0530, Radhey Shyam Pandey wrote:
> SGMII is validated on kria KR260 robotics starter kit. So modify the
> comment description to include it in supported controllers list.
> 
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
>  drivers/phy/xilinx/phy-zynqmp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c
> index 9be9535ad7ab..ebe5ba730234 100644
> --- a/drivers/phy/xilinx/phy-zynqmp.c
> +++ b/drivers/phy/xilinx/phy-zynqmp.c
> @@ -8,9 +8,9 @@
>   * Author: Subbaraya Sundeep <sundeep.lkml@gmail.com>
>   * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>   *
> - * This driver is tested for USB, SATA and Display Port currently.
> - * Other controllers PCIe and SGMII should also work but that is
> - * experimental as of now.
> + * This driver is tested for USB, SGMII, SATA and Display Port currently.
> + * Other controller i.e PCIe should also work but that is experimental

As only PCIe is left, I'd write

 * PCIe should also work but that is experimental as of now.

With that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Of course it would be even better if you could test PCIe ;-)

> + * as of now.
>   */
>  
>  #include <linux/clk.h>

-- 
Regards,

Laurent Pinchart

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-24 20:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-24 12:24 [PATCH] phy: xilinx: phy-zynqmp: mention SGMII as supported protocol Radhey Shyam Pandey
2023-03-24 20:44 ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).