* [PATCH] phy: rockchip: remove unused hw_to_inno function
@ 2023-03-24 13:26 Tom Rix
2023-04-07 17:41 ` Nick Desaulniers
2023-04-12 16:17 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-03-24 13:26 UTC (permalink / raw)
To: vkoul, kishon, heiko, nathan, ndesaulniers
Cc: linux-phy, linux-arm-kernel, linux-rockchip, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c:284:36: error:
unused function 'hw_to_inno' [-Werror,-Wunused-function]
static inline struct inno_dsidphy *hw_to_inno(struct clk_hw *hw)
^
This function is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
index 726928ff1273..401b0aabb159 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
@@ -281,11 +281,6 @@ struct inno_mipi_dphy_timing inno_mipi_dphy_timing_table_max_2_5ghz[] = {
{2500000000, 0x15, 0x54, 0x7f, 0x15, 0x6a},
};
-static inline struct inno_dsidphy *hw_to_inno(struct clk_hw *hw)
-{
- return container_of(hw, struct inno_dsidphy, pll.hw);
-}
-
static void phy_update_bits(struct inno_dsidphy *inno,
u8 first, u8 second, u8 mask, u8 val)
{
--
2.27.0
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: rockchip: remove unused hw_to_inno function
2023-03-24 13:26 [PATCH] phy: rockchip: remove unused hw_to_inno function Tom Rix
@ 2023-04-07 17:41 ` Nick Desaulniers
2023-04-12 16:17 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Nick Desaulniers @ 2023-04-07 17:41 UTC (permalink / raw)
To: Tom Rix
Cc: vkoul, kishon, heiko, nathan, linux-phy, linux-arm-kernel,
linux-rockchip, linux-kernel, llvm
On Fri, Mar 24, 2023 at 6:27 AM Tom Rix <trix@redhat.com> wrote:
>
> clang with W=1 reports
> drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c:284:36: error:
> unused function 'hw_to_inno' [-Werror,-Wunused-function]
> static inline struct inno_dsidphy *hw_to_inno(struct clk_hw *hw)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
> index 726928ff1273..401b0aabb159 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
> @@ -281,11 +281,6 @@ struct inno_mipi_dphy_timing inno_mipi_dphy_timing_table_max_2_5ghz[] = {
> {2500000000, 0x15, 0x54, 0x7f, 0x15, 0x6a},
> };
>
> -static inline struct inno_dsidphy *hw_to_inno(struct clk_hw *hw)
> -{
> - return container_of(hw, struct inno_dsidphy, pll.hw);
> -}
> -
> static void phy_update_bits(struct inno_dsidphy *inno,
> u8 first, u8 second, u8 mask, u8 val)
> {
> --
> 2.27.0
>
--
Thanks,
~Nick Desaulniers
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: rockchip: remove unused hw_to_inno function
2023-03-24 13:26 [PATCH] phy: rockchip: remove unused hw_to_inno function Tom Rix
2023-04-07 17:41 ` Nick Desaulniers
@ 2023-04-12 16:17 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-04-12 16:17 UTC (permalink / raw)
To: Tom Rix
Cc: kishon, heiko, nathan, ndesaulniers, linux-phy, linux-arm-kernel,
linux-rockchip, linux-kernel, llvm
On 24-03-23, 09:26, Tom Rix wrote:
> clang with W=1 reports
> drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c:284:36: error:
> unused function 'hw_to_inno' [-Werror,-Wunused-function]
> static inline struct inno_dsidphy *hw_to_inno(struct clk_hw *hw)
Applied, thanks
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-12 16:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-24 13:26 [PATCH] phy: rockchip: remove unused hw_to_inno function Tom Rix
2023-04-07 17:41 ` Nick Desaulniers
2023-04-12 16:17 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).