From: Artem Bityutskiy <dedekind1@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: x86@kernel.org, Linux PM Mailing List <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 3/3] intel_idle: add C0.2 state for Sapphire Rapids Xeon
Date: Thu, 09 Mar 2023 10:01:57 +0200 [thread overview]
Message-ID: <12e008c7fd280c8abc45f417f64bb782485a40b8.camel@gmail.com> (raw)
In-Reply-To: <20230308123222.GF2017917@hirez.programming.kicks-ass.net>
On Wed, 2023-03-08 at 13:32 +0100, Peter Zijlstra wrote:
> > Well, it would be kind of nice to say that this is related to commit
> > 6d9c7f51b1d9 ("cpuidle, intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE
> > *again*") that is present in 6.3-rc1.
>
> Right, but he said the patches were based on -next, which would've had
> that commit for a fair while too.
I can see what is the problem from the above mentioned commit. But I struggle to
reproduce it. I tried 'make W=1', and 'tools/objtool/objtool -n vmlinux.o'. I
have 'CONFIG_HAVE_NOINSTR_VALIDATION' too.
I also tries this:
1. Build kernel with this patch-set
2. tools/objtool/objtool -n vmlinux.o > ~/tmp/before.txt 2>&1
3. Make clean; Build kernel with a fix (local_irq_disable() ->
raw_local_irq_disable())
4. tools/objtool/objtool -n vmlinux.o > ~/tmp/after.txt 2>&1
5. diff -u ~/tmp/before.txt ~/tmp/after.txt
And no difference.
Could you please help by giving a hint how to verify?
next prev parent reply other threads:[~2023-03-09 8:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 12:34 [PATCH 0/3] Sapphire Rapids C0.x idle states support Artem Bityutskiy
2023-03-06 12:34 ` [PATCH 1/3] x86/mwait: Add support for idle via umwait Artem Bityutskiy
2023-03-06 14:55 ` Peter Zijlstra
2023-03-07 11:55 ` Rafael J. Wysocki
2023-03-08 12:35 ` Peter Zijlstra
2023-03-06 12:34 ` [PATCH 2/3] x86/umwait: Increase tpause and umwait quanta Artem Bityutskiy
2023-03-06 12:34 ` [PATCH 3/3] intel_idle: add C0.2 state for Sapphire Rapids Xeon Artem Bityutskiy
2023-03-06 15:32 ` Peter Zijlstra
2023-03-07 12:39 ` Rafael J. Wysocki
2023-03-08 12:32 ` Peter Zijlstra
2023-03-09 8:01 ` Artem Bityutskiy [this message]
2023-03-14 12:24 ` Peter Zijlstra
2023-03-17 8:42 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12e008c7fd280c8abc45f417f64bb782485a40b8.camel@gmail.com \
--to=dedekind1@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).