From: Peter Zijlstra <peterz@infradead.org>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: x86@kernel.org, Linux PM Mailing List <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 3/3] intel_idle: add C0.2 state for Sapphire Rapids Xeon
Date: Mon, 6 Mar 2023 16:32:15 +0100 [thread overview]
Message-ID: <20230306153215.GG1267364@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230306123418.720679-4-dedekind1@gmail.com>
On Mon, Mar 06, 2023 at 02:34:18PM +0200, Artem Bityutskiy wrote:
> @@ -225,6 +229,27 @@ static __cpuidle int intel_idle_s2idle(struct cpuidle_device *dev,
> return 0;
> }
>
> +/**
> + * intel_idle_umwait_irq - Request C0.x using the 'umwait' instruction.
> + * @dev: cpuidle device of the target CPU.
> + * @drv: cpuidle driver (assumed to point to intel_idle_driver).
> + * @index: Target idle state index.
> + *
> + * Request C0.1 or C0.2 using 'umwait' instruction with interrupts enabled.
> + */
> +static __cpuidle int intel_idle_umwait_irq(struct cpuidle_device *dev,
> + struct cpuidle_driver *drv,
> + int index)
> +{
> + u32 state = flg2MWAIT(drv->states[index].flags);
> +
> + raw_local_irq_enable();
> + umwait_idle(rdtsc() + umwait_limit, state);
> + local_irq_disable();
> +
> + return index;
> +}
Bad copy paste job there...
vmlinux.o: warning: objtool: intel_idle_umwait_irq+0x8c: call to trace_hardirqs_off() leaves .noinstr.text section
next prev parent reply other threads:[~2023-03-06 15:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 12:34 [PATCH 0/3] Sapphire Rapids C0.x idle states support Artem Bityutskiy
2023-03-06 12:34 ` [PATCH 1/3] x86/mwait: Add support for idle via umwait Artem Bityutskiy
2023-03-06 14:55 ` Peter Zijlstra
2023-03-07 11:55 ` Rafael J. Wysocki
2023-03-08 12:35 ` Peter Zijlstra
2023-03-06 12:34 ` [PATCH 2/3] x86/umwait: Increase tpause and umwait quanta Artem Bityutskiy
2023-03-06 12:34 ` [PATCH 3/3] intel_idle: add C0.2 state for Sapphire Rapids Xeon Artem Bityutskiy
2023-03-06 15:32 ` Peter Zijlstra [this message]
2023-03-07 12:39 ` Rafael J. Wysocki
2023-03-08 12:32 ` Peter Zijlstra
2023-03-09 8:01 ` Artem Bityutskiy
2023-03-14 12:24 ` Peter Zijlstra
2023-03-17 8:42 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306153215.GG1267364@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dedekind1@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).