From: Navneet Kumar <navneetk@nvidia.com>
To: rui.zhang@intel.com, edubezval@gmail.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
navneet kumar <navneetk@nvidia.com>
Subject: [PATCH 3/3] thermal: of: notify sensor driver on trip updates
Date: Wed, 26 Nov 2014 17:16:29 -0800 [thread overview]
Message-ID: <1417050989-25405-3-git-send-email-navneetk@nvidia.com> (raw)
In-Reply-To: <1417050989-25405-1-git-send-email-navneetk@nvidia.com>
From: navneet kumar <navneetk@nvidia.com>
some thermal sensor hardwares include logic which
can raise interrupts at certain programmed temperature
thresholds.
Drivers for such sensors should be able to learn the
appropriate threshold temperatures for interrupts by querying
the thermal framework.
This change provides a mechanism to allow a sensor driver to
update it's thresholds when userspace changes a trip point
temperature.
While this behavior may not make sense in thermal zones
with more than one sensor, no such examples exist in
the kernel.
Signed-off-by: navneet kumar <navneetk@nvidia.com>
---
drivers/thermal/of-thermal.c | 7 +++++++
include/linux/thermal.h | 1 +
2 files changed, 8 insertions(+)
diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
index 3d47a0cf3825..3568e4a586dc 100644
--- a/drivers/thermal/of-thermal.c
+++ b/drivers/thermal/of-thermal.c
@@ -258,6 +258,9 @@ static int of_thermal_set_trip_temp(struct thermal_zone_device *tz, int trip,
/* thermal framework should take care of data->mask & (1 << trip) */
data->trips[trip].temperature = temp;
+ if (data->sops.trip_update)
+ data->sops.trip_update(data->sensor_data, trip);
+
return 0;
}
@@ -285,6 +288,9 @@ static int of_thermal_set_trip_hyst(struct thermal_zone_device *tz, int trip,
/* thermal framework should take care of data->mask & (1 << trip) */
data->trips[trip].hysteresis = hyst;
+ if (data->sops.trip_update)
+ data->sops.trip_update(data->sensor_data, trip);
+
return 0;
}
@@ -500,6 +506,7 @@ void thermal_zone_of_sensor_unregister(struct device *dev,
tz->sops.get_temp = NULL;
tz->sops.get_trend = NULL;
+ tz->sops.trip_update = NULL;
tz->sensor_data = NULL;
mutex_unlock(&tzd->lock);
}
diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index 58341c56a01f..b93e65815175 100644
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -292,6 +292,7 @@ struct thermal_genl_event {
struct thermal_of_sensor_ops {
int (*get_temp)(void *, long *);
int (*get_trend)(void *, long *);
+ int (*trip_update)(void *, int);
};
/* Function declarations */
--
1.8.1.5
next prev parent reply other threads:[~2014-11-27 1:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 1:16 [PATCH 1/3] thermal: of: support writable trips via dt Navneet Kumar
2014-11-27 1:16 ` [PATCH 2/3] thermal: of: consolidate sensor callbacks as ops Navneet Kumar
2014-11-27 14:28 ` Eduardo Valentin
2014-12-01 19:29 ` navneet kumar
2014-11-27 1:16 ` Navneet Kumar [this message]
2014-11-27 14:32 ` [PATCH 3/3] thermal: of: notify sensor driver on trip updates Eduardo Valentin
2014-12-01 20:45 ` navneet kumar
2014-12-01 21:23 ` Eduardo Valentin
2014-12-01 22:35 ` navneet kumar
2014-11-27 14:21 ` [PATCH 1/3] thermal: of: support writable trips via dt Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417050989-25405-3-git-send-email-navneetk@nvidia.com \
--to=navneetk@nvidia.com \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).