* [PATCH] thermal: mediatek: Fix missing selection
@ 2020-07-30 8:05 Henry Yen
2020-07-31 9:59 ` Daniel Lezcano
0 siblings, 1 reply; 2+ messages in thread
From: Henry Yen @ 2020-07-30 8:05 UTC (permalink / raw)
To: Zhang Rui, Daniel Lezcano, Amit Kucheria, Matthias Brugger
Cc: linux-pm, linux-arm-kernel, linux-mediatek, linux-kernel,
Steven Liu, Henry Yen, Michael Kao
Mediatek thermal driver is compatible with multiple platforms.
Some of the platforms (e.g., MT2701) requires to enable
MEDIATEK_MT6577_AUXADC option. If lacks the config, the driver
will not be able to read correct temperature.
To fix it, select missing MEDIATEK_MT6577_AUXADC config.
Signed-off-by: Henry Yen <henry.yen@mediatek.com>
---
drivers/thermal/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 3eb2348e5242..3a37f674f7f3 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -409,6 +409,7 @@ config MTK_THERMAL
depends on NVMEM || NVMEM=n
depends on RESET_CONTROLLER
default y
+ select MEDIATEK_MT6577_AUXADC
help
Enable this option if you want to have support for thermal management
controller present in Mediatek SoCs
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] thermal: mediatek: Fix missing selection
2020-07-30 8:05 [PATCH] thermal: mediatek: Fix missing selection Henry Yen
@ 2020-07-31 9:59 ` Daniel Lezcano
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2020-07-31 9:59 UTC (permalink / raw)
To: Henry Yen, Zhang Rui, Amit Kucheria, Matthias Brugger
Cc: linux-pm, linux-arm-kernel, linux-mediatek, linux-kernel,
Steven Liu, Michael Kao, Arnd Bergmann
Hi Henry,
cc'ing Arnd
On 30/07/2020 10:05, Henry Yen wrote:
> Mediatek thermal driver is compatible with multiple platforms.
> Some of the platforms (e.g., MT2701) requires to enable
> MEDIATEK_MT6577_AUXADC option. If lacks the config, the driver
> will not be able to read correct temperature.
>
> To fix it, select missing MEDIATEK_MT6577_AUXADC config.
The description states there is a dependency for some platforms not all
of them.
The change will select the option every time for any mediatek platform
or compile test.
I don't think it is the place to select the option.
> Signed-off-by: Henry Yen <henry.yen@mediatek.com>
> ---
> drivers/thermal/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 3eb2348e5242..3a37f674f7f3 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -409,6 +409,7 @@ config MTK_THERMAL
> depends on NVMEM || NVMEM=n
> depends on RESET_CONTROLLER
> default y
> + select MEDIATEK_MT6577_AUXADC
> help
> Enable this option if you want to have support for thermal management
> controller present in Mediatek SoCs
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-31 9:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30 8:05 [PATCH] thermal: mediatek: Fix missing selection Henry Yen
2020-07-31 9:59 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).