From: Matthias Kaehlcke <mka@chromium.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Qais.Yousef@arm.com, juri.lelli@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 2/5] PM / QOS: Pass request type to dev_pm_qos_read_value()
Date: Tue, 11 Jun 2019 17:08:32 -0700 [thread overview]
Message-ID: <20190612000832.GJ137143@google.com> (raw)
In-Reply-To: <b414d788faf4c6f87d01086248db4d2e86635180.1560163748.git.viresh.kumar@linaro.org>
On Mon, Jun 10, 2019 at 04:21:33PM +0530, Viresh Kumar wrote:
> In order to use dev_pm_qos_read_value(), and other internal routines to
> it, to read values for different QoS requests, pass request type as a
> parameter to these routines.
nit: I find that somewhat hard to parse, a possible improvement:
"In order to allow dev_pm_qos_read_value() and other {related,similar}
internal routines to read values for different QoS requests, pass
request type as a parameter to these routines."
(I'm not a native English speaker, so I don't claim this to be
correct ;-)
> For now, it only supports resume-latency request type.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Documentation/power/pm_qos_interface.txt | 2 +-
> drivers/base/power/domain_governor.c | 4 +--
> drivers/base/power/qos.c | 10 +++---
> drivers/base/power/runtime.c | 2 +-
> drivers/cpuidle/governor.c | 2 +-
> include/linux/pm_qos.h | 41 +++++++++++++++++-------
> 6 files changed, 40 insertions(+), 21 deletions(-)
looks good to me, however I'm just a QoS n00b:
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2019-06-12 0:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 10:51 [PATCH V3 0/5] cpufreq: Use QoS layer to manage freq-constraints Viresh Kumar
2019-06-10 10:51 ` [PATCH V3 1/5] PM / QOS: Pass request type to dev_pm_qos_{add|remove}_notifier() Viresh Kumar
2019-06-11 23:45 ` Matthias Kaehlcke
2019-06-17 9:23 ` Ulf Hansson
2019-06-17 22:52 ` Rafael J. Wysocki
2019-06-10 10:51 ` [PATCH V3 2/5] PM / QOS: Pass request type to dev_pm_qos_read_value() Viresh Kumar
2019-06-12 0:08 ` Matthias Kaehlcke [this message]
2019-06-17 9:23 ` Ulf Hansson
2019-06-17 23:14 ` Rafael J. Wysocki
2019-06-10 10:51 ` [PATCH V3 3/5] PM / QoS: Add support for MIN/MAX frequency constraints Viresh Kumar
2019-06-13 0:04 ` Matthias Kaehlcke
2019-06-17 9:23 ` Ulf Hansson
2019-06-10 10:51 ` [PATCH V3 4/5] cpufreq: Register notifiers with the PM QoS framework Viresh Kumar
2019-06-14 16:46 ` Matthias Kaehlcke
2019-06-17 3:02 ` Viresh Kumar
2019-06-17 9:23 ` Ulf Hansson
2019-06-17 23:26 ` Rafael J. Wysocki
2019-06-18 11:25 ` Viresh Kumar
2019-06-18 22:23 ` Rafael J. Wysocki
2019-06-19 6:39 ` Viresh Kumar
2019-06-19 9:15 ` Rafael J. Wysocki
2019-06-17 23:37 ` Rafael J. Wysocki
2019-06-18 11:34 ` Viresh Kumar
2019-06-10 10:51 ` [PATCH V3 5/5] cpufreq: Add QoS requests for userspace constraints Viresh Kumar
2019-06-14 17:14 ` Matthias Kaehlcke
2019-06-17 3:07 ` Viresh Kumar
2019-06-17 9:23 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612000832.GJ137143@google.com \
--to=mka@chromium.org \
--cc=Qais.Yousef@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=juri.lelli@gmail.com \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).