From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>
Subject: RE: Re: [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30
Date: Tue, 25 Jun 2019 10:42:14 +0900 [thread overview]
Message-ID: <20190625014214epcms1p1b8f2d76cd8cfdf3fdf517be08a92ccdf@epcms1p1> (raw)
In-Reply-To: <7561edbc-c17c-101a-b339-fc7f9968a470@gmail.com>
Sender : Dmitry Osipenko <digetx@gmail.com>
>24.06.2019 14:11, MyungJoo Ham пишет:
>>>
>>> --------- Original Message ---------
>>> Sender : Dmitry Osipenko <digetx@gmail.com>
>>>
>>> 24.06.2019 10:34, MyungJoo Ham пишет:
>>>>>
>>>>> A question:
>>>>>
>>>>> Does this driver support Tegra20 as well?
>>>>> I'm asking this because ARCH_TEGRA includes ARCH_TEGRA_2x_SOC
>>>>> according to /drivers/soc/tegra/Kconfig.
>>>>>
>>>>
>>>> For this matter, how about updating your 13/16 patch as follows?
>>>>
>> []
>>>
>>> Good call! I'll update this patch following yours suggestion, thanks.
>>
>> Or, you may approve the modified commits here:
>> https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git/log/?h=for-next
>
>Looks almost good to me!
>
>I just recalled that there is also a 64bit variant of Tegra124, the Tegra132. Hence
>the Tegra30+ Kconfig entry should look like this (it's also worthy to break the lines
>for readability):
>
>diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
>index ccb1a68c4b51..bd2efbc27725 100644
>--- a/drivers/devfreq/Kconfig
>+++ b/drivers/devfreq/Kconfig
>@@ -94,7 +94,10 @@ config ARM_EXYNOS_BUS_DEVFREQ
>
> config ARM_TEGRA_DEVFREQ
> tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver"
>- depends on ARCH_TEGRA || COMPILE_TEST
>+ depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \
>+ ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \
>+ ARCH_TEGRA_210_SOC || \
>+ COMPILE_TEST
> select PM_OPP
> help
> This adds the DEVFREQ driver for the Tegra family of SoCs.
>
>Could you please adjust the patches like I'm suggesting? I'll approve yours change
>then and won't re-spin the first batch of the patches.
I've adjusted as you suggested. It's pushed to the git repo as well.
Cheers,
MyungJoo.
next prev parent reply other threads:[~2019-06-25 1:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p1>
2019-06-24 6:59 ` [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 MyungJoo Ham
[not found] ` <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p8>
2019-06-24 7:34 ` MyungJoo Ham
2019-06-24 10:42 ` Dmitry Osipenko
[not found] ` <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p3>
2019-06-24 11:11 ` MyungJoo Ham
2019-06-24 11:24 ` Dmitry Osipenko
2019-06-25 1:42 ` MyungJoo Ham [this message]
2019-06-25 11:30 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625014214epcms1p1b8f2d76cd8cfdf3fdf517be08a92ccdf@epcms1p1 \
--to=myungjoo.ham@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).