* Re: [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 [not found] <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p1> @ 2019-06-24 6:59 ` MyungJoo Ham [not found] ` <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p8> 2019-06-25 1:42 ` MyungJoo Ham 1 sibling, 1 reply; 7+ messages in thread From: MyungJoo Ham @ 2019-06-24 6:59 UTC (permalink / raw) To: digetx, janathanh, Chanwoo Choi; +Cc: linux-pm, linux-tegra, linux-kernel > On Thu, May 02, 2019 at 02:38:12AM +0300, Dmitry Osipenko wrote: > > The devfreq driver can be used on Tegra30 without any code change and > > it works perfectly fine, the default Tegra124 parameters are good enough > > for Tegra30. > > > > Reviewed-by: Chanwoo Choi > > Signed-off-by: Dmitry Osipenko > > --- > > drivers/devfreq/Kconfig | 4 ++-- > > drivers/devfreq/tegra-devfreq.c | 1 + > > 2 files changed, 3 insertions(+), 2 deletions(-) > > Acked-by: Thierry Reding > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > index 7dd46d4..b291803 100644 > --- a/drivers/devfreq/Kconfig > +++ b/drivers/devfreq/Kconfig > @@ -93,8 +93,8 @@ config ARM_EXYNOS_BUS_DEVFREQ > This does not yet operate with optimal voltages. > > config ARM_TEGRA_DEVFREQ > - tristate "Tegra DEVFREQ Driver" > - depends on ARCH_TEGRA_124_SOC > + tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver" > + depends on ARCH_TEGRA > select PM_OPP > help > This adds the DEVFREQ driver for the Tegra family of SoCs. A question: Does this driver support Tegra20 as well? I'm asking this because ARCH_TEGRA includes ARCH_TEGRA_2x_SOC according to /drivers/soc/tegra/Kconfig. Cheers, MyungJoo. ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p8>]
* Re: [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 [not found] ` <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p8> @ 2019-06-24 7:34 ` MyungJoo Ham 2019-06-24 10:42 ` Dmitry Osipenko [not found] ` <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p3> 0 siblings, 2 replies; 7+ messages in thread From: MyungJoo Ham @ 2019-06-24 7:34 UTC (permalink / raw) To: digetx Cc: Chanwoo Choi, linux-pm, linux-tegra, linux-kernel, jonathanh, thierry.reding > >A question: > >Does this driver support Tegra20 as well? >I'm asking this because ARCH_TEGRA includes ARCH_TEGRA_2x_SOC >according to /drivers/soc/tegra/Kconfig. > For this matter, how about updating your 13/16 patch as follows? --- drivers/devfreq/Kconfig | 4 ++-- drivers/devfreq/tegra-devfreq.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index 7dd46d44579d..78c4b436aad8 100644 --- a/drivers/devfreq/Kconfig +++ b/drivers/devfreq/Kconfig @@ -93,8 +93,8 @@ config ARM_EXYNOS_BUS_DEVFREQ This does not yet operate with optimal voltages. config ARM_TEGRA_DEVFREQ - tristate "Tegra DEVFREQ Driver" - depends on ARCH_TEGRA_124_SOC + tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver" + depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || ARCH_TEGRA_124_SOC || ARCH_TEGRA_210_SOC select PM_OPP help This adds the DEVFREQ driver for the Tegra family of SoCs. diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c index 5cddf2199c4e..a6ba75f4106d 100644 --- a/drivers/devfreq/tegra-devfreq.c +++ b/drivers/devfreq/tegra-devfreq.c @@ -726,6 +726,7 @@ static int tegra_devfreq_remove(struct platform_device *pdev) } static const struct of_device_id tegra_devfreq_of_match[] = { + { .compatible = "nvidia,tegra30-actmon" }, { .compatible = "nvidia,tegra124-actmon" }, { }, }; -- 2.17.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 2019-06-24 7:34 ` MyungJoo Ham @ 2019-06-24 10:42 ` Dmitry Osipenko [not found] ` <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p3> 1 sibling, 0 replies; 7+ messages in thread From: Dmitry Osipenko @ 2019-06-24 10:42 UTC (permalink / raw) To: myungjoo.ham Cc: Chanwoo Choi, linux-pm, linux-tegra, linux-kernel, jonathanh, thierry.reding 24.06.2019 10:34, MyungJoo Ham пишет: >> >> A question: >> >> Does this driver support Tegra20 as well? >> I'm asking this because ARCH_TEGRA includes ARCH_TEGRA_2x_SOC >> according to /drivers/soc/tegra/Kconfig. >> > > For this matter, how about updating your 13/16 patch as follows? > > --- > drivers/devfreq/Kconfig | 4 ++-- > drivers/devfreq/tegra-devfreq.c | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > index 7dd46d44579d..78c4b436aad8 100644 > --- a/drivers/devfreq/Kconfig > +++ b/drivers/devfreq/Kconfig > @@ -93,8 +93,8 @@ config ARM_EXYNOS_BUS_DEVFREQ > This does not yet operate with optimal voltages. > > config ARM_TEGRA_DEVFREQ > - tristate "Tegra DEVFREQ Driver" > - depends on ARCH_TEGRA_124_SOC > + tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver" > + depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || ARCH_TEGRA_124_SOC || ARCH_TEGRA_210_SOC > select PM_OPP > help > This adds the DEVFREQ driver for the Tegra family of SoCs. > diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c > index 5cddf2199c4e..a6ba75f4106d 100644 > --- a/drivers/devfreq/tegra-devfreq.c > +++ b/drivers/devfreq/tegra-devfreq.c > @@ -726,6 +726,7 @@ static int tegra_devfreq_remove(struct platform_device *pdev) > } > > static const struct of_device_id tegra_devfreq_of_match[] = { > + { .compatible = "nvidia,tegra30-actmon" }, > { .compatible = "nvidia,tegra124-actmon" }, > { }, > }; > Good call! I'll update this patch following yours suggestion, thanks. ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p3>]
* RE: Re: [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 [not found] ` <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p3> @ 2019-06-24 11:11 ` MyungJoo Ham 2019-06-24 11:24 ` Dmitry Osipenko 0 siblings, 1 reply; 7+ messages in thread From: MyungJoo Ham @ 2019-06-24 11:11 UTC (permalink / raw) To: Dmitry Osipenko Cc: Chanwoo Choi, linux-pm, linux-tegra, linux-kernel, jonathanh, thierry.reding > >--------- Original Message --------- >Sender : Dmitry Osipenko <digetx@gmail.com> > >24.06.2019 10:34, MyungJoo Ham пишет: >>> >>> A question: >>> >>> Does this driver support Tegra20 as well? >>> I'm asking this because ARCH_TEGRA includes ARCH_TEGRA_2x_SOC >>> according to /drivers/soc/tegra/Kconfig. >>> >> >> For this matter, how about updating your 13/16 patch as follows? >> [] > >Good call! I'll update this patch following yours suggestion, thanks. Or, you may approve the modified commits here: https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git/log/?h=for-next Cheers, MyungJoo ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 2019-06-24 11:11 ` MyungJoo Ham @ 2019-06-24 11:24 ` Dmitry Osipenko 0 siblings, 0 replies; 7+ messages in thread From: Dmitry Osipenko @ 2019-06-24 11:24 UTC (permalink / raw) To: myungjoo.ham Cc: Chanwoo Choi, linux-pm, linux-tegra, linux-kernel, jonathanh, thierry.reding 24.06.2019 14:11, MyungJoo Ham пишет: >> >> --------- Original Message --------- >> Sender : Dmitry Osipenko <digetx@gmail.com> >> >> 24.06.2019 10:34, MyungJoo Ham пишет: >>>> >>>> A question: >>>> >>>> Does this driver support Tegra20 as well? >>>> I'm asking this because ARCH_TEGRA includes ARCH_TEGRA_2x_SOC >>>> according to /drivers/soc/tegra/Kconfig. >>>> >>> >>> For this matter, how about updating your 13/16 patch as follows? >>> > [] >> >> Good call! I'll update this patch following yours suggestion, thanks. > > Or, you may approve the modified commits here: > https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git/log/?h=for-next Looks almost good to me! I just recalled that there is also a 64bit variant of Tegra124, the Tegra132. Hence the Tegra30+ Kconfig entry should look like this (it's also worthy to break the lines for readability): diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index ccb1a68c4b51..bd2efbc27725 100644 --- a/drivers/devfreq/Kconfig +++ b/drivers/devfreq/Kconfig @@ -94,7 +94,10 @@ config ARM_EXYNOS_BUS_DEVFREQ config ARM_TEGRA_DEVFREQ tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver" - depends on ARCH_TEGRA || COMPILE_TEST + depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \ + ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \ + ARCH_TEGRA_210_SOC || \ + COMPILE_TEST select PM_OPP help This adds the DEVFREQ driver for the Tegra family of SoCs. Could you please adjust the patches like I'm suggesting? I'll approve yours change then and won't re-spin the first batch of the patches. ^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: Re: [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 [not found] <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p1> 2019-06-24 6:59 ` [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 MyungJoo Ham @ 2019-06-25 1:42 ` MyungJoo Ham 2019-06-25 11:30 ` Dmitry Osipenko 1 sibling, 1 reply; 7+ messages in thread From: MyungJoo Ham @ 2019-06-25 1:42 UTC (permalink / raw) To: Dmitry Osipenko Cc: Chanwoo Choi, linux-pm, linux-tegra, linux-kernel, jonathanh, thierry.reding Sender : Dmitry Osipenko <digetx@gmail.com> >24.06.2019 14:11, MyungJoo Ham пишет: >>> >>> --------- Original Message --------- >>> Sender : Dmitry Osipenko <digetx@gmail.com> >>> >>> 24.06.2019 10:34, MyungJoo Ham пишет: >>>>> >>>>> A question: >>>>> >>>>> Does this driver support Tegra20 as well? >>>>> I'm asking this because ARCH_TEGRA includes ARCH_TEGRA_2x_SOC >>>>> according to /drivers/soc/tegra/Kconfig. >>>>> >>>> >>>> For this matter, how about updating your 13/16 patch as follows? >>>> >> [] >>> >>> Good call! I'll update this patch following yours suggestion, thanks. >> >> Or, you may approve the modified commits here: >> https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git/log/?h=for-next > >Looks almost good to me! > >I just recalled that there is also a 64bit variant of Tegra124, the Tegra132. Hence >the Tegra30+ Kconfig entry should look like this (it's also worthy to break the lines >for readability): > >diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig >index ccb1a68c4b51..bd2efbc27725 100644 >--- a/drivers/devfreq/Kconfig >+++ b/drivers/devfreq/Kconfig >@@ -94,7 +94,10 @@ config ARM_EXYNOS_BUS_DEVFREQ > > config ARM_TEGRA_DEVFREQ > tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver" >- depends on ARCH_TEGRA || COMPILE_TEST >+ depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \ >+ ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \ >+ ARCH_TEGRA_210_SOC || \ >+ COMPILE_TEST > select PM_OPP > help > This adds the DEVFREQ driver for the Tegra family of SoCs. > >Could you please adjust the patches like I'm suggesting? I'll approve yours change >then and won't re-spin the first batch of the patches. I've adjusted as you suggested. It's pushed to the git repo as well. Cheers, MyungJoo. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 2019-06-25 1:42 ` MyungJoo Ham @ 2019-06-25 11:30 ` Dmitry Osipenko 0 siblings, 0 replies; 7+ messages in thread From: Dmitry Osipenko @ 2019-06-25 11:30 UTC (permalink / raw) To: myungjoo.ham Cc: Chanwoo Choi, linux-pm, linux-tegra, linux-kernel, jonathanh, thierry.reding 25.06.2019 4:42, MyungJoo Ham пишет: > Sender : Dmitry Osipenko <digetx@gmail.com> >> 24.06.2019 14:11, MyungJoo Ham пишет: >>>> >>>> --------- Original Message --------- >>>> Sender : Dmitry Osipenko <digetx@gmail.com> >>>> >>>> 24.06.2019 10:34, MyungJoo Ham пишет: >>>>>> >>>>>> A question: >>>>>> >>>>>> Does this driver support Tegra20 as well? >>>>>> I'm asking this because ARCH_TEGRA includes ARCH_TEGRA_2x_SOC >>>>>> according to /drivers/soc/tegra/Kconfig. >>>>>> >>>>> >>>>> For this matter, how about updating your 13/16 patch as follows? >>>>> >>> [] >>>> >>>> Good call! I'll update this patch following yours suggestion, thanks. >>> >>> Or, you may approve the modified commits here: >>> https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git/log/?h=for-next >> >> Looks almost good to me! >> >> I just recalled that there is also a 64bit variant of Tegra124, the Tegra132. Hence >> the Tegra30+ Kconfig entry should look like this (it's also worthy to break the lines >> for readability): >> >> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig >> index ccb1a68c4b51..bd2efbc27725 100644 >> --- a/drivers/devfreq/Kconfig >> +++ b/drivers/devfreq/Kconfig >> @@ -94,7 +94,10 @@ config ARM_EXYNOS_BUS_DEVFREQ >> >> config ARM_TEGRA_DEVFREQ >> tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver" >> - depends on ARCH_TEGRA || COMPILE_TEST >> + depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \ >> + ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \ >> + ARCH_TEGRA_210_SOC || \ >> + COMPILE_TEST >> select PM_OPP >> help >> This adds the DEVFREQ driver for the Tegra family of SoCs. >> >> Could you please adjust the patches like I'm suggesting? I'll approve yours change >> then and won't re-spin the first batch of the patches. > > I've adjusted as you suggested. It's pushed to the git repo as well. Thank you very much, looking good now! ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-06-25 11:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p1>
2019-06-24 6:59 ` [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 MyungJoo Ham
[not found] ` <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p8>
2019-06-24 7:34 ` MyungJoo Ham
2019-06-24 10:42 ` Dmitry Osipenko
[not found] ` <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p3>
2019-06-24 11:11 ` MyungJoo Ham
2019-06-24 11:24 ` Dmitry Osipenko
2019-06-25 1:42 ` MyungJoo Ham
2019-06-25 11:30 ` Dmitry Osipenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).