Re: [PATCH v4 0/2] Use NVMEM as reboot-mode write interface

From: Sebastian Reichel <sre@kernel.org>
To: Han Nandor <nandor.han@vaisala.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 0/2] Use NVMEM as reboot-mode write interface
Date: Thu, 27 Jun 2019 20:33:30 +0200	[thread overview]
Message-ID: <20190627183330.aole6zumw3l2vyet@earth.universe> (raw)
In-Reply-To: <20190515104658.25535-1-nandor.han@vaisala.com>

[-- Attachment #1: Type: text/plain, Size: 1938 bytes --]

Hi,

On Wed, May 15, 2019 at 10:47:14AM +0000, Han Nandor wrote:
> Description
> -----------
> Extend the reboot mode driver to use a NVMEM cell as writing interface.
> 
> Testing
> -------
> The testing is done by configuring DT from a custom board.
> The NVMEM cell is configured in an RTC non-volatile memory.
> Kernel: 4.14.60 (the patchset was rebased on kernel master)
> 
> DT configurations:
> `
> ...
> reboot-mode-nvmem@0 {
>     compatible = "simple-mfd";
>     reboot-mode {
>         compatible = "nvmem-reboot-mode";
>         nvmem-cells = <&reboot_mode>;
>         nvmem-cell-names = "reboot-mode";
> 
>         mode-test       = <0x21969147>;
>     };
> };
> ...
> reboot_mode: nvmem_reboot_mode@0 {
>         reg = <0x00 0x4>;
> };
> ...
> `
> 
> 1. Reboot the system using the command `reboot test`
> 
> 2. Verify that kernel logs show that reboot was done in mode `test`:
> PASS
> `[  413.957172] reboot: Restarting system with command 'test' `
> 
> 3. Stop in U-Boot and verify that mode `test` magic value is present
> in RTCs non-volatile memory: PASS
> 
> Kernel: 5.1.0-rc3
> 
> 1. Configure `arch/arm/configs/imx_v6_v7_defconfig` to contain 
> `CONFIG_NVMEM_REBOOT_MODE=y`
> 2. Verify that Kernel compiles successful: PASS
> `
> make ARCH=arm CROSS_COMPILE=arm-linux-gnu- imx_v6_v7_defconfig zImage
> ...
> CC      drivers/power/reset/nvmem-reboot-mode.o
> ...
> Kernel: arch/arm/boot/zImage is ready
> `
> Changes since v1:
> -----------------
>  - split the documentation on a separate patch
>  - add a missing header
> 
> Changes since v2:
> ----------------
>  - change the module license to GPL since GPL v2 is deprecated
> 
> Changes since v3:
> ----------------
>  - documentation updated according to the comments

Thanks, queued. Please fix your git/mail setup, I had to fix the
line endings (\r\n -> \n) to apply this.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]