* [PATCH v2] power: reset: gpio-restart: don't error on deferral
@ 2019-10-29 20:17 Chris Packham
2019-12-19 0:16 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Chris Packham @ 2019-10-29 20:17 UTC (permalink / raw)
To: sre; +Cc: linux-pm, linux-kernel, Chris Packham
Don't generate an error message when devm_gpiod_get fails with
-EPROBE_DEFER.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
Notes:
Changes in v2:
- use PTR_ERR_OR_ZERO() to avoid excessive PTR_ERR()
drivers/power/reset/gpio-restart.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/power/reset/gpio-restart.c b/drivers/power/reset/gpio-restart.c
index 308ca9d9d276..5466eeea261c 100644
--- a/drivers/power/reset/gpio-restart.c
+++ b/drivers/power/reset/gpio-restart.c
@@ -64,9 +64,11 @@ static int gpio_restart_probe(struct platform_device *pdev)
gpio_restart->reset_gpio = devm_gpiod_get(&pdev->dev, NULL,
open_source ? GPIOD_IN : GPIOD_OUT_LOW);
- if (IS_ERR(gpio_restart->reset_gpio)) {
- dev_err(&pdev->dev, "Could not get reset GPIO\n");
- return PTR_ERR(gpio_restart->reset_gpio);
+ ret = PTR_ERR_OR_ZERO(gpio_restart->reset_gpio);
+ if (ret) {
+ if (ret != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "Could not get reset GPIO\n");
+ return ret;
}
gpio_restart->restart_handler.notifier_call = gpio_restart_notify;
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] power: reset: gpio-restart: don't error on deferral
2019-10-29 20:17 [PATCH v2] power: reset: gpio-restart: don't error on deferral Chris Packham
@ 2019-12-19 0:16 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2019-12-19 0:16 UTC (permalink / raw)
To: Chris Packham; +Cc: linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]
Hi,
On Wed, Oct 30, 2019 at 09:17:26AM +1300, Chris Packham wrote:
> Don't generate an error message when devm_gpiod_get fails with
> -EPROBE_DEFER.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
Thanks, queued to power-supply's for-next branch.
-- Sebastian
>
> Notes:
> Changes in v2:
> - use PTR_ERR_OR_ZERO() to avoid excessive PTR_ERR()
>
> drivers/power/reset/gpio-restart.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/reset/gpio-restart.c b/drivers/power/reset/gpio-restart.c
> index 308ca9d9d276..5466eeea261c 100644
> --- a/drivers/power/reset/gpio-restart.c
> +++ b/drivers/power/reset/gpio-restart.c
> @@ -64,9 +64,11 @@ static int gpio_restart_probe(struct platform_device *pdev)
>
> gpio_restart->reset_gpio = devm_gpiod_get(&pdev->dev, NULL,
> open_source ? GPIOD_IN : GPIOD_OUT_LOW);
> - if (IS_ERR(gpio_restart->reset_gpio)) {
> - dev_err(&pdev->dev, "Could not get reset GPIO\n");
> - return PTR_ERR(gpio_restart->reset_gpio);
> + ret = PTR_ERR_OR_ZERO(gpio_restart->reset_gpio);
> + if (ret) {
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Could not get reset GPIO\n");
> + return ret;
> }
>
> gpio_restart->restart_handler.notifier_call = gpio_restart_notify;
> --
> 2.23.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-19 0:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-29 20:17 [PATCH v2] power: reset: gpio-restart: don't error on deferral Chris Packham
2019-12-19 0:16 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).