* [PATCH v1 0/5] uml: add more unspecified HAS_IOMEM dependencies
@ 2020-01-27 23:53 Brendan Higgins
2020-01-27 23:53 ` [PATCH v1 5/5] power: avs: qcom-cpr: add unspecified HAS_IOMEM dependency Brendan Higgins
0 siblings, 1 reply; 2+ messages in thread
From: Brendan Higgins @ 2020-01-27 23:53 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Kevin Hilman, Nishanth Menon,
Richard Cochran, Philipp Zabel, David S . Miller, Michal Simek,
Andrew Lunn, Robert Hancock, Esben Haabendal, Thomas Gleixner,
Radhey Shyam Pandey
Cc: linux-um, linux-kernel, davidgow, heidifahim, Brendan Higgins,
Greg Kroah-Hartman, netdev, linux-arm-kernel, linux-pm
# TL;DR
This patchset adds a missing HAS_IOMEM dependency to several drivers in
an attempt to get allyesconfig closer to working for ARCH=um. Although I
had caught all the broken ones in early 5.5[1], some new ones have
broken since then.
# What am I trying to do?
This patchset is part of my attempt to get `make ARCH=um allyesconfig`
to produce a config that will build *and* boot to init, so that I can
use it as a mechanism to run tests[2].
# Why won't allyesconfig break again after this series of fixes?
Well, in short, it will break again; however, as I mentioned above, I am
using UML for testing the kernel, and I am currently working on getting
my tests to run on KernelCI. As part of our testing procedure for
KernelCI, we are planning on building a UML kernel using allyesconfig
and running our tests on it. Thus, we will find out very quickly once
someone breaks allyesconfig again once we get this all working. So this
will keep breaking until we have a build test on KernelCI running, but
we will need to send out these fixes anyway.
Brendan Higgins (5):
net: axienet: add unspecified HAS_IOMEM dependency
reset: brcmstb-rescal: add unspecified HAS_IOMEM dependency
reset: intel: add unspecified HAS_IOMEM dependency
ptp: 1588_clock_ines: add unspecified HAS_IOMEM dependency
power: avs: qcom-cpr: add unspecified HAS_IOMEM dependency
drivers/net/ethernet/xilinx/Kconfig | 1 +
drivers/power/avs/Kconfig | 2 +-
drivers/ptp/Kconfig | 1 +
drivers/reset/Kconfig | 3 ++-
4 files changed, 5 insertions(+), 2 deletions(-)
[1] https://lore.kernel.org/lkml/20191211192742.95699-1-brendanhiggins@google.com/
[2] https://bugzilla.kernel.org/show_bug.cgi?id=205223
--
2.25.0.341.g760bfbb309-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v1 5/5] power: avs: qcom-cpr: add unspecified HAS_IOMEM dependency
2020-01-27 23:53 [PATCH v1 0/5] uml: add more unspecified HAS_IOMEM dependencies Brendan Higgins
@ 2020-01-27 23:53 ` Brendan Higgins
0 siblings, 0 replies; 2+ messages in thread
From: Brendan Higgins @ 2020-01-27 23:53 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Kevin Hilman, Nishanth Menon
Cc: linux-um, linux-kernel, davidgow, heidifahim, Brendan Higgins, linux-pm
Currently CONFIG_QCOM_CPR=y implicitly depends on CONFIG_HAS_IOMEM=y;
consequently, on architectures without IOMEM we get the following build
error:
/usr/bin/ld: drivers/power/avs/qcom-cpr.o: in function `cpr_probe':
drivers/power/avs/qcom-cpr.c:1690: undefined reference to `devm_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/power/avs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/avs/Kconfig b/drivers/power/avs/Kconfig
index b8fe166cd0d9f..cdb4237bfd02e 100644
--- a/drivers/power/avs/Kconfig
+++ b/drivers/power/avs/Kconfig
@@ -14,7 +14,7 @@ menuconfig POWER_AVS
config QCOM_CPR
tristate "QCOM Core Power Reduction (CPR) support"
- depends on POWER_AVS
+ depends on POWER_AVS && HAS_IOMEM
select PM_OPP
select REGMAP
help
--
2.25.0.341.g760bfbb309-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-27 23:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-27 23:53 [PATCH v1 0/5] uml: add more unspecified HAS_IOMEM dependencies Brendan Higgins
2020-01-27 23:53 ` [PATCH v1 5/5] power: avs: qcom-cpr: add unspecified HAS_IOMEM dependency Brendan Higgins
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).