linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-pm@vger.kernel.org
Subject: Re: [PATCH] power: twl4030: Use scnprintf() for avoiding potential buffer overflow
Date: Wed, 11 Mar 2020 23:23:07 +0100	[thread overview]
Message-ID: <20200311222307.bmj7e5fzxmhfvzp5@jupiter.universe> (raw)
In-Reply-To: <20200311090818.20797-1-tiwai@suse.de>

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

Hi,

On Wed, Mar 11, 2020 at 10:08:18AM +0100, Takashi Iwai wrote:
> Since snprintf() returns the would-be-output size instead of the
> actual output size, the succeeding calls may go beyond the given
> buffer limit.  Fix it by replacing with scnprintf().
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/twl4030_charger.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/supply/twl4030_charger.c
> index 648ab80288c9..1bc49b2e12e8 100644
> --- a/drivers/power/supply/twl4030_charger.c
> +++ b/drivers/power/supply/twl4030_charger.c
> @@ -726,10 +726,10 @@ twl4030_bci_mode_show(struct device *dev,
>  
>  	for (i = 0; i < ARRAY_SIZE(modes); i++)
>  		if (mode == i)
> -			len += snprintf(buf+len, PAGE_SIZE-len,
> +			len += scnprintf(buf+len, PAGE_SIZE-len,
>  					"[%s] ", modes[i]);
>  		else
> -			len += snprintf(buf+len, PAGE_SIZE-len,
> +			len += scnprintf(buf+len, PAGE_SIZE-len,
>  					"%s ", modes[i]);
>  	buf[len-1] = '\n';
>  	return len;
> -- 
> 2.16.4
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2020-03-11 22:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11  9:08 [PATCH] power: twl4030: Use scnprintf() for avoiding potential buffer overflow Takashi Iwai
2020-03-11 22:23 ` Sebastian Reichel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200311222307.bmj7e5fzxmhfvzp5@jupiter.universe \
    --to=sre@kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).