* [PATCH] power: twl4030: Use scnprintf() for avoiding potential buffer overflow
@ 2020-03-11 9:08 Takashi Iwai
2020-03-11 22:23 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Iwai @ 2020-03-11 9:08 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: linux-pm
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit. Fix it by replacing with scnprintf().
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
drivers/power/supply/twl4030_charger.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/supply/twl4030_charger.c
index 648ab80288c9..1bc49b2e12e8 100644
--- a/drivers/power/supply/twl4030_charger.c
+++ b/drivers/power/supply/twl4030_charger.c
@@ -726,10 +726,10 @@ twl4030_bci_mode_show(struct device *dev,
for (i = 0; i < ARRAY_SIZE(modes); i++)
if (mode == i)
- len += snprintf(buf+len, PAGE_SIZE-len,
+ len += scnprintf(buf+len, PAGE_SIZE-len,
"[%s] ", modes[i]);
else
- len += snprintf(buf+len, PAGE_SIZE-len,
+ len += scnprintf(buf+len, PAGE_SIZE-len,
"%s ", modes[i]);
buf[len-1] = '\n';
return len;
--
2.16.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: twl4030: Use scnprintf() for avoiding potential buffer overflow
2020-03-11 9:08 [PATCH] power: twl4030: Use scnprintf() for avoiding potential buffer overflow Takashi Iwai
@ 2020-03-11 22:23 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2020-03-11 22:23 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-pm
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
Hi,
On Wed, Mar 11, 2020 at 10:08:18AM +0100, Takashi Iwai wrote:
> Since snprintf() returns the would-be-output size instead of the
> actual output size, the succeeding calls may go beyond the given
> buffer limit. Fix it by replacing with scnprintf().
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/twl4030_charger.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/supply/twl4030_charger.c
> index 648ab80288c9..1bc49b2e12e8 100644
> --- a/drivers/power/supply/twl4030_charger.c
> +++ b/drivers/power/supply/twl4030_charger.c
> @@ -726,10 +726,10 @@ twl4030_bci_mode_show(struct device *dev,
>
> for (i = 0; i < ARRAY_SIZE(modes); i++)
> if (mode == i)
> - len += snprintf(buf+len, PAGE_SIZE-len,
> + len += scnprintf(buf+len, PAGE_SIZE-len,
> "[%s] ", modes[i]);
> else
> - len += snprintf(buf+len, PAGE_SIZE-len,
> + len += scnprintf(buf+len, PAGE_SIZE-len,
> "%s ", modes[i]);
> buf[len-1] = '\n';
> return len;
> --
> 2.16.4
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-11 22:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 9:08 [PATCH] power: twl4030: Use scnprintf() for avoiding potential buffer overflow Takashi Iwai
2020-03-11 22:23 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).