* [PATCH 10/11] kernel/power: constify sysrq_key_op [not found] <20200513214351.2138580-1-emil.l.velikov@gmail.com> @ 2020-05-13 21:43 ` Emil Velikov 2020-05-14 11:20 ` Rafael J. Wysocki 0 siblings, 1 reply; 4+ messages in thread From: Emil Velikov @ 2020-05-13 21:43 UTC (permalink / raw) To: dri-devel Cc: emil.l.velikov, Greg Kroah-Hartman, Jiri Slaby, linux-kernel, Rafael J. Wysocki, Len Brown, linux-pm With earlier commits, the API no longer discards the const-ness of the sysrq_key_op. As such we can add the notation. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Slaby <jslaby@suse.com> Cc: linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Len Brown <len.brown@intel.com> Cc: linux-pm@vger.kernel.org Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> --- Please keep me in the CC list, as I'm not subscribed to the list. IMHO it would be better if this gets merged this via the tty tree. --- kernel/power/poweroff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/power/poweroff.c b/kernel/power/poweroff.c index 6d475281c730..562aa0e450ed 100644 --- a/kernel/power/poweroff.c +++ b/kernel/power/poweroff.c @@ -29,7 +29,7 @@ static void handle_poweroff(int key) schedule_work_on(cpumask_first(cpu_online_mask), &poweroff_work); } -static struct sysrq_key_op sysrq_poweroff_op = { +static const struct sysrq_key_op sysrq_poweroff_op = { .handler = handle_poweroff, .help_msg = "poweroff(o)", .action_msg = "Power Off", -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 10/11] kernel/power: constify sysrq_key_op 2020-05-13 21:43 ` [PATCH 10/11] kernel/power: constify sysrq_key_op Emil Velikov @ 2020-05-14 11:20 ` Rafael J. Wysocki 2020-05-15 10:11 ` Emil Velikov 0 siblings, 1 reply; 4+ messages in thread From: Rafael J. Wysocki @ 2020-05-14 11:20 UTC (permalink / raw) To: Emil Velikov Cc: dri-devel, Greg Kroah-Hartman, Jiri Slaby, Linux Kernel Mailing List, Rafael J. Wysocki, Len Brown, Linux PM On Wed, May 13, 2020 at 11:46 PM Emil Velikov <emil.l.velikov@gmail.com> wrote: > > With earlier commits, the API no longer discards the const-ness of the > sysrq_key_op. As such we can add the notation. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: linux-kernel@vger.kernel.org > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Len Brown <len.brown@intel.com> > Cc: linux-pm@vger.kernel.org > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> and I'm assuming that this is going to be applied along with the rest of the series. > --- > Please keep me in the CC list, as I'm not subscribed to the list. > > IMHO it would be better if this gets merged this via the tty tree. > --- > kernel/power/poweroff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/power/poweroff.c b/kernel/power/poweroff.c > index 6d475281c730..562aa0e450ed 100644 > --- a/kernel/power/poweroff.c > +++ b/kernel/power/poweroff.c > @@ -29,7 +29,7 @@ static void handle_poweroff(int key) > schedule_work_on(cpumask_first(cpu_online_mask), &poweroff_work); > } > > -static struct sysrq_key_op sysrq_poweroff_op = { > +static const struct sysrq_key_op sysrq_poweroff_op = { > .handler = handle_poweroff, > .help_msg = "poweroff(o)", > .action_msg = "Power Off", > -- > 2.25.1 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 10/11] kernel/power: constify sysrq_key_op 2020-05-14 11:20 ` Rafael J. Wysocki @ 2020-05-15 10:11 ` Emil Velikov 2020-05-15 10:39 ` Greg Kroah-Hartman 0 siblings, 1 reply; 4+ messages in thread From: Emil Velikov @ 2020-05-15 10:11 UTC (permalink / raw) To: Rafael J. Wysocki Cc: dri-devel, Greg Kroah-Hartman, Jiri Slaby, Linux Kernel Mailing List, Rafael J. Wysocki, Len Brown, Linux PM On Thu, 14 May 2020 at 12:21, Rafael J. Wysocki <rafael@kernel.org> wrote: > > On Wed, May 13, 2020 at 11:46 PM Emil Velikov <emil.l.velikov@gmail.com> wrote: > > > > With earlier commits, the API no longer discards the const-ness of the > > sysrq_key_op. As such we can add the notation. > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Cc: Jiri Slaby <jslaby@suse.com> > > Cc: linux-kernel@vger.kernel.org > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > Cc: Len Brown <len.brown@intel.com> > > Cc: linux-pm@vger.kernel.org > > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Thanks > and I'm assuming that this is going to be applied along with the rest > of the series. > I believe so, although I have not heard anything from the TTY maintainers yet. -Emil ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 10/11] kernel/power: constify sysrq_key_op 2020-05-15 10:11 ` Emil Velikov @ 2020-05-15 10:39 ` Greg Kroah-Hartman 0 siblings, 0 replies; 4+ messages in thread From: Greg Kroah-Hartman @ 2020-05-15 10:39 UTC (permalink / raw) To: Emil Velikov Cc: Rafael J. Wysocki, dri-devel, Jiri Slaby, Linux Kernel Mailing List, Rafael J. Wysocki, Len Brown, Linux PM On Fri, May 15, 2020 at 11:11:57AM +0100, Emil Velikov wrote: > On Thu, 14 May 2020 at 12:21, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > On Wed, May 13, 2020 at 11:46 PM Emil Velikov <emil.l.velikov@gmail.com> wrote: > > > > > > With earlier commits, the API no longer discards the const-ness of the > > > sysrq_key_op. As such we can add the notation. > > > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > Cc: Jiri Slaby <jslaby@suse.com> > > > Cc: linux-kernel@vger.kernel.org > > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > > Cc: Len Brown <len.brown@intel.com> > > > Cc: linux-pm@vger.kernel.org > > > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > > > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > Thanks > > > and I'm assuming that this is going to be applied along with the rest > > of the series. > > > I believe so, although I have not heard anything from the TTY maintainers yet. I will take them all, thanks. greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-15 10:39 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20200513214351.2138580-1-emil.l.velikov@gmail.com> 2020-05-13 21:43 ` [PATCH 10/11] kernel/power: constify sysrq_key_op Emil Velikov 2020-05-14 11:20 ` Rafael J. Wysocki 2020-05-15 10:11 ` Emil Velikov 2020-05-15 10:39 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).