* [PATCH v2] cpufreq: CPPC: fix some unreasonable codes in cppc_cpufreq_perf_to_khz()
@ 2020-07-01 3:26 Xin Hao
2020-07-01 4:12 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Xin Hao @ 2020-07-01 3:26 UTC (permalink / raw)
To: rjw; +Cc: viresh.kumar, xhao, linux-pm, linux-kernel
The 'caps' variable has been defined, so there is no need to get
'highest_perf' value through 'cpu->caps.highest_perf', you can use
'caps->highest_perf' instead.
Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
---
drivers/cpufreq/cppc_cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
index 257d726a4456..444ee76a6bae 100644
--- a/drivers/cpufreq/cppc_cpufreq.c
+++ b/drivers/cpufreq/cppc_cpufreq.c
@@ -161,7 +161,7 @@ static unsigned int cppc_cpufreq_perf_to_khz(struct cppc_cpudata *cpu,
if (!max_khz)
max_khz = cppc_get_dmi_max_khz();
mul = max_khz;
- div = cpu->perf_caps.highest_perf;
+ div = caps->highest_perf;
}
return (u64)perf * mul / div;
}
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] cpufreq: CPPC: fix some unreasonable codes in cppc_cpufreq_perf_to_khz()
2020-07-01 3:26 [PATCH v2] cpufreq: CPPC: fix some unreasonable codes in cppc_cpufreq_perf_to_khz() Xin Hao
@ 2020-07-01 4:12 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2020-07-01 4:12 UTC (permalink / raw)
To: Xin Hao; +Cc: rjw, linux-pm, linux-kernel
On 01-07-20, 11:26, Xin Hao wrote:
> The 'caps' variable has been defined, so there is no need to get
> 'highest_perf' value through 'cpu->caps.highest_perf', you can use
> 'caps->highest_perf' instead.
>
> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
> ---
> drivers/cpufreq/cppc_cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 257d726a4456..444ee76a6bae 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -161,7 +161,7 @@ static unsigned int cppc_cpufreq_perf_to_khz(struct cppc_cpudata *cpu,
> if (!max_khz)
> max_khz = cppc_get_dmi_max_khz();
> mul = max_khz;
> - div = cpu->perf_caps.highest_perf;
> + div = caps->highest_perf;
> }
> return (u64)perf * mul / div;
> }
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-01 4:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-01 3:26 [PATCH v2] cpufreq: CPPC: fix some unreasonable codes in cppc_cpufreq_perf_to_khz() Xin Hao
2020-07-01 4:12 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).