From: Peter Zijlstra <peterz@infradead.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Daniel Kachhap <amit.kachhap@gmail.com>,
Javi Merino <javi.merino@kernel.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
linux-kernel@vger.kernel.org, Quentin Perret <qperret@google.com>,
Rafael Wysocki <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/2] thermal: cpufreq_cooling: Reuse effective_cpu_util()
Date: Tue, 14 Jul 2020 10:23:52 +0200 [thread overview]
Message-ID: <20200714082352.GN10769@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <b051b42f0c4f36d7177978e090c6a85df17922c6.1594707424.git.viresh.kumar@linaro.org>
On Tue, Jul 14, 2020 at 12:06:53PM +0530, Viresh Kumar wrote:
> Several parts of the kernel are already using the effective CPU
> utilization to get the current load on the CPU, do the same here instead
> of depending on the idle time of the CPU, which isn't that accurate
> comparatively.
>
> Note that, this (and CPU frequency scaling in general) doesn't work that
> well with idle injection as that is done from rt threads and is counted
> as load while it tries to do quite the opposite. That should be solved
> separately though.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/thermal/cpufreq_cooling.c | 65 +++++++------------------------
> 1 file changed, 15 insertions(+), 50 deletions(-)
>
> diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c
> index 6c0e1b053126..74340b2b0da7 100644
> --- a/drivers/thermal/cpufreq_cooling.c
> +++ b/drivers/thermal/cpufreq_cooling.c
> @@ -23,6 +23,7 @@
> #include <linux/thermal.h>
>
> #include <trace/events/thermal.h>
> +#include "../../kernel/sched/sched.h"
Hard NAK on that. Just writing it should've been a clue.
next prev parent reply other threads:[~2020-07-14 8:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 6:36 [PATCH 0/2] cpufreq_cooling: Get effective CPU utilization from scheduler Viresh Kumar
2020-07-14 6:36 ` [PATCH 1/2] sched/core: Rename and move schedutil_cpu_util to core.c Viresh Kumar
2020-07-14 12:52 ` Rafael J. Wysocki
2020-07-14 6:36 ` [PATCH 2/2] thermal: cpufreq_cooling: Reuse effective_cpu_util() Viresh Kumar
2020-07-14 8:23 ` Peter Zijlstra [this message]
2020-07-14 13:05 ` Rafael J. Wysocki
2020-07-15 7:32 ` Viresh Kumar
2020-07-15 12:47 ` Rafael J. Wysocki
2020-07-16 11:56 ` Peter Zijlstra
2020-07-16 14:24 ` Lukasz Luba
2020-07-16 15:43 ` Peter Zijlstra
2020-07-17 9:55 ` Lukasz Luba
2020-07-17 9:46 ` Vincent Guittot
2020-07-17 10:30 ` Lukasz Luba
2020-07-17 12:13 ` Vincent Guittot
2020-07-30 6:24 ` Viresh Kumar
2020-07-30 11:16 ` Lukasz Luba
2020-10-19 7:40 ` Viresh Kumar
2020-10-19 11:10 ` Lukasz Luba
2020-10-22 8:32 ` Viresh Kumar
2020-10-22 9:05 ` Peter Zijlstra
2020-10-22 11:06 ` Viresh Kumar
2020-10-22 11:30 ` Rafael J. Wysocki
2020-10-22 11:57 ` Peter Zijlstra
2020-10-22 12:07 ` Rafael J. Wysocki
2020-10-22 11:39 ` Peter Zijlstra
2020-07-17 10:14 ` Quentin Perret
2020-07-17 10:33 ` Quentin Perret
2020-07-17 10:43 ` Quentin Perret
2020-07-22 9:13 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714082352.GN10769@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=amit.kachhap@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=javi.merino@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=qperret@google.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).