* [PATCH] cpufreq: intel_pstate: Clean up aperf_mperf_shift description
@ 2020-07-15 13:54 Rafael J. Wysocki
2020-07-15 14:17 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-07-15 13:54 UTC (permalink / raw)
To: Linux PM; +Cc: LKML, Srinivas Pandruvada, Lee Jones
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
The kerneldoc description of the aperf_mperf_shift field in
struct global_params is unclear and there is a typo in it, so
simplify it and clean it up.
Reported-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/cpufreq/intel_pstate.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: linux-pm/drivers/cpufreq/intel_pstate.c
===================================================================
--- linux-pm.orig/drivers/cpufreq/intel_pstate.c
+++ linux-pm/drivers/cpufreq/intel_pstate.c
@@ -202,9 +202,7 @@ struct global_params {
* @pstate: Stores P state limits for this CPU
* @vid: Stores VID limits for this CPU
* @last_sample_time: Last Sample time
- * @aperf_mperf_shift: Number of clock cycles after aperf, merf is incremented
- * This shift is a multiplier to mperf delta to
- * calculate CPU busy.
+ * @aperf_mperf_shift: APERF vs MPERF counting frequency difference
* @prev_aperf: Last APERF value read from APERF MSR
* @prev_mperf: Last MPERF value read from MPERF MSR
* @prev_tsc: Last timestamp counter (TSC) value
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cpufreq: intel_pstate: Clean up aperf_mperf_shift description
2020-07-15 13:54 [PATCH] cpufreq: intel_pstate: Clean up aperf_mperf_shift description Rafael J. Wysocki
@ 2020-07-15 14:17 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2020-07-15 14:17 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Linux PM, LKML, Srinivas Pandruvada
On Wed, 15 Jul 2020, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The kerneldoc description of the aperf_mperf_shift field in
> struct global_params is unclear and there is a typo in it, so
> simplify it and clean it up.
>
> Reported-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/cpufreq/intel_pstate.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Index: linux-pm/drivers/cpufreq/intel_pstate.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/intel_pstate.c
> +++ linux-pm/drivers/cpufreq/intel_pstate.c
> @@ -202,9 +202,7 @@ struct global_params {
> * @pstate: Stores P state limits for this CPU
> * @vid: Stores VID limits for this CPU
> * @last_sample_time: Last Sample time
> - * @aperf_mperf_shift: Number of clock cycles after aperf, merf is incremented
> - * This shift is a multiplier to mperf delta to
> - * calculate CPU busy.
> + * @aperf_mperf_shift: APERF vs MPERF counting frequency difference
> * @prev_aperf: Last APERF value read from APERF MSR
> * @prev_mperf: Last MPERF value read from MPERF MSR
> * @prev_tsc: Last timestamp counter (TSC) value
Definitely clearer.
Reviewed-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-15 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-15 13:54 [PATCH] cpufreq: intel_pstate: Clean up aperf_mperf_shift description Rafael J. Wysocki
2020-07-15 14:17 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).