* [PATCH] power: supply: rt5033_battery: Fix error code in rt5033_battery_probe()
@ 2020-07-02 8:58 Peng Fan
2020-07-28 0:19 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Peng Fan @ 2020-07-02 8:58 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: linux-pm, linux-kernel, Xuefeng Li, Tiezhu Yang
In the function rt5033_battery_probe(), it should return -ENOMEM
instead of -EINVAL when call function devm_kzalloc() failed.
Signed-off-by: Peng Fan <fanpeng@loongson.cn>
---
drivers/power/supply/rt5033_battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/rt5033_battery.c b/drivers/power/supply/rt5033_battery.c
index d8667a9..f330452 100644
--- a/drivers/power/supply/rt5033_battery.c
+++ b/drivers/power/supply/rt5033_battery.c
@@ -125,7 +125,7 @@ static int rt5033_battery_probe(struct i2c_client *client,
battery = devm_kzalloc(&client->dev, sizeof(*battery), GFP_KERNEL);
if (!battery)
- return -EINVAL;
+ return -ENOMEM;
battery->client = client;
battery->regmap = devm_regmap_init_i2c(client,
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: supply: rt5033_battery: Fix error code in rt5033_battery_probe()
2020-07-02 8:58 [PATCH] power: supply: rt5033_battery: Fix error code in rt5033_battery_probe() Peng Fan
@ 2020-07-28 0:19 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2020-07-28 0:19 UTC (permalink / raw)
To: Peng Fan; +Cc: linux-pm, linux-kernel, Xuefeng Li, Tiezhu Yang
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
Hi,
On Thu, Jul 02, 2020 at 04:58:52PM +0800, Peng Fan wrote:
> In the function rt5033_battery_probe(), it should return -ENOMEM
> instead of -EINVAL when call function devm_kzalloc() failed.
>
> Signed-off-by: Peng Fan <fanpeng@loongson.cn>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/rt5033_battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/rt5033_battery.c b/drivers/power/supply/rt5033_battery.c
> index d8667a9..f330452 100644
> --- a/drivers/power/supply/rt5033_battery.c
> +++ b/drivers/power/supply/rt5033_battery.c
> @@ -125,7 +125,7 @@ static int rt5033_battery_probe(struct i2c_client *client,
>
> battery = devm_kzalloc(&client->dev, sizeof(*battery), GFP_KERNEL);
> if (!battery)
> - return -EINVAL;
> + return -ENOMEM;
>
> battery->client = client;
> battery->regmap = devm_regmap_init_i2c(client,
> --
> 2.1.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-28 0:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-02 8:58 [PATCH] power: supply: rt5033_battery: Fix error code in rt5033_battery_probe() Peng Fan
2020-07-28 0:19 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).